Skip to content

Commit ba12d5b

Browse files
Karthik Palanisamysaintstack
authored andcommitted
HBASE-23123 Merge_region fails from shell (#690)
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com> Signed-off-by: Duo Zhang <zhangduo@apache.org>
1 parent fdac2dd commit ba12d5b

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

hbase-shell/src/main/ruby/hbase/admin.rb

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -533,9 +533,12 @@ def move(encoded_region_name, server = nil)
533533
#----------------------------------------------------------------------------------------------
534534
# Merge two regions
535535
def merge_region(region_a_name, region_b_name, force)
536-
@admin.mergeRegions(region_a_name.to_java_bytes,
537-
region_b_name.to_java_bytes,
538-
java.lang.Boolean.valueOf(force))
536+
@admin.mergeRegionsAsync(
537+
region_a_name.to_java_bytes,
538+
region_b_name.to_java_bytes,
539+
java.lang.Boolean.valueOf(force)
540+
)
541+
return nil
539542
end
540543

541544
#----------------------------------------------------------------------------------------------

hbase-shell/src/test/ruby/hbase/admin_test.rb

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -574,6 +574,17 @@ def teardown
574574
define_test "list regions should allow table name" do
575575
command(:list_regions, @test_name)
576576
end
577+
578+
define_test 'merge two regions' do
579+
@t_name = 'hbase_shell_merge'
580+
drop_test_table(@t_name)
581+
admin.create(@t_name, 'a', NUMREGIONS => 10, SPLITALGO => 'HexStringSplit')
582+
r1 = command(:locate_region, @t_name, '')
583+
r2 = command(:locate_region, @t_name, '1')
584+
region1 = r1.getRegion.getRegionNameAsString
585+
region2 = r2.getRegion.getRegionNameAsString
586+
command(:merge_region, region1, region2, true)
587+
end
577588
end
578589

579590
# Simple administration methods tests

0 commit comments

Comments
 (0)