Show the create time of the replication peer

Wangx · Wangx · commit b8d75835c748 · 2024-06-08T22:52:06.000+08:00
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerDescription.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerDescription.java
@@ -32,6 +32,7 @@ public class ReplicationPeerDescription {
   private final boolean enabled;
   private final ReplicationPeerConfig config;
   private final SyncReplicationState syncReplicationState;
+  private String createTime;
 
   public ReplicationPeerDescription(String id, boolean enabled, ReplicationPeerConfig config,
     SyncReplicationState syncReplicationState) {
@@ -41,6 +42,19 @@ public ReplicationPeerDescription(String id, boolean enabled, ReplicationPeerCon
     this.syncReplicationState = syncReplicationState;
   }
 
+  public ReplicationPeerDescription(String id, boolean enabled, ReplicationPeerConfig config,
+    SyncReplicationState syncReplicationState, String createTime) {
+    this.id = id;
+    this.enabled = enabled;
+    this.config = config;
+    this.syncReplicationState = syncReplicationState;
+    this.createTime = createTime;
+  }
+
+  public String getCreateTime() {
+    return createTime;
+  }
+
   public String getPeerId() {
     return this.id;
   }
@@ -63,6 +77,7 @@ public String toString() {
     builder.append(", enabled : " + enabled);
     builder.append(", config : " + config);
     builder.append(", syncReplicationState : " + syncReplicationState);
+    builder.append(", createTime : " + createTime);
     return builder.toString();
   }
 }
diff --git a/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/FSReplicationPeerStorage.java b/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/FSReplicationPeerStorage.java
@@ -227,6 +227,16 @@ public ReplicationPeerConfig getPeerConfig(String peerId) throws ReplicationExce
     }
   }
 
+  @Override
+  public long getPeerCreateTime(String peerId) throws ReplicationException {
+    Path peerDir = getPeerDir(peerId);
+    try {
+      return fs.getFileStatus(peerDir).getModificationTime();
+    } catch (IOException e) {
+      throw new ReplicationException("Unable to get create time of the peer with id=" + peerId, e);
+    }
+  }
+
   private Pair<SyncReplicationState, SyncReplicationState> getStateAndNewState(String peerId)
     throws IOException {
     Path peerDir = getPeerDir(peerId);
diff --git a/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerStorage.java b/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerStorage.java
@@ -70,6 +70,12 @@ void updatePeerConfig(String peerId, ReplicationPeerConfig peerConfig)
    */
   ReplicationPeerConfig getPeerConfig(String peerId) throws ReplicationException;
 
+  /**
+   * Get the peer create time of a replication peer.
+   * @throws ReplicationException if there are errors accessing the storage service.
+   */
+  long getPeerCreateTime(String peerId) throws ReplicationException;
+
   /**
    * Set the new sync replication state that we are going to transit to.
    * @throws ReplicationException if there are errors accessing the storage service.
diff --git a/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationPeerStorage.java b/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationPeerStorage.java
@@ -185,6 +185,17 @@ public ReplicationPeerConfig getPeerConfig(String peerId) throws ReplicationExce
     }
   }
 
+  @Override
+  public long getPeerCreateTime(String peerId) throws ReplicationException {
+    long createTimeIfNodeExists;
+    try {
+      createTimeIfNodeExists = ZKUtil.getCreateTimeIfNodeExists(zookeeper, getPeerNode(peerId));
+      return createTimeIfNodeExists;
+    } catch (KeeperException e) {
+      throw new ReplicationException("Error getting create time for peer with id=" + peerId, e);
+    }
+  }
+
   @Override
   public void setPeerNewSyncReplicationState(String peerId, SyncReplicationState state)
     throws ReplicationException {
diff --git a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
@@ -750,6 +750,7 @@ AssignmentManager assignmentManager = master.getAssignmentManager();
 </%java>
 <table class="table table-striped">
     <tr>
+        <th>Create Time</th>
         <th>Peer Id</th>
         <th>Cluster Key</th>
         <th>Endpoint</th>
@@ -771,6 +772,7 @@ AssignmentManager assignmentManager = master.getAssignmentManager();
         ReplicationPeerConfig peerConfig = peer.getPeerConfig();
     </%java>
     <tr>
+        <td><% peer.getCreateTime() %></td>
         <td><% peerId %></td>
         <td><% peerConfig.getClusterKey() %></td>
         <td><% peerConfig.getReplicationEndpointImpl() %></td>
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java
@@ -20,6 +20,8 @@
 import com.google.errorprone.annotations.RestrictedApi;
 import java.io.IOException;
 import java.net.URI;
+import java.text.DateFormat;
+import java.text.SimpleDateFormat;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.EnumSet;
@@ -96,6 +98,8 @@ public class ReplicationPeerManager implements ConfigurationObserver {
 
   private static final Logger LOG = LoggerFactory.getLogger(ReplicationPeerManager.class);
 
+  private static final DateFormat DATE_FORMAT = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
+
   private volatile ReplicationPeerStorage peerStorage;
 
   private final ReplicationQueueStorage queueStorage;
@@ -288,8 +292,10 @@ public void addPeer(String peerId, ReplicationPeerConfig peerConfig, boolean ena
       ? SyncReplicationState.DOWNGRADE_ACTIVE
       : SyncReplicationState.NONE;
     peerStorage.addPeer(peerId, copiedPeerConfig, enabled, syncReplicationState);
+    long peerCreateTime = peerStorage.getPeerCreateTime(peerId);
+    String peerCreateTimeStr = peerCreateTime == -1 ? "" : DATE_FORMAT.format(peerCreateTime);
     peers.put(peerId,
-      new ReplicationPeerDescription(peerId, enabled, copiedPeerConfig, syncReplicationState));
+      new ReplicationPeerDescription(peerId, enabled, copiedPeerConfig, syncReplicationState, peerCreateTimeStr));
   }
 
   public void removePeer(String peerId) throws ReplicationException {
@@ -309,7 +315,7 @@ private void setPeerState(String peerId, boolean enabled) throws ReplicationExce
     }
     peerStorage.setPeerState(peerId, enabled);
     peers.put(peerId, new ReplicationPeerDescription(peerId, enabled, desc.getPeerConfig(),
-      desc.getSyncReplicationState()));
+      desc.getSyncReplicationState(), desc.getCreateTime()));
   }
 
   public boolean getPeerState(String peerId) throws ReplicationException {
@@ -342,7 +348,7 @@ public void updatePeerConfig(String peerId, ReplicationPeerConfig peerConfig)
     ReplicationPeerConfig newPeerConfig = newPeerConfigBuilder.build();
     peerStorage.updatePeerConfig(peerId, newPeerConfig);
     peers.put(peerId, new ReplicationPeerDescription(peerId, desc.isEnabled(), newPeerConfig,
-      desc.getSyncReplicationState()));
+      desc.getSyncReplicationState(), desc.getCreateTime()));
   }
 
   public List<ReplicationPeerDescription> listPeers(Pattern pattern) {
@@ -377,7 +383,7 @@ public void transitPeerSyncReplicationState(String peerId, SyncReplicationState
     if (desc.getSyncReplicationState() != newState) {
       // Only recreate the desc if this is not a retry
       peers.put(peerId,
-        new ReplicationPeerDescription(peerId, desc.isEnabled(), desc.getPeerConfig(), newState));
+        new ReplicationPeerDescription(peerId, desc.isEnabled(), desc.getPeerConfig(), newState, desc.getCreateTime()));
     }
   }
 
@@ -692,7 +698,10 @@ public void run() {
       peerStorage.updatePeerConfig(peerId, peerConfig);
       boolean enabled = peerStorage.isPeerEnabled(peerId);
       SyncReplicationState state = peerStorage.getPeerSyncReplicationState(peerId);
-      peers.put(peerId, new ReplicationPeerDescription(peerId, enabled, peerConfig, state));
+      long peerCreateTime = peerStorage.getPeerCreateTime(peerId);
+      String peerCreateTimeStr = peerCreateTime == -1 ? "" : DATE_FORMAT.format(peerCreateTime);
+      peers.put(peerId,
+        new ReplicationPeerDescription(peerId, enabled, peerConfig, state, peerCreateTimeStr));
     }
     return new ReplicationPeerManager(fs, zk, peerStorage, queueStorage, peers, conf, clusterId,
       pair.getSecond());
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestLogsCleaner.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestLogsCleaner.java
@@ -207,7 +207,7 @@ public void testLogCleaning() throws Exception {
     }
     // Case 4: the newest 3 WALs will be kept because they are beyond the replication offset
     masterServices.getReplicationPeerManager().listPeers(null)
-      .add(new ReplicationPeerDescription(peerId, true, null, null));
+      .add(new ReplicationPeerDescription(peerId, true, null, null, null));
     queueStorage.setOffset(new ReplicationQueueId(server.getServerName(), peerId), fakeMachineName,
       new ReplicationGroupOffset(fakeMachineName + "." + (now - 3), 0), Collections.emptyMap());
     // Case 5: 5 Procedure WALs that are new, will stay
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/master/TestReplicationLogCleaner.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/master/TestReplicationLogCleaner.java
@@ -123,7 +123,7 @@ private static FileStatus createFileStatus(ServerName sn, int number) {
   }
 
   private static ReplicationPeerDescription createPeer(String peerId) {
-    return new ReplicationPeerDescription(peerId, true, null, null);
+    return new ReplicationPeerDescription(peerId, true, null, null, null);
   }
 
   private void addServer(ServerName serverName) {
diff --git a/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java b/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
@@ -168,6 +168,28 @@ public static int checkExists(ZKWatcher zkw, String znode) throws KeeperExceptio
     }
   }
 
+  /**
+   * Get the create time if the specified node exists.
+   * @param zkw   zk reference
+   * @param znode path of node to watch
+   * @return create time of the node if it exists, -1 if does not exist
+   * @throws KeeperException if unexpected zookeeper exception
+   */
+  public static long getCreateTimeIfNodeExists(ZKWatcher zkw, String znode) throws KeeperException {
+    try {
+      Stat s = zkw.getRecoverableZooKeeper().exists(znode, false);
+      return s != null ? s.getCtime() : -1;
+    } catch (KeeperException e) {
+      LOG.warn(zkw.prefix("Unable to get create time on znode (" + znode + ")"), e);
+      zkw.keeperException(e);
+      return -1;
+    } catch (InterruptedException e) {
+      LOG.warn(zkw.prefix("Unable to get create time on znode (" + znode + ")"), e);
+      zkw.interruptedException(e);
+      return -1;
+    }
+  }
+
   //
   // Znode listings
   //

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ public void testLogCleaning() throws Exception {`
`207`	`207`	`}`
`208`	`208`	`// Case 4: the newest 3 WALs will be kept because they are beyond the replication offset`
`209`	`209`	`masterServices.getReplicationPeerManager().listPeers(null)`
`210`		`- .add(new ReplicationPeerDescription(peerId, true, null, null));`
	`210`	`+ .add(new ReplicationPeerDescription(peerId, true, null, null, null));`
`211`	`211`	`queueStorage.setOffset(new ReplicationQueueId(server.getServerName(), peerId), fakeMachineName,`
`212`	`212`	`new ReplicationGroupOffset(fakeMachineName + "." + (now - 3), 0), Collections.emptyMap());`
`213`	`213`	`// Case 5: 5 Procedure WALs that are new, will stay`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ private static FileStatus createFileStatus(ServerName sn, int number) {`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`private static ReplicationPeerDescription createPeer(String peerId) {`
`126`		`- return new ReplicationPeerDescription(peerId, true, null, null);`
	`126`	`+ return new ReplicationPeerDescription(peerId, true, null, null, null);`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`private void addServer(ServerName serverName) {`