Skip to content

Commit b33da76

Browse files
murtazahassan123HorizonNet
authored andcommitted
HBASE-22725 Remove all remaining Javadoc warnings
Signed-off-by: stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
1 parent 688a388 commit b33da76

File tree

9 files changed

+47
-35
lines changed

9 files changed

+47
-35
lines changed

hbase-client/src/main/java/org/apache/hadoop/hbase/client/SimpleRequestController.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -432,9 +432,10 @@ private void waitForRegion() throws InterruptedIOException {
432432
* regions. 3) check the total concurrent tasks. 4) check the concurrent
433433
* tasks for server.
434434
*
435-
* @param loc
436-
* @param heapSizeOfRow
437-
* @return either Include {@link ReturnCode} or Skip {@link ReturnCode}
435+
* @param loc the destination of data
436+
* @param heapSizeOfRow the data size
437+
* @return either Include {@link RequestController.ReturnCode} or skip
438+
* {@link RequestController.ReturnCode}
438439
*/
439440
@Override
440441
public ReturnCode canTakeOperation(HRegionLocation loc, long heapSizeOfRow) {

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,9 @@ default Result get(Get get) throws IOException {
203203
* @throws IOException if a remote or network exception occurs.
204204
* @since 0.90.0
205205
* @apiNote {@link #put(List)} runs pre-flight validations on the input list on client.
206-
* Currently {@link #get(List)} doesn't run any validations on the client-side, currently there
207-
* is no need, but this may change in the future. An
208-
* {@link IllegalArgumentException} will be thrown in this case.
206+
* Currently {@link #get(List)} doesn't run any validations on the client-side,
207+
* currently there is no need, but this may change in the future. An
208+
* {@link IllegalArgumentException} will be thrown in this case.
209209
*/
210210
default Result[] get(List<Get> gets) throws IOException {
211211
throw new NotImplementedException("Add an implementation!");
@@ -389,10 +389,10 @@ default void delete(Delete delete) throws IOException {
389389
* that have not be successfully applied.
390390
* @since 0.20.1
391391
* @apiNote In 3.0.0 version, the input list {@code deletes} will no longer be modified. Also,
392-
* {@link #put(List)} runs pre-flight validations on the input list on client. Currently
393-
* {@link #delete(List)} doesn't run validations on the client, there is no need currently,
394-
* but this may change in the future. An * {@link IllegalArgumentException} will be thrown
395-
* in this case.
392+
* {@link #put(List)} runs pre-flight validations on the input list on client. Currently
393+
* {@link #delete(List)} doesn't run validations on the client, there is no need
394+
* currently, but this may change in the future. An * {@link IllegalArgumentException}
395+
* will be thrown in this case.
396396
*/
397397
default void delete(List<Delete> deletes) throws IOException {
398398
throw new NotImplementedException("Add an implementation!");

hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Batch.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public abstract class Batch {
3939
* the implementations {@link Batch.Call#call(Object)} method will be invoked
4040
* with a proxy to each region's coprocessor {@link com.google.protobuf.Service} implementation.
4141
* </p>
42-
* @see org.apache.hadoop.hbase.client.coprocessor
42+
* @see org.apache.hadoop.hbase.client.coprocessor.Batch
4343
* @see org.apache.hadoop.hbase.client.Table#coprocessorService(byte[])
4444
* @see org.apache.hadoop.hbase.client.Table#coprocessorService(Class, byte[], byte[],
4545
* org.apache.hadoop.hbase.client.coprocessor.Batch.Call)

hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,10 @@ private Path getOutputPath(final SnapshotFileInfo inputInfo) throws IOException
259259
return new Path(outputArchive, path);
260260
}
261261

262+
@SuppressWarnings("checkstyle:linelength")
262263
/**
263264
* Used by TestExportSnapshot to test for retries when failures happen.
264-
* Failure is injected in {@link #copyFile(Context, SnapshotFileInfo, Path)}.
265+
* Failure is injected in {@link #copyFile(Mapper.Context, org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotProtos.SnapshotFileInfo, Path)}.
265266
*/
266267
private void injectTestFailure(final Context context, final SnapshotFileInfo inputInfo)
267268
throws IOException {

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3877,7 +3877,7 @@ public OperationStatus[] batchReplay(MutationReplay[] mutations, long replaySeqI
38773877
* a batch are stored with highest durability specified of for all operations in a batch,
38783878
* except for {@link Durability#SKIP_WAL}.
38793879
*
3880-
* <p>This function is called from {@link #batchReplay(MutationReplay[], long)} with
3880+
* <p>This function is called from {@link #batchReplay(WALSplitUtil.MutationReplay[], long)} with
38813881
* {@link ReplayBatchOperation} instance and {@link #batchMutate(Mutation[], long, long)} with
38823882
* {@link MutationBatchOperation} instance as an argument. As the processing of replay batch
38833883
* and mutation batch is very similar, lot of code is shared by providing generic methods in
@@ -3888,7 +3888,7 @@ public OperationStatus[] batchReplay(MutationReplay[] mutations, long replaySeqI
38883888
* @param batchOp contains the list of mutations
38893889
* @return an array of OperationStatus which internally contains the
38903890
* OperationStatusCode and the exceptionMessage if any.
3891-
* @throws IOException
3891+
* @throws IOException if an IO problem is encountered
38923892
*/
38933893
OperationStatus[] batchMutate(BatchOperation<?> batchOp) throws IOException {
38943894
boolean initialized = false;

hbase-server/src/main/java/org/apache/hadoop/hbase/tool/LoadIncrementalHFiles.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,8 @@ private boolean checkHFilesCountPerRegionPerFamily(
590590
}
591591

592592
/**
593-
* @param table the table to load into
593+
* @param conn the HBase cluster connection
594+
* @param tableName the table name of the table to load into
594595
* @param pool the ExecutorService
595596
* @param queue the queue for LoadQueueItem
596597
* @param startEndKeys start and end keys

hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1871,16 +1871,16 @@ public HRegion createLocalHRegion(RegionInfo info, TableDescriptor desc, WAL wal
18711871
}
18721872

18731873
/**
1874-
* @param tableName
1875-
* @param startKey
1876-
* @param stopKey
1877-
* @param callingMethod
1878-
* @param conf
1879-
* @param isReadOnly
1880-
* @param families
1881-
* @throws IOException
1882-
* @return A region on which you must call
1883-
{@link HBaseTestingUtility#closeRegionAndWAL(HRegion)} when done.
1874+
* @param tableName the name of the table
1875+
* @param startKey the start key of the region
1876+
* @param stopKey the stop key of the region
1877+
* @param callingMethod the name of the calling method probably a test method
1878+
* @param conf the configuration to use
1879+
* @param isReadOnly {@code true} if the table is read only, {@code false} otherwise
1880+
* @param families the column families to use
1881+
* @throws IOException if an IO problem is encountered
1882+
* @return A region on which you must call {@link HBaseTestingUtility#closeRegionAndWAL(HRegion)}
1883+
* when done.
18841884
* @deprecated since 2.0.0 and will be removed in 3.0.0. Use
18851885
* {@link #createLocalHRegion(TableName, byte[], byte[], boolean, Durability, WAL, byte[]...)}
18861886
* instead.
@@ -3127,10 +3127,9 @@ public boolean visit(Result r) throws IOException {
31273127
* Waits for a table to be 'enabled'. Enabled means that table is set as 'enabled' and the
31283128
* regions have been all assigned. Will timeout after default period (30 seconds)
31293129
* Tolerates nonexistent table.
3130-
* @param table Table to wait on.
3131-
* @param table
3132-
* @throws InterruptedException
3133-
* @throws IOException
3130+
* @param table the table to wait on.
3131+
* @throws InterruptedException if interrupted while waiting
3132+
* @throws IOException if an IO problem is encountered
31343133
*/
31353134
public void waitTableEnabled(TableName table)
31363135
throws InterruptedException, IOException {

hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,8 @@ class MockRegionServer implements AdminProtos.AdminService.BlockingInterface,
143143
private final Random random = new Random();
144144

145145
/**
146-
* Map of regions to map of rows and {@link Result}. Used as data source when
147-
* {@link #get(RpcController, GetRequest)} is called. Because we have a byte
146+
* Map of regions to map of rows and {@link Result}. Used as data source when
147+
* {@link #get(RpcController, ClientProtos.GetRequest)} is called. Because we have a byte
148148
* key, need to use TreeMap and provide a Comparator. Use
149149
* {@link #setGetResult(byte[], byte[], Result)} filling this map.
150150
*/
@@ -195,10 +195,11 @@ int getThenIncrement() {
195195
}
196196

197197
/**
198-
* Use this method filling the backing data source used by {@link #get(RpcController, GetRequest)}
199-
* @param regionName
200-
* @param row
201-
* @param r
198+
* Use this method filling the backing data source used by
199+
* {@link #get(RpcController, ClientProtos.GetRequest)}
200+
* @param regionName the region name to assign
201+
* @param row the row key
202+
* @param r the single row result
202203
*/
203204
void setGetResult(final byte [] regionName, final byte [] row, final Result r) {
204205
Map<byte [], Result> value = this.gets.get(regionName);

pom.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3559,6 +3559,15 @@
35593559
<plugin>
35603560
<groupId>org.apache.maven.plugins</groupId>
35613561
<artifactId>maven-javadoc-plugin</artifactId>
3562+
<configuration>
3563+
<tags>
3564+
<tag>
3565+
<name>apiNote</name>
3566+
<placement>a</placement>
3567+
<head>API Note:</head>
3568+
</tag>
3569+
</tags>
3570+
</configuration>
35623571
<reportSets>
35633572
<!-- Dev API -->
35643573
<reportSet>

0 commit comments

Comments
 (0)