Skip to content

Commit a540882

Browse files
committed
HBASE-20391 close out stale or finished PRs on github.
* closes #51 - > 1 month since notification * closes #61 - HBASE-18928 has already closed * closes #62 - HBASE-18929 has already closed * closes #67 - HBASE-19386 has already closed * closes #68 - HBASE-19387 has already closed Also adds a section to the committer guide in the reference guide about closing PRs. Signed-off-by: Mike Drob <mdrob@apache.org>
1 parent 8f1ac01 commit a540882

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/main/asciidoc/_chapters/developer.adoc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2177,6 +2177,12 @@ When the amending author is different from the original committer, add notice of
21772177
- [DISCUSSION] Best practice when amending commits cherry picked
21782178
from master to branch].
21792179

2180+
====== Close related GitHub PRs
2181+
2182+
As a project we work to ensure there's a JIRA associated with each change, but we don't mandate any particular tool be used for reviews. Due to implementation details of the ASF's integration between hosted git repositories and GitHub, the PMC has no ability to directly close PRs on our GitHub repo. In the event that a contributor makes a Pull Request on GitHub, either because the contributor finds that easier than attaching a patch to JIRA or because a reviewer prefers that UI for examining changes, it's important to make note of the PR in the commit that goes to the master branch so that PRs are kept up to date.
2183+
2184+
To read more about the details of what kinds of commit messages will work with the GitHub "close via keyword in commit" mechanism see link:https://help.github.com/articles/closing-issues-using-keywords/[the GitHub documentation for "Closing issues using keywords"]. In summary, you should include a line with the phrase "closes #XXX", where the XXX is the pull request id. The pull request id is usually given in the GitHub UI in grey at the end of the subject heading.
2185+
21802186
[[committer.tests]]
21812187
====== Committers are responsible for making sure commits do not break the build or tests
21822188

0 commit comments

Comments
 (0)