Skip to content

Commit 7f07375

Browse files
committed
HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
1 parent e26f695 commit 7f07375

File tree

5 files changed

+305
-17
lines changed

5 files changed

+305
-17
lines changed

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7177,8 +7177,9 @@ HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws IOException
71777177
fs.commitDaughterRegion(hri);
71787178

71797179
// Create the daughter HRegion instance
7180-
HRegion r = HRegion.newHRegion(this.fs.getTableDir(), this.getWAL(), fs.getFileSystem(),
7181-
this.getBaseConf(), hri, this.getTableDesc(), rsServices);
7180+
HRegion r = HRegion.newHRegion(this.fs.getTableDir(),
7181+
rsServices == null ? getWAL() :rsServices.getWAL(hri), // rsServices can be null in UT
7182+
fs.getFileSystem(), this.getBaseConf(), hri, this.getTableDesc(), rsServices);
71827183
r.readRequestsCount.set(this.getReadRequestsCount() / 2);
71837184
r.writeRequestsCount.set(this.getWriteRequestsCount() / 2);
71847185
return r;

hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedGroupingStrategy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public void init(Configuration config, String providerId) {
7272
int regionGroupNumber = config.getInt(NUM_REGION_GROUPS, DEFAULT_NUM_REGION_GROUPS);
7373
groupNames = new String[regionGroupNumber];
7474
for (int i = 0; i < regionGroupNumber; i++) {
75-
groupNames[i] = providerId + GROUP_NAME_DELIMITER + "regiongroup-" + i;
75+
groupNames[i] = "regiongroup-" + i;
7676
}
7777
}
7878

hbase-server/src/main/java/org/apache/hadoop/hbase/wal/NamespaceGroupingStrategy.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
*/
3232
@InterfaceAudience.Private
3333
public class NamespaceGroupingStrategy implements RegionGroupingStrategy {
34-
private String providerId;
3534

3635
@Override
3736
public String group(byte[] identifier, byte[] namespace) {
@@ -41,12 +40,10 @@ public String group(byte[] identifier, byte[] namespace) {
4140
} else {
4241
namespaceString = Bytes.toString(namespace);
4342
}
44-
return providerId + GROUP_NAME_DELIMITER + namespaceString;
43+
return namespaceString;
4544
}
4645

4746
@Override
48-
public void init(Configuration config, String providerId) {
49-
this.providerId = providerId;
50-
}
47+
public void init(Configuration config, String providerId) {}
5148

5249
}

hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RegionGroupingProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ static class IdentityGroupingStrategy implements RegionGroupingStrategy {
252252
public void init(Configuration config, String providerId) {}
253253
@Override
254254
public String group(final byte[] identifier, final byte[] namespace) {
255-
return Bytes.toString(identifier);
255+
return "identity-" + Bytes.toString(identifier);
256256
}
257257
}
258258

0 commit comments

Comments
 (0)