Skip to content

Commit 751330c

Browse files
taiynleeHorizonNet
authored andcommitted
HBASE-20509 putting List in HashSet directly without using addAll function to improve performance
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
1 parent 21093fd commit 751330c

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeAssignmentHelper.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -395,8 +395,7 @@ private ServerName[] multiRackCaseWithRestrictions(
395395
rackSkipSet.add(primaryRack);
396396
String secondaryRack = getOneRandomRack(rackSkipSet);
397397
List<ServerName> serverList = getServersFromRack(secondaryRack);
398-
Set<ServerName> serverSet = new HashSet<>();
399-
serverSet.addAll(serverList);
398+
Set<ServerName> serverSet = new HashSet<>(serverList);
400399
ServerName[] favoredNodes;
401400
if (serverList.size() >= 2) {
402401
// Randomly pick up two servers from this secondary rack
@@ -433,8 +432,7 @@ private ServerName[] multiRackCaseWithRestrictions(
433432
}
434433
secondaryRack = getOneRandomRack(rackSkipSet);
435434
serverList = getServersFromRack(secondaryRack);
436-
serverSet = new HashSet<>();
437-
serverSet.addAll(serverList);
435+
serverSet = new HashSet<>(serverList);
438436
}
439437

440438
// Place the secondary RS

0 commit comments

Comments
 (0)