Skip to content

Commit 6e1d7f0

Browse files
committed
HBASE-24371 Add more details when print CompactionConfiguration info (#1711)
Signed-off-by: Anoop Sam John <anoopsamjohn@apache.org>
1 parent abe5a05 commit 6e1d7f0

File tree

5 files changed

+17
-2
lines changed

5 files changed

+17
-2
lines changed

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
*/
1919
package org.apache.hadoop.hbase.regionserver;
2020

21+
import org.apache.hadoop.hbase.client.RegionInfo;
2122
import org.apache.yetus.audience.InterfaceAudience;
2223
import org.apache.yetus.audience.InterfaceStability;
2324

@@ -53,4 +54,8 @@ public interface StoreConfigInformation {
5354
* The number of files required before flushes for this store will be blocked.
5455
*/
5556
long getBlockingFileCount();
57+
58+
RegionInfo getRegionInfo();
59+
60+
String getColumnFamilyName();
5661
}

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
import org.apache.hadoop.conf.Configuration;
2323
import org.apache.hadoop.hbase.HConstants;
24+
import org.apache.hadoop.hbase.client.RegionInfo;
2425
import org.apache.hadoop.util.StringUtils;
2526
import org.apache.yetus.audience.InterfaceAudience;
2627
import org.slf4j.Logger;
@@ -154,7 +155,8 @@ public String toString() {
154155
+ " major period %d, major jitter %f, min locality to compact %f;"
155156
+ " tiered compaction: max_age %d, incoming window min %d,"
156157
+ " compaction policy for tiered window %s, single output for minor %b,"
157-
+ " compaction window factory %s",
158+
+ " compaction window factory %s,"
159+
+ " region %s columnFamilyName %s",
158160
StringUtils.byteDesc(minCompactSize),
159161
StringUtils.byteDesc(maxCompactSize),
160162
StringUtils.byteDesc(offPeakMaxCompactSize),
@@ -170,7 +172,9 @@ public String toString() {
170172
dateTieredIncomingWindowMin,
171173
compactionPolicyForDateTieredWindow,
172174
dateTieredSingleOutputForMinorCompaction,
173-
dateTieredCompactionWindowFactory
175+
dateTieredCompactionWindowFactory,
176+
RegionInfo.prettyPrint(storeConfigInfo.getRegionInfo().getEncodedName()),
177+
storeConfigInfo.getColumnFamilyName()
174178
);
175179
}
176180

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultStoreEngine.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import org.apache.hadoop.hbase.CellComparatorImpl;
2222
import org.apache.hadoop.hbase.HBaseClassTestRule;
2323
import org.apache.hadoop.hbase.HBaseConfiguration;
24+
import org.apache.hadoop.hbase.HRegionInfo;
2425
import org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor;
2526
import org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy;
2627
import org.apache.hadoop.hbase.testclassification.RegionServerTests;
@@ -65,6 +66,7 @@ public void testCustomParts() throws Exception {
6566
conf.set(DefaultStoreEngine.DEFAULT_STORE_FLUSHER_CLASS_KEY,
6667
DummyStoreFlusher.class.getName());
6768
HStore mockStore = Mockito.mock(HStore.class);
69+
Mockito.when(mockStore.getRegionInfo()).thenReturn(HRegionInfo.FIRST_META_REGIONINFO);
6870
StoreEngine<?, ?, ?, ?> se = StoreEngine.create(mockStore, conf, CellComparatorImpl.COMPARATOR);
6971
Assert.assertTrue(se instanceof DefaultStoreEngine);
7072
Assert.assertTrue(se.getCompactionPolicy() instanceof DummyCompactionPolicy);

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStripeStoreEngine.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.apache.hadoop.hbase.CellComparatorImpl;
3737
import org.apache.hadoop.hbase.HBaseClassTestRule;
3838
import org.apache.hadoop.hbase.HBaseConfiguration;
39+
import org.apache.hadoop.hbase.HRegionInfo;
3940
import org.apache.hadoop.hbase.regionserver.compactions.CompactionContext;
4041
import org.apache.hadoop.hbase.regionserver.compactions.CompactionRequestImpl;
4142
import org.apache.hadoop.hbase.regionserver.compactions.StripeCompactionPolicy;
@@ -118,6 +119,7 @@ private static HStoreFile createFile() throws Exception {
118119

119120
private static TestStoreEngine createEngine(Configuration conf) throws Exception {
120121
HStore store = mock(HStore.class);
122+
when(store.getRegionInfo()).thenReturn(HRegionInfo.FIRST_META_REGIONINFO);
121123
CellComparatorImpl kvComparator = mock(CellComparatorImpl.class);
122124
return (TestStoreEngine)StoreEngine.create(store, conf, kvComparator);
123125
}

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ public void testSingleStripeCompaction() throws Exception {
164164
conf.setInt(StripeStoreConfig.MAX_FILES_KEY, 4);
165165
conf.setLong(StripeStoreConfig.SIZE_TO_SPLIT_KEY, 1000); // make sure the are no splits
166166
StoreConfigInformation sci = mock(StoreConfigInformation.class);
167+
when(sci.getRegionInfo()).thenReturn(HRegionInfo.FIRST_META_REGIONINFO);
167168
StripeStoreConfig ssc = new StripeStoreConfig(conf, sci);
168169
StripeCompactionPolicy policy = new StripeCompactionPolicy(conf, sci, ssc) {
169170
@Override
@@ -476,6 +477,7 @@ private static StripeCompactionPolicy createPolicy(Configuration conf,
476477
conf.setInt(StripeStoreConfig.INITIAL_STRIPE_COUNT_KEY, initialCount);
477478
StoreConfigInformation sci = mock(StoreConfigInformation.class);
478479
when(sci.getStoreFileTtl()).thenReturn(hasTtl ? defaultTtl : Long.MAX_VALUE);
480+
when(sci.getRegionInfo()).thenReturn(HRegionInfo.FIRST_META_REGIONINFO);
479481
StripeStoreConfig ssc = new StripeStoreConfig(conf, sci);
480482
return new StripeCompactionPolicy(conf, sci, ssc);
481483
}

0 commit comments

Comments
 (0)