HBASE-28742 Fixes NPE for CompactionTool when mslab enabled

Author: vineet4008

hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionTool.java

@@ -211,6 +211,8 @@ public void setup(Context context) {
       } catch (IOException e) {
         throw new RuntimeException("Could not get the input FileSystem", e);
       }
+      // Disable the MemStoreLAB as MemStore is not used by flow during compaction
+      conf.setBoolean(MemStoreLAB.USEMSLAB_KEY, false);
     }
 
     @Override
@@ -369,6 +371,8 @@ private int doMapReduce(final FileSystem fs, final Set<Path> toCompactDirs,
    */
   private int doClient(final FileSystem fs, final Set<Path> toCompactDirs,
     final boolean compactOnce, final boolean major) throws IOException {
+    // Disable the MemStoreLAB as MemStore is not used by flow during compaction
+    getConf().setBoolean(MemStoreLAB.USEMSLAB_KEY, false);
     CompactionWorker worker = new CompactionWorker(fs, getConf());
     for (Path path : toCompactDirs) {
       worker.compact(path, compactOnce, major);

hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionTool.java

@@ -46,12 +46,12 @@ public class TestCompactionTool {
   public static final HBaseClassTestRule CLASS_RULE =
     HBaseClassTestRule.forClass(TestCompactionTool.class);
 
-  private final HBaseTestingUtility testUtil = new HBaseTestingUtility();
+  protected final HBaseTestingUtility testUtil = new HBaseTestingUtility();
 
-  private HRegion region;
-  private final static byte[] qualifier = Bytes.toBytes("qf");
-  private Path rootDir;
-  private final TableName tableName = TableName.valueOf(getClass().getSimpleName());
+  protected HRegion region;
+  protected final static byte[] qualifier = Bytes.toBytes("qf");
+  protected Path rootDir;
+  protected final TableName tableName = TableName.valueOf(getClass().getSimpleName());
 
   @Before
   public void setUp() throws Exception {
@@ -90,7 +90,7 @@ public void testCompactedFilesArchived() throws Exception {
     assertEquals(1, regionDirFiles.length);
   }
 
-  private void putAndFlush(int key) throws Exception {
+  protected void putAndFlush(int key) throws Exception {
     Put put = new Put(Bytes.toBytes(key));
     put.addColumn(HBaseTestingUtility.fam1, qualifier, Bytes.toBytes("val" + key));
     region.put(put);

hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionToolNpeFix.java

@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RegionServerTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.CommonFSUtils;
+import org.apache.hadoop.util.ToolRunner;
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+/**
+ * Test the issue of HBASE-28472
+ */
+@Category({ MediumTests.class, RegionServerTests.class })
+public class TestCompactionToolNpeFix extends TestCompactionTool {
+
+  @ClassRule
+  public static final HBaseClassTestRule CLASS_RULE =
+    HBaseClassTestRule.forClass(TestCompactionToolNpeFix.class);
+
+  @Before
+  public void setUp() throws Exception {
+    testUtil.getConfiguration().setBoolean(MemStoreLAB.USEMSLAB_KEY, false);
+    super.setUp();
+  }
+
+  @Test
+  public void testCompactedFilesArchivedMapRed() throws Exception {
+    for (int i = 0; i < 10; i++) {
+      this.putAndFlush(i);
+    }
+    HStore store = region.getStore(HBaseTestingUtility.fam1);
+    assertEquals(10, store.getStorefilesCount());
+    Path tableDir = CommonFSUtils.getTableDir(rootDir, region.getRegionInfo().getTable());
+    FileSystem fs = store.getFileSystem();
+    String storePath = tableDir + "/" + region.getRegionInfo().getEncodedName() + "/"
+      + Bytes.toString(HBaseTestingUtility.fam1);
+    FileStatus[] regionDirFiles = fs.listStatus(new Path(storePath));
+    assertEquals(10, regionDirFiles.length);
+    String defaultFS = testUtil.getMiniHBaseCluster().getConfiguration().get("fs.defaultFS");
+    testUtil.startMiniMapReduceCluster();
+    try {
+      Configuration config = HBaseConfiguration.create(testUtil.getConfiguration());
+      config.setBoolean(MemStoreLAB.USEMSLAB_KEY, true);
+      config.set("fs.defaultFS", defaultFS);
+      int result = ToolRunner.run(config, new CompactionTool(),
+        new String[] { "-compactOnce", "-mapred", "-major", storePath });
+      assertEquals(0, result);
+      regionDirFiles = fs.listStatus(new Path(storePath));
+      assertEquals(1, regionDirFiles.length);
+    } finally {
+      testUtil.shutdownMiniMapReduceCluster();
+    }
+  }
+}