Skip to content

Commit 2d76457

Browse files
authored
HBASE-23570 Point users to the async-profiler home page if diagrams are coming up blank (#937)
1 parent 413d4b2 commit 2d76457

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

hbase-http/src/main/java/org/apache/hadoop/hbase/http/ProfileServlet.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,10 @@ protected void doGet(final HttpServletRequest req, final HttpServletResponse res
270270
resp.getWriter().write(
271271
"Started [" + event.getInternalName() +
272272
"] profiling. This page will automatically redirect to " +
273-
relativeUrl + " after " + duration + " seconds.\n\nCommand:\n" +
273+
relativeUrl + " after " + duration + " seconds. " +
274+
"If empty diagram and Linux 4.6+, see 'Basic Usage' section on the Async " +
275+
"Profiler Home Page, https://github.com/jvm-profiling-tools/async-profiler." +
276+
"\n\nCommand:\n" +
274277
Joiner.on(" ").join(cmd));
275278

276279
// to avoid auto-refresh by ProfileOutputServlet, refreshDelay can be specified

src/main/asciidoc/_chapters/profiler.adoc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ HBASE-21926 introduced a new servlet that supports integrated profiling via asyn
3434
== Prerequisites
3535
3636
Go to https://github.com/jvm-profiling-tools/async-profiler, download a release appropriate for your platform, and install on every cluster host.
37+
If 4.6 or later linux, be sure to set proc variables as per 'Basic Usage' section in the
38+
<a href="https://github.com/jvm-profiling-tools/async-profiler">Async Profiler Home Page</a>
39+
(Not doing this will draw you diagrams with no content).
3740
3841
Set `ASYNC_PROFILER_HOME` in the environment (put it in hbase-env.sh) to the root directory of the async-profiler install location, or pass it on the HBase daemon's command line as a system property as `-Dasync.profiler.home=/path/to/async-profiler`.
3942

0 commit comments

Comments
 (0)