Fix checkstyle, javadoc, and error-prone findings from precommit

Author: apurtell

hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java

@@ -2367,8 +2367,8 @@ public static void zero(byte[] b, int offset, int length) {
    * Fill given array with random bytes.
    * @param b array which needs to be filled with random bytes
    * <p>
-   * If you want random bytes generated by a strong source of randomness use
-   * {@link Bytes#secureRandom(byte[])}.
+   * If you want random bytes generated by a strong source of randomness use {@link
+   * Bytes#secureRandom(byte[])}.
    * @param b array which needs to be filled with random bytes
    */
   public static void random(byte[] b) {
@@ -2378,8 +2378,8 @@ public static void random(byte[] b) {
   /**
    * Fill given array with random bytes at the specified position.
    * <p>
-   * If you want random bytes generated by a strong source of randomness use
-   * {@link Bytes#secureRandom(byte[], int, int).
+   * If you want random bytes generated by a strong source of randomness use {@link
+   * Bytes#secureRandom(byte[], int, int)}.
    * @param b array which needs to be filled with random bytes
    * @param offset staring offset in array
    * @param length number of bytes to fill

hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestDDLMasterFailover.java

@@ -260,7 +260,8 @@ protected NamespaceDescriptor selectNamespace(
           return null;
         }
         ArrayList<String> namespaceList = new ArrayList<>(namespaceMap.keySet());
-        String randomKey = namespaceList.get(ThreadLocalRandom.current().nextInt(namespaceList.size()));
+        String randomKey = namespaceList.get(ThreadLocalRandom.current()
+          .nextInt(namespaceList.size()));
         NamespaceDescriptor randomNsd = namespaceMap.get(randomKey);
         // remove from namespaceMap
         namespaceMap.remove(randomKey);
@@ -439,8 +440,9 @@ void perform() throws IOException {
     }
 
     private TableDescriptor createTableDesc() {
-      String tableName = String.format("ittable-%010d", ThreadLocalRandom.current().nextInt());
-      String familyName = "cf-" + Math.abs(ThreadLocalRandom.current().nextInt());
+      String tableName = String.format("ittable-%010d",
+        ThreadLocalRandom.current().nextInt(Integer.MAX_VALUE));
+      String familyName = "cf-" + ThreadLocalRandom.current().nextInt(Integer.MAX_VALUE);
       return TableDescriptorBuilder.newBuilder(TableName.valueOf(tableName))
           .setColumnFamily(ColumnFamilyDescriptorBuilder.of(familyName))
           .build();
@@ -601,7 +603,7 @@ void perform() throws IOException {
       try {
         ColumnFamilyDescriptor cfd = createFamilyDesc();
         if (selected.hasColumnFamily(cfd.getName())){
-          LOG.info(new String(cfd.getName()) + " already exists in table "
+          LOG.info(Bytes.toString(cfd.getName()) + " already exists in table "
               + selected.getTableName());
           return;
         }
@@ -799,7 +801,7 @@ void perform() throws IOException {
             return;
           }
           byte[] family = cfd.getName();
-          byte[] qualifier = Bytes.toBytes("col-" + ThreadLocalRandom.current().nextInt() % 10);
+          byte[] qualifier = Bytes.toBytes("col-" + ThreadLocalRandom.current().nextInt(10));
           Bytes.random(value);
           Put put = new Put(rowKey);
           put.addColumn(family, qualifier, value);

hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java

@@ -91,8 +91,8 @@ public static void request(Path path, Runnable runnable) {
       long delay;
       if (prefetchDelayMillis > 0) {
         delay = (long)((prefetchDelayMillis * (1.0f - (prefetchDelayVariation/2))) +
-        (prefetchDelayMillis * (prefetchDelayVariation/2) *
-            ThreadLocalRandom.current().nextFloat()));
+          (prefetchDelayMillis * (prefetchDelayVariation/2) *
+          ThreadLocalRandom.current().nextFloat()));
       } else {
         delay = 0;
       }

hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtil.java

@@ -1955,7 +1955,7 @@ public void loadRandomRows(final Table t, final byte[] f, int rowSize, int total
     throws IOException {
     for (int i = 0; i < totalRows; i++) {
       byte[] row = new byte[rowSize];
-      Bytes.random(row);;
+      Bytes.random(row);
       Put put = new Put(row);
       put.addColumn(f, new byte[] { 0 }, new byte[] { 0 });
       t.put(put);

hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTimestampsFilter.java

@@ -43,8 +43,6 @@
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 import org.junit.rules.TestName;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Run tests related to {@link TimestampsFilter} using HBase client APIs.
@@ -58,7 +56,6 @@ public class TestTimestampsFilter {
   public static final HBaseClassTestRule CLASS_RULE =
       HBaseClassTestRule.forClass(TestTimestampsFilter.class);
 
-  private static final Logger LOG = LoggerFactory.getLogger(TestTimestampsFilter.class);
   private final static HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil();
 
   @Rule

hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java

@@ -64,7 +64,6 @@
 import org.apache.hadoop.hbase.testclassification.MasterTests;
 import org.apache.hadoop.hbase.testclassification.MediumTests;
 import org.apache.hadoop.hbase.util.Bytes;
-import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
 import org.apache.hadoop.hbase.util.Pair;
 import org.apache.zookeeper.KeeperException;
 import org.junit.AfterClass;

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java

@@ -39,7 +39,6 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
-import java.util.Random;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.FSDataOutputStream;
 import org.apache.hadoop.fs.Path;

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSecureBulkloadListener.java

@@ -17,6 +17,8 @@
  */
 package org.apache.hadoop.hbase.regionserver;
 
+import java.io.IOException;
+import java.util.UUID;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.FSDataOutputStream;
 import org.apache.hadoop.fs.FileSystem;
@@ -42,8 +44,6 @@
 import org.junit.experimental.categories.Category;
 import org.junit.rules.TemporaryFolder;
 import org.junit.rules.TestName;
-import java.io.IOException;
-import java.util.UUID;
 
 /**
  * Tests for failedBulkLoad logic to make sure staged files are returned to their original location

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScannerClosure.java

@@ -30,7 +30,6 @@
 import java.util.TreeSet;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.ThreadLocalRandom;
-import java.util.concurrent.locks.ReentrantReadWriteLock;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.Path;

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java

@@ -105,7 +105,7 @@ private HStore prepareData() throws IOException {
     for (int i = 0; i < 10; i++) {
       for (int j = 0; j < 10; j++) {
         byte[] value = new byte[128 * 1024];
-        Bytes.random(value);;
+        Bytes.random(value);
         table.put(new Put(Bytes.toBytes(i * 10 + j)).addColumn(family, qualifier, value));
       }
       admin.flush(tableName);