Skip to content

HDDS-1668. Add liveness probe to the example k8s resources files #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

elek
Copy link
Member

@elek elek commented Jun 11, 2019

In kubernetes resources we can define livebess probes which can help to detect any failure. If the define port is not available the pod will be rescheduled.

We need to add the liveness probes to our k8s resource files.

Note: We shouldn't add readiness probes. Readiness probe is about the service availability. The service/dns can be available only after the service is restarted. This is not good for us as:

  • We need DNS resolution during the startup (See OzoneManager.loadOMHAConfigs)
  • We already implemented retry in case of missing DNS entries

See: https://issues.apache.org/jira/browse/HDDS-1668

@elek elek added the ozone label Jun 11, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 50 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
0 yamllint 0 yamllint was not available.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 515 trunk passed
+1 compile 284 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1654 branch has no errors when building and testing our client artifacts.
+1 javadoc 167 trunk passed
_ Patch Compile Tests _
+1 mvninstall 467 the patch passed
+1 compile 294 the patch passed
+1 javac 294 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 744 patch has no errors when building and testing our client artifacts.
+1 javadoc 169 the patch passed
_ Other Tests _
-1 unit 157 hadoop-hdds in the patch failed.
-1 unit 1247 hadoop-ozone in the patch failed.
+1 asflicense 51 The patch does not generate ASF License warnings.
5205
Reason Tests
Failed junit tests hadoop.ozone.container.common.impl.TestHddsDispatcher
hadoop.ozone.client.rpc.TestBCSID
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-944/1/artifact/out/Dockerfile
GITHUB PR #944
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient yamllint
uname Linux 4fa34080de55 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / b417a4c
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-944/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-944/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-944/1/testReport/
Max. process+thread count 4471 (vs. ulimit of 5500)
modules C: hadoop-ozone/dist U: hadoop-ozone/dist
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-944/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 79 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
0 yamllint 0 yamllint was not available.
0 shelldocs 1 Shelldocs was not available.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 605 trunk passed
+1 compile 351 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1065 branch has no errors when building and testing our client artifacts.
+1 javadoc 229 trunk passed
_ Patch Compile Tests _
+1 mvninstall 564 the patch passed
+1 compile 339 the patch passed
+1 javac 339 the patch passed
+1 mvnsite 0 the patch passed
+1 shellcheck 0 There were no new shellcheck issues.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 872 patch has no errors when building and testing our client artifacts.
+1 javadoc 213 the patch passed
_ Other Tests _
+1 unit 370 hadoop-hdds in the patch passed.
-1 unit 2930 hadoop-ozone in the patch failed.
+1 asflicense 65 The patch does not generate ASF License warnings.
7949
Reason Tests
Failed junit tests hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
hadoop.hdds.scm.pipeline.TestNodeFailure
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestBCSID
hadoop.hdds.scm.pipeline.TestPipelineClose
hadoop.ozone.TestMiniOzoneCluster
hadoop.ozone.client.rpc.TestCommitWatcher
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
hadoop.ozone.client.rpc.TestReadRetries
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-944/2/artifact/out/Dockerfile
GITHUB PR #944
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient yamllint shellcheck shelldocs
uname Linux b7588a8abeaa 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 2f4b37b
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-944/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-944/2/testReport/
Max. process+thread count 3740 (vs. ulimit of 5500)
modules C: hadoop-ozone/dist U: hadoop-ozone/dist
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-944/2/console
versions git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@anuengineer anuengineer merged commit 1411513 into apache:trunk Jul 15, 2019
asfgit pushed a commit that referenced this pull request Jul 15, 2019
HDDS-1668. Add liveness probe to the example k8s resources files

(cherry picked from commit 1411513)
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants