Skip to content

HDDS-1541. Implement addAcl,removeAcl,setAcl,getAcl for Key. Contributed by Ajay Kumat. #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2019

Conversation

ajayydv
Copy link
Contributor

@ajayydv ajayydv commented Jun 1, 2019

No description provided.

@ajayydv ajayydv requested a review from xiaoyuyao June 1, 2019 02:45
@ajayydv ajayydv self-assigned this Jun 1, 2019
@ajayydv ajayydv added the ozone label Jun 1, 2019
0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

0x00007f80c5548800 JavaThread "pool-151-thread-40" [_thread_blocked, id=438531, stack(0x000070003f2d8000,0x000070003f3d8000)]
0x00007f80c5547800 JavaThread "pool-151-thread-39" [_thread_blocked, id=478979, stack(0x000070003f1d5000,0x000070003f2d5000)]
0x00007f80c5547000 JavaThread "pool-151-thread-38" [_thread_blocked, id=438019, stack(0x000070003f0d2000,0x000070003f1d2000)]
0x00007f80c7c06800 JavaThread "pool-151-th

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 81 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 42 Maven dependency ordering for branch
+1 mvninstall 556 trunk passed
+1 compile 301 trunk passed
+1 checkstyle 88 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 885 branch has no errors when building and testing our client artifacts.
+1 javadoc 181 trunk passed
0 spotbugs 329 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 520 trunk passed
_ Patch Compile Tests _
0 mvndep 27 Maven dependency ordering for patch
+1 mvninstall 503 the patch passed
+1 compile 308 the patch passed
+1 cc 308 the patch passed
+1 javac 308 the patch passed
-0 checkstyle 49 hadoop-ozone: The patch generated 11 new + 0 unchanged - 0 fixed = 11 total (was 0)
+1 mvnsite 0 the patch passed
-1 whitespace 0 The patch has 7 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 whitespace 0 The patch 460 line(s) with tabs.
+1 shadedclient 679 patch has no errors when building and testing our client artifacts.
+1 javadoc 181 the patch passed
+1 findbugs 535 the patch passed
_ Other Tests _
-1 unit 281 hadoop-hdds in the patch failed.
-1 unit 57 hadoop-ozone in the patch failed.
+1 asflicense 49 The patch does not generate ASF License warnings.
5692
Reason Tests
Failed junit tests hadoop.hdds.scm.block.TestBlockManager
hadoop.ozone.om.helpers.TestOmKeyInfo
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/artifact/out/Dockerfile
GITHUB PR #885
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname Linux 27bf8a3f3475 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 2210897
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
whitespace https://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/artifact/out/whitespace-eol.txt
whitespace https://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/artifact/out/whitespace-tabs.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/testReport/
Max. process+thread count 495 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

listOfAcls.add(new OzoneAcl(ACLIdentityType.USER,
ugi.getUserName(), userRights));
//Group ACLs of the User
List<String> userGroups = Arrays.asList(UserGroupInformation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to recreate a new UGI instead of using ugi.getGroups() here?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 954 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 6 new or modified test files.
_ trunk Compile Tests _
0 mvndep 129 Maven dependency ordering for branch
+1 mvninstall 577 trunk passed
+1 compile 276 trunk passed
+1 checkstyle 78 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1030 branch has no errors when building and testing our client artifacts.
+1 javadoc 184 trunk passed
0 spotbugs 390 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 614 trunk passed
_ Patch Compile Tests _
0 mvndep 20 Maven dependency ordering for patch
+1 mvninstall 512 the patch passed
+1 compile 289 the patch passed
+1 cc 289 the patch passed
+1 javac 289 the patch passed
+1 checkstyle 86 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 723 patch has no errors when building and testing our client artifacts.
+1 javadoc 175 the patch passed
+1 findbugs 655 the patch passed
_ Other Tests _
+1 unit 358 hadoop-hdds in the patch passed.
-1 unit 214 hadoop-ozone in the patch failed.
+1 asflicense 54 The patch does not generate ASF License warnings.
7122
Reason Tests
Failed junit tests hadoop.ozone.om.TestKeyDeletingService
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-885/4/artifact/out/Dockerfile
GITHUB PR #885
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname Linux 5dc0efbfcb6e 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 277e9a8
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-885/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-885/4/testReport/
Max. process+thread count 1228 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-885/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@@ -79,7 +79,8 @@ public BlockOutputStreamEntryPool(OzoneManagerProtocol omClient,
.setBucketName(info.getBucketName()).setKeyName(info.getKeyName())
.setType(type).setFactor(factor).setDataSize(info.getDataSize())
.setIsMultipartKey(isMultipart).setMultipartUploadID(uploadID)
.setMultipartUploadPartNumber(partNumber).build();
.setMultipartUploadPartNumber(partNumber)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: unnecessary change can be avoided.

bits.and(aclRights);

if (bits.equals(ZERO_BITSET)) {
// throw exception if acl is already added.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments does not match with code.

aclRights.xor(acl.getAclBitSet());
if (aclRights.equals(ZERO_BITSET)) {
getMap(aclType).remove(acl.getName());
}
} else {
// throw exception if acl is already added.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be acl does not exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point all rights are already set to 0, so we are removing the entry from map.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ajayydv for the patch. LGTM overall, a few comments added inline...

@xiaoyuyao
Copy link
Contributor

Also, CI test failures in TestKeyDeletingService are related. Please fix them in next update.

java.lang.NullPointerException: Default acls should be set.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 117 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 6 new or modified test files.
_ trunk Compile Tests _
0 mvndep 19 Maven dependency ordering for branch
+1 mvninstall 661 trunk passed
+1 compile 357 trunk passed
+1 checkstyle 100 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1135 branch has no errors when building and testing our client artifacts.
+1 javadoc 216 trunk passed
0 spotbugs 404 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 641 trunk passed
_ Patch Compile Tests _
0 mvndep 27 Maven dependency ordering for patch
+1 mvninstall 608 the patch passed
+1 compile 349 the patch passed
+1 cc 349 the patch passed
+1 javac 349 the patch passed
+1 checkstyle 121 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 848 patch has no errors when building and testing our client artifacts.
+1 javadoc 205 the patch passed
+1 findbugs 720 the patch passed
_ Other Tests _
+1 unit 291 hadoop-hdds in the patch passed.
-1 unit 171 hadoop-ozone in the patch failed.
+1 asflicense 42 The patch does not generate ASF License warnings.
6864
Reason Tests
Failed junit tests hadoop.ozone.om.TestKeyDeletingService
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-885/5/artifact/out/Dockerfile
GITHUB PR #885
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname Linux 2ca7b4d927de 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 580b639
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-885/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-885/5/testReport/
Max. process+thread count 1178 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-885/5/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 52 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 7 new or modified test files.
_ trunk Compile Tests _
0 mvndep 46 Maven dependency ordering for branch
+1 mvninstall 553 trunk passed
+1 compile 297 trunk passed
+1 checkstyle 83 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 912 branch has no errors when building and testing our client artifacts.
+1 javadoc 177 trunk passed
0 spotbugs 366 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 578 trunk passed
_ Patch Compile Tests _
0 mvndep 20 Maven dependency ordering for patch
+1 mvninstall 507 the patch passed
+1 compile 307 the patch passed
+1 cc 307 the patch passed
+1 javac 307 the patch passed
+1 checkstyle 85 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 729 patch has no errors when building and testing our client artifacts.
+1 javadoc 181 the patch passed
+1 findbugs 594 the patch passed
_ Other Tests _
-1 unit 185 hadoop-hdds in the patch failed.
-1 unit 1559 hadoop-ozone in the patch failed.
+1 asflicense 66 The patch does not generate ASF License warnings.
7119
Reason Tests
Failed junit tests hadoop.ozone.container.ozoneimpl.TestOzoneContainer
hadoop.ozone.om.TestOmMetrics
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.TestMiniOzoneCluster
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-885/6/artifact/out/Dockerfile
GITHUB PR #885
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname Linux 45aa29b5598d 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 580b639
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-885/6/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-885/6/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-885/6/testReport/
Max. process+thread count 4615 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-885/6/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 29 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 7 new or modified test files.
_ trunk Compile Tests _
0 mvndep 15 Maven dependency ordering for branch
+1 mvninstall 605 trunk passed
+1 compile 321 trunk passed
+1 checkstyle 84 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 977 branch has no errors when building and testing our client artifacts.
+1 javadoc 182 trunk passed
0 spotbugs 415 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 648 trunk passed
_ Patch Compile Tests _
0 mvndep 34 Maven dependency ordering for patch
+1 mvninstall 483 the patch passed
+1 compile 290 the patch passed
+1 cc 290 the patch passed
+1 javac 290 the patch passed
+1 checkstyle 84 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 717 patch has no errors when building and testing our client artifacts.
+1 javadoc 163 the patch passed
+1 findbugs 559 the patch passed
_ Other Tests _
+1 unit 238 hadoop-hdds in the patch passed.
-1 unit 1259 hadoop-ozone in the patch failed.
+1 asflicense 47 The patch does not generate ASF License warnings.
6925
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.om.TestOmBlockVersioning
hadoop.ozone.om.TestOzoneManager
hadoop.ozone.om.TestOmAcls
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.om.TestMultipleContainerReadWrite
hadoop.ozone.client.rpc.TestWatchForCommit
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.TestStorageContainerManager
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.om.TestScmSafeMode
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-885/8/artifact/out/Dockerfile
GITHUB PR #885
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname Linux b4b57e1ee059 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 1a78794
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-885/8/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-885/8/testReport/
Max. process+thread count 4364 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-885/8/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, Pending CI.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 73 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 7 new or modified test files.
_ trunk Compile Tests _
0 mvndep 12 Maven dependency ordering for branch
+1 mvninstall 564 trunk passed
+1 compile 298 trunk passed
+1 checkstyle 93 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 897 branch has no errors when building and testing our client artifacts.
+1 javadoc 181 trunk passed
0 spotbugs 335 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 527 trunk passed
_ Patch Compile Tests _
0 mvndep 28 Maven dependency ordering for patch
+1 mvninstall 498 the patch passed
+1 compile 313 the patch passed
+1 cc 313 the patch passed
+1 javac 313 the patch passed
+1 checkstyle 99 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 683 patch has no errors when building and testing our client artifacts.
+1 javadoc 179 the patch passed
+1 findbugs 539 the patch passed
_ Other Tests _
+1 unit 290 hadoop-hdds in the patch passed.
-1 unit 1511 hadoop-ozone in the patch failed.
+1 asflicense 46 The patch does not generate ASF License warnings.
7031
Reason Tests
Failed junit tests hadoop.ozone.scm.node.TestSCMNodeMetrics
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-885/9/artifact/out/Dockerfile
GITHUB PR #885
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname Linux 8586a60de279 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 0b1e288
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-885/9/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-885/9/testReport/
Max. process+thread count 4369 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-885/9/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@ajayydv
Copy link
Contributor Author

ajayydv commented Jun 5, 2019

Both test failures pass locally, seems unrelated.

@xiaoyuyao xiaoyuyao merged commit 3b1c257 into apache:trunk Jun 5, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
This checkin adds
1. Type system for Samza SQL. Previously Samza SQL was using Calcite's relational type system. We need an intermediate type system that is specific to Samza SQL so that we could support Beam SQL in future. This intermediate type system also allows to provide typing to Samza SQL UDFs.
2. Java annotations for Samza SQL that allows us to discover the Samza SQL UDFs easily and also provide users to configure name of the UDF, whether it is disabled.
3. Initial support for adding types in Samza SQL UDFs. Right now we are not using these types for validations. Future checkin will add that capability.

Author: Srinivasulu Punuru <spunuru@linkedin.com>

Reviewers: Weiqing <wiyang@linkedin.com>, Shenoda <sguirgui@linkedin.com>

Closes apache#885 from srinipunuru/sql-schema.2 and squashes the following commits:

61e03b9a [Srinivasulu Punuru] Removing Metadata from SamzaSQLRelMessage
f713cae5 [Srinivasulu Punuru] Address review comments
60d2614a [Srinivasulu Punuru] Adding license and documentation
a3af257 [Srinivasulu Punuru] Support for types in UDFS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants