Skip to content

HADOOP-16319 skip invalid tests when default encryption enabled #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ben-roling
Copy link
Contributor

ETag values are unpredictable with some encryption algorithms. Skip tests asserting ETags when default encryption is enabled.

ETag values are unpredictable with some encryption algorithms. Skip
tests asserting ETags when default encryption is enabled.
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 507 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1067 trunk passed
+1 compile 34 trunk passed
+1 checkstyle 24 trunk passed
+1 mvnsite 39 trunk passed
+1 shadedclient 692 branch has no errors when building and testing our client artifacts.
+1 javadoc 27 trunk passed
0 spotbugs 59 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 58 trunk passed
_ Patch Compile Tests _
+1 mvninstall 31 the patch passed
+1 compile 31 the patch passed
+1 javac 31 the patch passed
+1 checkstyle 17 the patch passed
+1 mvnsite 33 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 752 patch has no errors when building and testing our client artifacts.
+1 javadoc 20 the patch passed
+1 findbugs 61 the patch passed
_ Other Tests _
+1 unit 266 hadoop-aws in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
3782
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-836/1/artifact/out/Dockerfile
GITHUB PR #836
Optional Tests dupname asflicense mvnsite compile javac javadoc mvninstall unit shadedclient findbugs checkstyle
uname Linux 07b98714516a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 24c53e0
Default Java 1.8.0_212
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-836/1/testReport/
Max. process+thread count 411 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-836/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@ben-roling
Copy link
Contributor Author

With regard to testing: I've only run this one test class before and after the change. It is successfully skipping the tests that were previously failing when default encryption was enabled on the bucket. I did not run the full suite since there were no changes that could affect other test classes.

My tests were performed against us-west-2.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Author: Aditya Toomula <atoomula@linkedin.com>

Reviewers: vjagadish1989

Closes apache#836 from atoomula/new
@apache apache deleted a comment from hadoop-yetus Feb 14, 2020
@apache apache deleted a comment from hadoop-yetus Feb 14, 2020
@apache apache deleted a comment from hadoop-yetus Feb 14, 2020
@apache apache deleted a comment from hadoop-yetus Feb 14, 2020
@apache apache deleted a comment from hadoop-yetus Feb 14, 2020
@apache apache deleted a comment from hadoop-yetus Feb 14, 2020
@apache apache deleted a comment from hadoop-yetus Feb 14, 2020
@apache apache deleted a comment from hadoop-yetus Feb 14, 2020
@apache apache deleted a comment from hadoop-yetus Feb 14, 2020
@apache apache deleted a comment from hadoop-yetus Feb 14, 2020
@steveloughran
Copy link
Contributor

we need to get this in, don't we?

steveloughran added a commit to steveloughran/hadoop that referenced this pull request Mar 16, 2020
Thiis ben roling's patch apache#836 as applied to trunk

Change-Id: I36a308f30a46bdc11bb867217c966d0632b24286
@steveloughran
Copy link
Contributor

merged to trunk. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants