HADOOP-19359. Accelerate token negotiation for other similar mechanisms. #7983
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
HADOOP-19227 has words
Why can this be extended to other mechanisms now? |
It is only for mechanisms similar to DIGEST-MD5. For other mechanisms, it can't. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
jojochuang
reviewed
Oct 9, 2025
| // in the negotiation response | ||
| if (enabledAuthMethods.contains(AuthMethod.TOKEN) | ||
| && SaslMechanismFactory.isDefaultMechanism(AuthMethod.TOKEN.getMechanismName())) { | ||
| && SaslMechanismFactory.isDigestMechanism(AuthMethod.TOKEN.getMechanismName())) { |
There was a problem hiding this comment.
inside of matching just DIGEST-MD5, match any mechanisms starting with DIGEST-*
What mechanisms do we have in mind? I am only aware of DIGEST-MD5. Others may be possible but not standardized.
There was a problem hiding this comment.
DIGEST-MD5 uses MD5 and some other old algorithms. We are working with a new DIGEST based mechanism for replacing the old algorithms.
| } | ||
|
|
||
| public static boolean isDigestMechanism(String saslMechanism) { | ||
| return saslMechanism.startsWith("DIGEST-"); |
There was a problem hiding this comment.
maybe consider using hadoop.security.sasl.mechanism to ensure the value is expected?
<property>
<name>hadoop.security.sasl.mechanism</name>
<value>DIGEST-MD5</value>
<description>
The SASL mechanism used in Hadoop.
</description>
</property>
There was a problem hiding this comment.
In some cases, conf objects are unavailable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
HADOOP-19359
HADOOP-19227 changed ipc.Server to accelerate token negotiation only for the default mechanism.
In this JIRA, we change to support other similar mechanisms.
The previous pull request #7213 turned stale. Submitting this one with last trunk.
How was this patch tested?
Tested it manually.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?