HADOOP-19659. Upgrade Debian 10 to 11 in build env Dockerfile #7898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
commented
Aug 26, 2025
| RUN useradd -g ${GROUP_ID} -u ${USER_ID} -k /root -m ${USER_NAME} -d "${DOCKER_HOME_DIR}" | ||
| RUN echo "${USER_NAME} ALL=NOPASSWD: ALL" > "/etc/sudoers.d/hadoop-build-${USER_ID}" | ||
| ENV HOME "${DOCKER_HOME_DIR}" | ||
| ENV HOME="${DOCKER_HOME_DIR}" |
Member
Author
There was a problem hiding this comment.
update because
1 warning found (use docker --debug to expand):
- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 7)
Contributor
|
LGTM. |
slfan1989
approved these changes
Aug 26, 2025
|
💔 -1 overall
This message was automatically generated. |
slfan1989
requested changes
Aug 26, 2025
Contributor
slfan1989
left a comment
slfan1989
left a comment
There was a problem hiding this comment.
We need to solve the compilation error issue.
Member
Author
The building error occurs on CentOS 8 stage, looks like I need to fix it first |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
4 tasks
Contributor
|
I think it would be useful to run at least the native (C code) tests. |
|
💔 -1 overall
This message was automatically generated. |
slfan1989
approved these changes
Aug 29, 2025
slfan1989
reviewed
Aug 29, 2025
| @Override | ||
| protected CommandExecutor.Result execute(CLICommand cmd) throws Exception { | ||
| return cmd.getExecutor("", conf).executeCommand(cmd.getCmd()); | ||
|
|
Contributor
There was a problem hiding this comment.
The changes in Debian are as expected, and we can roll back the modifications to this unit as they are unrelated to our main changes.
Member
Author
|
@slfan1989, unnecessary changes are reverted, should be good to go |
Contributor
@pan3793 Thank you for your contribution, LGTM. I will merge this PR soon. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
@pan3793 Thanks for the contribution! Merged into trunk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
HADOOP-19659. Upgrade Debian 10 to 11 in build env Dockerfile.
Debian 10 EOL, and the apt repo is unavailable, this PR upgrades it to Debian 11
Debian 11 will be EOL after 31 Aug 2026. I didn't switch it to Debian 12 or 13 because the new version does not have
openjdk-11-jdkin the apt repo.How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?