Skip to content

HADOOP-19560. Update build instructions for Windows #7673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025

Conversation

GauthamBanasandra
Copy link
Member

Description of PR

How was this patch tested?

Jenkins CI validation.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

* We recently upgraded vcpkg to install
  Boost 1.86.
* This PR updates the build documentation
  for the same.
@github-actions github-actions bot added the trunk label May 4, 2025
@GauthamBanasandra GauthamBanasandra requested review from Copilot and goiri May 4, 2025 05:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Windows build instructions to reflect the recent upgrade of Boost to version 1.86 via vcpkg.

  • Removed outdated instructions that referred to a specific commit hash
  • Added new commands to fetch and checkout a vcpkg version tag ("2025.03.19") and updated dependency setup steps
Comments suppressed due to low confidence (1)

BUILDING.txt:601

  • Please verify that '2025.03.19' is the correct version or tag required by Boost 1.86 and update the documentation if needed to avoid potential confusion.
git checkout 2025.03.19

@GauthamBanasandra GauthamBanasandra self-assigned this May 4, 2025
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 37m 15s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 33m 38s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
73m 42s
Subsystem Report/Notes
Docker ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7673/1/artifact/out/Dockerfile
GITHUB PR #7673
Optional Tests dupname asflicense codespell detsecrets
uname Linux 15bb8d6521d4 5.15.0-136-generic #147-Ubuntu SMP Sat Mar 15 15:53:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 90268e0
Max. process+thread count 671 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7673/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor

@GauthamBanasandra LGTM.

@GauthamBanasandra GauthamBanasandra merged commit e103142 into apache:trunk May 4, 2025
4 checks passed
@GauthamBanasandra GauthamBanasandra deleted the fix-doc branch May 4, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants