HDFS-16547. [SBN read] Namenode in safe mode should not be transfer to observer state. #7577

adityarverma · 2025-04-03T11:28:21Z

…o observer state (#4201)

Signed-off-by: Erik Krogen xkrogen@apache.org
Reviewed-by: Zengqiang Xu xuzq_zander@163.com
(cherry picked from commit 8f971b0)

Description of PR

Backports a feature to "block transition of namenode to observer state if it is standby", back to branch-3.3 from trunk.

How was this patch tested?

unit tests and build passing

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2025-04-03T15:41:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	3m 47s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+0 🆗	markdownlint	0m 1s		markdownlint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ branch-3.3 Compile Tests _
+1 💚	mvninstall	32m 26s		branch-3.3 passed
+1 💚	compile	0m 48s		branch-3.3 passed
+1 💚	checkstyle	0m 32s		branch-3.3 passed
+1 💚	mvnsite	0m 53s		branch-3.3 passed
+1 💚	javadoc	1m 5s		branch-3.3 passed
+1 💚	spotbugs	1m 47s		branch-3.3 passed
+1 💚	shadedclient	21m 16s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 40s		the patch passed
+1 💚	compile	0m 40s		the patch passed
+1 💚	javac	0m 40s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 22s		the patch passed
+1 💚	mvnsite	0m 44s		the patch passed
+1 💚	javadoc	0m 57s		the patch passed
+1 💚	spotbugs	1m 38s		the patch passed
+1 💚	shadedclient	20m 30s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	164m 48s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 30s		The patch does not generate ASF License warnings.
		252m 46s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.TestLargeBlockReport
	hadoop.hdfs.TestReconstructStripedFileWithValidator
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.protocol.TestBlockListAsLongs
	hadoop.hdfs.TestFileCreation

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7577/1/artifact/out/Dockerfile
GITHUB PR	#7577
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint markdownlint
uname	Linux 1278fca175dc 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `74b7ca6`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7577/1/testReport/
Max. process+thread count	4919 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7577/1/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hexiaoqiao · 2025-04-07T13:20:04Z

Thanks @adityarverma . Is the same as #7321, please close one of them, let's keep following up at single one PR. Thanks again.

adityarverma · 2025-04-10T13:47:22Z

Thanks @adityarverma . Is the same as #7321, please close one of them, let's keep following up at single one PR. Thanks again.

Thanks @Hexiaoqiao closed the other PR.

…o observer state (apache#4201) Signed-off-by: Erik Krogen <xkrogen@apache.org> Reviewed-by: Zengqiang Xu <xuzq_zander@163.com> (cherry picked from commit 8f971b0)

hadoop-yetus · 2025-04-24T21:46:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	6m 6s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	markdownlint	0m 0s		markdownlint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ branch-3.3 Compile Tests _
+1 💚	mvninstall	45m 13s		branch-3.3 passed
+1 💚	compile	1m 14s		branch-3.3 passed
+1 💚	checkstyle	0m 51s		branch-3.3 passed
+1 💚	mvnsite	1m 24s		branch-3.3 passed
+1 💚	javadoc	1m 35s		branch-3.3 passed
+1 💚	spotbugs	3m 10s		branch-3.3 passed
+1 💚	shadedclient	35m 34s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 12s		the patch passed
+1 💚	compile	1m 6s		the patch passed
+1 💚	javac	1m 6s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 40s		the patch passed
+1 💚	mvnsite	1m 12s		the patch passed
+1 💚	javadoc	1m 23s		the patch passed
+1 💚	spotbugs	3m 11s		the patch passed
+1 💚	shadedclient	35m 7s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	195m 4s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 44s		The patch does not generate ASF License warnings.
		332m 39s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
	hadoop.hdfs.server.datanode.TestLargeBlockReport
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
	hadoop.hdfs.protocol.TestBlockListAsLongs

Subsystem	Report/Notes
Docker	ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7577/2/artifact/out/Dockerfile
GITHUB PR	#7577
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint markdownlint
uname	Linux 79e962c74d48 5.15.0-134-generic #145-Ubuntu SMP Wed Feb 12 20:08:39 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `178fc3c`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7577/2/testReport/
Max. process+thread count	3366 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7577/2/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

adityarverma · 2025-04-25T10:01:03Z

The unit tests seems unrelated to PR, different set of tests failed, in 2 runs.
Unit tests added in the backport change passed.

1st run-
[INFO] Results:
[ERROR] Failures: 
[ERROR]   TestFileCreation.testFsCloseAfterClusterShutdown:1192 Test resulted in an unexpected exit
[ERROR]   TestFileCreation.testServerDefaultsWithMinimalCaching:280 expected:<402653184> but was:<268435456>
[ERROR]   TestReconstructStripedFileWithValidator.testValidatorWithBadDecoding:86->TestReconstructStripedFile.assertFileBlocksReconstruction:430 arrays first differed at element [0]; expected:<1> but was:<2>
[ERROR] Errors: 
[ERROR]   TestBlockListAsLongs.testFuzz:139->checkReport:156 Â» NoSuchMethod java.nio.Byt...
[ERROR]   TestLargeBlockReport.testBlockReportSucceedsWithLargerLengthLimit:100 Â» Remote
[ERROR]   TestExternalStoragePolicySatisfier.testMoveWithBlockPinning:851 Â» Timeout Time...
[INFO] 
[ERROR] Tests run: 6878, Failures: 3, Errors: 3, Skipped: 24

Latest run-
[INFO] Results:
[ERROR] Failures: 
[ERROR]   TestDataNodeRollingUpgrade.testDatanodeRollingUpgradeWithFinalize:218->rollingUpgradeAndFinalize:256->deleteAndEnsureInTrash:146
[ERROR] Errors: 
[ERROR]   TestBlockListAsLongs.testFuzz:139->checkReport:156 Â» NoSuchMethod java.nio.Byt...
[ERROR]   TestBalancerWithHANameNodes.testBalancerWithObserverWithFailedNode:230->testBalancerWithObserver:273->Object.wait:-2 Â» TestTimedOut
[ERROR]   TestLargeBlockReport.testBlockReportSucceedsWithLargerLengthLimit:100 Â» Remote
[ERROR]   TestExternalStoragePolicySatisfier.testSPSWhenFileHasExcessRedundancyBlocks:1273 Â» Timeout
[INFO] 
[ERROR] Tests run: 6891, Failures: 1, Errors: 4, Skipped: 25

adityarverma · 2025-04-25T10:02:15Z

@Hexiaoqiao can you continue review. Is it good to merge?

adityarverma marked this pull request as ready for review April 3, 2025 11:28

Hexiaoqiao changed the title ~~HDFS-16547. [SBN read] Namenode in safe mode should not be transfer t…~~ HDFS-16547. [SBN read] Namenode in safe mode should not be transfer to observer state. Apr 7, 2025

adityarverma mentioned this pull request Apr 10, 2025

HDFS-17763: Backport HDFS-16547 feature to block observer transition if namenode is in safemode #7321

Closed

HDFS-16547. [SBN read] Namenode in safe mode should not be transfer t…

178fc3c

…o observer state (apache#4201) Signed-off-by: Erik Krogen <xkrogen@apache.org> Reviewed-by: Zengqiang Xu <xuzq_zander@163.com> (cherry picked from commit 8f971b0)

adityarverma force-pushed the backport-hdfs16547 branch from 74b7ca6 to 178fc3c Compare April 24, 2025 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-16547. [SBN read] Namenode in safe mode should not be transfer to observer state. #7577

HDFS-16547. [SBN read] Namenode in safe mode should not be transfer to observer state. #7577

Uh oh!

adityarverma commented Apr 3, 2025

Uh oh!

hadoop-yetus commented Apr 3, 2025

Uh oh!

Hexiaoqiao commented Apr 7, 2025

Uh oh!

adityarverma commented Apr 10, 2025

Uh oh!

hadoop-yetus commented Apr 24, 2025

Uh oh!

adityarverma commented Apr 25, 2025

Uh oh!

adityarverma commented Apr 25, 2025

Uh oh!

Uh oh!

HDFS-16547. [SBN read] Namenode in safe mode should not be transfer to observer state. #7577

Are you sure you want to change the base?

HDFS-16547. [SBN read] Namenode in safe mode should not be transfer to observer state. #7577

Uh oh!

Conversation

adityarverma commented Apr 3, 2025

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Apr 3, 2025

Uh oh!

Hexiaoqiao commented Apr 7, 2025

Uh oh!

adityarverma commented Apr 10, 2025

Uh oh!

hadoop-yetus commented Apr 24, 2025

Uh oh!

adityarverma commented Apr 25, 2025

Uh oh!

adityarverma commented Apr 25, 2025

Uh oh!

Uh oh!