Skip to content

HADOOP-19297. [JDK17] Upgrade maven.plugin-tools.version to 3.10.2 #7125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

myandpr
Copy link
Contributor

@myandpr myandpr commented Oct 18, 2024

Description of PR

JIRA: HADOOP-19297. [JDK17] Upgrade maven.plugin-tools.version to 3.10.2

We will upgrade maven.plugin-tools.version to 3.10.2

How was this patch tested?

  • Platform
Mac with M2(arm64)
  • compilation command
mvn clean package -Pdist -Dtar -DskipTests -Dmaven.javadoc.skip=false -Djavac.version=17
  • Maven Version
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /Users/myandpr/software/apache-maven-3.6.3
Java version: 17.0.10, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home
Default locale: zh_CN_#Hans, platform encoding: UTF-8
OS name: "mac os x", version: "15.0", arch: "aarch64", family: "mac"
  • JDK Version
java version "17.0.10" 2024-01-16 LTS
Java(TM) SE Runtime Environment (build 17.0.10+11-LTS-240)
Java HotSpot(TM) 64-Bit Server VM (build 17.0.10+11-LTS-240, mixed mode, sharing)
  • Result
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Hadoop Main 3.5.0-SNAPSHOT:
[INFO] 
[INFO] Apache Hadoop Main ................................. SUCCESS [  0.676 s]
[INFO] Apache Hadoop Build Tools .......................... SUCCESS [  0.448 s]
[INFO] Apache Hadoop Project POM .......................... SUCCESS [  0.567 s]
[INFO] Apache Hadoop Annotations .......................... SUCCESS [  0.947 s]
[INFO] Apache Hadoop Assemblies ........................... SUCCESS [  0.074 s]
[INFO] Apache Hadoop Project Dist POM ..................... SUCCESS [  0.828 s]
[INFO] Apache Hadoop Maven Plugins ........................ SUCCESS [  1.982 s]
[INFO] Apache Hadoop MiniKDC .............................. SUCCESS [  0.844 s]
[INFO] Apache Hadoop Auth ................................. SUCCESS [  2.817 s]
[INFO] Apache Hadoop Auth Examples ........................ SUCCESS [  0.775 s]
[INFO] Apache Hadoop Common ............................... SUCCESS [ 24.632 s]
[INFO] Apache Hadoop NFS .................................. SUCCESS [  2.753 s]
[INFO] Apache Hadoop KMS .................................. SUCCESS [  2.538 s]
[INFO] Apache Hadoop Registry ............................. SUCCESS [  3.002 s]
[INFO] Apache Hadoop Common Project ....................... SUCCESS [  0.021 s]
[INFO] Apache Hadoop HDFS Client .......................... SUCCESS [ 13.922 s]
[INFO] Apache Hadoop HDFS ................................. SUCCESS [ 25.116 s]
[INFO] Apache Hadoop HDFS Native Client ................... SUCCESS [  1.884 s]
[INFO] Apache Hadoop HttpFS ............................... SUCCESS [  3.610 s]
[INFO] Apache Hadoop HDFS-NFS ............................. SUCCESS [  2.491 s]
[INFO] Apache Hadoop YARN ................................. SUCCESS [  0.028 s]
[INFO] Apache Hadoop YARN API ............................. SUCCESS [  9.563 s]
[INFO] Apache Hadoop YARN Common .......................... SUCCESS [ 11.133 s]
[INFO] Apache Hadoop YARN Server .......................... SUCCESS [  0.029 s]
[INFO] Apache Hadoop YARN Server Common ................... SUCCESS [  7.570 s]
[INFO] Apache Hadoop YARN ApplicationHistoryService ....... SUCCESS [  4.092 s]
[INFO] Apache Hadoop YARN Timeline Service ................ SUCCESS [  2.938 s]
[INFO] Apache Hadoop YARN Web Proxy ....................... SUCCESS [  2.629 s]
[INFO] Apache Hadoop YARN ResourceManager ................. SUCCESS [ 14.718 s]
[INFO] Apache Hadoop YARN NodeManager ..................... SUCCESS [  8.824 s]
[INFO] Apache Hadoop YARN Server Tests .................... SUCCESS [  2.415 s]
[INFO] Apache Hadoop YARN Client .......................... SUCCESS [  4.793 s]
[INFO] Apache Hadoop MapReduce Client ..................... SUCCESS [  1.204 s]
[INFO] Apache Hadoop MapReduce Core ....................... SUCCESS [  4.096 s]
[INFO] Apache Hadoop MapReduce Common ..................... SUCCESS [  9.920 s]
[INFO] Apache Hadoop MapReduce Shuffle .................... SUCCESS [  4.275 s]
[INFO] Apache Hadoop MapReduce App ........................ SUCCESS [  5.064 s]
[INFO] Apache Hadoop MapReduce HistoryServer .............. SUCCESS [  3.617 s]
[INFO] Apache Hadoop MapReduce JobClient .................. SUCCESS [  4.192 s]
[INFO] Apache Hadoop Distributed Copy ..................... SUCCESS [  3.765 s]
[INFO] Apache Hadoop Mini-Cluster ......................... SUCCESS [  1.870 s]
[INFO] Apache Hadoop Federation Balance ................... SUCCESS [  2.997 s]
[INFO] Apache Hadoop HDFS-RBF ............................. SUCCESS [  8.246 s]
[INFO] Apache Hadoop HDFS Project ......................... SUCCESS [  0.015 s]
[INFO] Apache Hadoop YARN SharedCacheManager .............. SUCCESS [  2.409 s]
[INFO] Apache Hadoop YARN Timeline Plugin Storage ......... SUCCESS [  2.445 s]
[INFO] Apache Hadoop YARN TimelineService HBase Backend ... SUCCESS [  0.024 s]
[INFO] Apache Hadoop YARN TimelineService HBase Common .... SUCCESS [  2.715 s]
[INFO] Apache Hadoop YARN TimelineService HBase Client .... SUCCESS [  3.647 s]
[INFO] Apache Hadoop YARN TimelineService HBase Servers ... SUCCESS [  0.027 s]
[INFO] Apache Hadoop YARN TimelineService HBase Server 2.5  SUCCESS [  2.712 s]
[INFO] Apache Hadoop YARN TimelineService HBase tests ..... SUCCESS [  2.610 s]
[INFO] Apache Hadoop YARN Router .......................... SUCCESS [  4.003 s]
[INFO] Apache Hadoop YARN TimelineService DocumentStore ... SUCCESS [  2.434 s]
[INFO] Apache Hadoop YARN GlobalPolicyGenerator ........... SUCCESS [  2.545 s]
[INFO] Apache Hadoop YARN Applications .................... SUCCESS [  0.024 s]
[INFO] Apache Hadoop YARN DistributedShell ................ SUCCESS [  2.651 s]
[INFO] Apache Hadoop YARN Unmanaged Am Launcher ........... SUCCESS [  2.048 s]
[INFO] Apache Hadoop YARN Services ........................ SUCCESS [  0.022 s]
[INFO] Apache Hadoop YARN Services Core ................... SUCCESS [  3.622 s]
[INFO] Apache Hadoop YARN Services API .................... SUCCESS [  2.229 s]
[INFO] Apache Hadoop YARN Application Catalog ............. SUCCESS [  0.021 s]
[INFO] Apache Hadoop YARN Application Catalog Webapp ...... SUCCESS [  9.862 s]
[INFO] Apache Hadoop YARN Application Catalog Docker Image  SUCCESS [  0.779 s]
[INFO] Apache Hadoop YARN Application MaWo ................ SUCCESS [  0.021 s]
[INFO] Apache Hadoop YARN Application MaWo Core ........... SUCCESS [  1.787 s]
[INFO] Apache Hadoop YARN Site ............................ SUCCESS [  0.023 s]
[INFO] Apache Hadoop YARN Registry ........................ SUCCESS [  0.799 s]
[INFO] Apache Hadoop YARN UI .............................. SUCCESS [  0.092 s]
[INFO] Apache Hadoop YARN CSI ............................. SUCCESS [  5.692 s]
[INFO] Apache Hadoop YARN Project ......................... SUCCESS [ 11.684 s]
[INFO] Apache Hadoop MapReduce HistoryServer Plugins ...... SUCCESS [  2.057 s]
[INFO] Apache Hadoop MapReduce NativeTask ................. SUCCESS [  2.778 s]
[INFO] Apache Hadoop MapReduce Uploader ................... SUCCESS [  2.227 s]
[INFO] Apache Hadoop MapReduce Examples ................... SUCCESS [  3.654 s]
[INFO] Apache Hadoop MapReduce ............................ SUCCESS [  5.044 s]
[INFO] Apache Hadoop MapReduce Streaming .................. SUCCESS [  3.525 s]
[INFO] Apache Hadoop Client Aggregator .................... SUCCESS [  1.979 s]
[INFO] Apache Hadoop Dynamometer Workload Simulator ....... SUCCESS [  2.827 s]
[INFO] Apache Hadoop Dynamometer Cluster Simulator ........ SUCCESS [  3.446 s]
[INFO] Apache Hadoop Dynamometer Block Listing Generator .. SUCCESS [  2.589 s]
[INFO] Apache Hadoop Dynamometer Dist ..................... SUCCESS [  3.224 s]
[INFO] Apache Hadoop Dynamometer .......................... SUCCESS [  0.023 s]
[INFO] Apache Hadoop Archives ............................. SUCCESS [  2.585 s]
[INFO] Apache Hadoop Archive Logs ......................... SUCCESS [  2.612 s]
[INFO] Apache Hadoop Rumen ................................ SUCCESS [  3.442 s]
[INFO] Apache Hadoop Gridmix .............................. SUCCESS [  3.105 s]
[INFO] Apache Hadoop Data Join ............................ SUCCESS [  2.635 s]
[INFO] Apache Hadoop Extras ............................... SUCCESS [  2.569 s]
[INFO] Apache Hadoop Pipes ................................ SUCCESS [  0.021 s]
[INFO] Apache Hadoop Amazon Web Services support .......... SUCCESS [ 14.929 s]
[INFO] Apache Hadoop Kafka Library support ................ SUCCESS [  1.915 s]
[INFO] Apache Hadoop Azure support ........................ SUCCESS [  6.384 s]
[INFO] Apache Hadoop Aliyun OSS support ................... SUCCESS [  2.718 s]
[INFO] Apache Hadoop Scheduler Load Simulator ............. SUCCESS [  3.595 s]
[INFO] Apache Hadoop Resource Estimator Service ........... SUCCESS [  2.535 s]
[INFO] Apache Hadoop Azure Data Lake support .............. SUCCESS [  2.332 s]
[INFO] Apache Hadoop Image Generation Tool ................ SUCCESS [  3.004 s]
[INFO] Apache Hadoop Tools Dist ........................... SUCCESS [ 12.634 s]
[INFO] Apache Hadoop OpenStack support .................... SUCCESS [  0.066 s]
[INFO] Apache Hadoop Common Benchmark ..................... SUCCESS [  7.274 s]
[INFO] Apache Hadoop Compatibility Benchmark .............. SUCCESS [  2.425 s]
[INFO] Apache Hadoop Tools ................................ SUCCESS [  0.014 s]
[INFO] Apache Hadoop Client API ........................... SUCCESS [01:10 min]
[INFO] Apache Hadoop Client Runtime ....................... SUCCESS [01:18 min]
[INFO] Apache Hadoop Client Packaging Invariants .......... SUCCESS [  0.616 s]
[INFO] Apache Hadoop Client Test Minicluster .............. SUCCESS [02:17 min]
[INFO] Apache Hadoop Client Packaging Invariants for Test . SUCCESS [  0.978 s]
[INFO] Apache Hadoop Client Packaging Integration Tests ... SUCCESS [  1.074 s]
[INFO] Apache Hadoop Distribution ......................... SUCCESS [ 26.653 s]
[INFO] Apache Hadoop Client Modules ....................... SUCCESS [  0.039 s]
[INFO] Apache Hadoop Tencent COS Support .................. SUCCESS [  3.102 s]
[INFO] Apache Hadoop OBS support .......................... SUCCESS [  2.703 s]
[INFO] Apache Hadoop Cloud Storage ........................ SUCCESS [  6.145 s]
[INFO] Apache Hadoop Cloud Storage Project ................ SUCCESS [  0.015 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  11:53 min
[INFO] Finished at: 2024-10-19T01:02:45+08:00
[INFO] ------------------------------------------------------------------------

For code changes:

upgrade maven.plugin-tools.version to 3.10.2

@myandpr
Copy link
Contributor Author

myandpr commented Oct 18, 2024

@slfan1989 Hi, could you help review this PR? Many thanks!

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 47s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 48m 44s trunk passed
-1 ❌ compile 0m 23s /branch-compile-hadoop-maven-plugins-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt hadoop-maven-plugins in trunk failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
+1 💚 compile 0m 25s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 mvnsite 0m 30s trunk passed
+1 💚 javadoc 0m 32s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 0m 24s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 89m 44s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 24s the patch passed
-1 ❌ compile 0m 14s /patch-compile-hadoop-maven-plugins-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt hadoop-maven-plugins in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
-1 ❌ javac 0m 14s /patch-compile-hadoop-maven-plugins-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt hadoop-maven-plugins in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
+1 💚 compile 0m 17s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 0m 17s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 20s the patch passed
+1 💚 javadoc 0m 19s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 0m 17s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 39m 51s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 21s hadoop-maven-plugins in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
134m 0s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/1/artifact/out/Dockerfile
GITHUB PR #7125
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 0235fc6e7a6c 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 99c449c
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/1/testReport/
Max. process+thread count 528 (vs. ulimit of 5500)
modules C: hadoop-maven-plugins U: hadoop-maven-plugins
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 18m 13s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 22s Maven dependency ordering for branch
+1 💚 mvninstall 37m 17s trunk passed
-1 ❌ compile 0m 35s /branch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt root in trunk failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
+1 💚 compile 22m 32s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 mvnsite 1m 19s trunk passed
+1 💚 javadoc 1m 20s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 1m 11s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 118m 42s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for patch
+1 💚 mvninstall 0m 32s the patch passed
-1 ❌ compile 0m 17s /patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
-1 ❌ javac 0m 17s /patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
+1 💚 compile 17m 43s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 17m 43s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 20s the patch passed
+1 💚 javadoc 1m 16s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 1m 15s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 45m 42s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 35s hadoop-project in the patch passed.
+1 💚 unit 0m 39s hadoop-maven-plugins in the patch passed.
+1 💚 asflicense 1m 3s The patch does not generate ASF License warnings.
206m 3s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/2/artifact/out/Dockerfile
GITHUB PR #7125
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 391264c04f98 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 503c336
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/2/testReport/
Max. process+thread count 527 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-maven-plugins U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/2/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link

@zeekling zeekling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can compile it without this modification locally.

image

@myandpr
Copy link
Contributor Author

myandpr commented Oct 20, 2024

I can compile it without this modification locally.

image

Indeed, I think this version 3.10.2 may have introduced some compatibility issues under JDK 17.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 47s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 58s Maven dependency ordering for branch
+1 💚 mvninstall 36m 20s trunk passed
-1 ❌ compile 0m 27s /branch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt root in trunk failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
+1 💚 compile 18m 21s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 mvnsite 1m 21s trunk passed
+1 💚 javadoc 1m 21s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 1m 14s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 113m 25s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 36s Maven dependency ordering for patch
+1 💚 mvninstall 0m 36s the patch passed
-1 ❌ compile 0m 57s /patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
-1 ❌ javac 0m 57s /patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
+1 💚 compile 17m 11s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 17m 11s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 17s the patch passed
+1 💚 javadoc 1m 11s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 1m 14s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 47m 4s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 33s hadoop-project in the patch passed.
+1 💚 unit 0m 38s hadoop-maven-plugins in the patch passed.
+1 💚 asflicense 1m 3s The patch does not generate ASF License warnings.
184m 46s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/3/artifact/out/Dockerfile
GITHUB PR #7125
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux ab704b91c9b5 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / aa2ae1e
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/3/testReport/
Max. process+thread count 582 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-maven-plugins U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/3/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 45s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 2s codespell was not available.
+0 🆗 detsecrets 0m 2s detect-secrets was not available.
+0 🆗 xmllint 0m 2s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 16m 53s Maven dependency ordering for branch
+1 💚 mvninstall 55m 38s trunk passed
-1 ❌ compile 0m 43s /branch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt root in trunk failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
+1 💚 compile 30m 51s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 mvnsite 1m 54s trunk passed
+1 💚 javadoc 1m 52s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 1m 36s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 156m 50s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 45s Maven dependency ordering for patch
+1 💚 mvninstall 0m 49s the patch passed
-1 ❌ compile 1m 16s /patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
-1 ❌ javac 1m 16s /patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
-1 ❌ compile 27m 19s /patch-compile-root-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt root in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.
-1 ❌ javac 27m 19s /patch-compile-root-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt root in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.
+1 💚 blanks 0m 1s The patch has no blanks issues.
+1 💚 mvnsite 1m 53s the patch passed
+1 💚 javadoc 1m 45s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 1m 42s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 52m 49s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 33s hadoop-project in the patch passed.
+1 💚 unit 0m 38s hadoop-maven-plugins in the patch passed.
+1 💚 asflicense 1m 1s The patch does not generate ASF License warnings.
246m 53s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/4/artifact/out/Dockerfile
GITHUB PR #7125
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux c670278a80c2 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 01127dd
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/4/testReport/
Max. process+thread count 533 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-maven-plugins U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/4/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 21m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 48m 32s trunk passed
+1 💚 compile 0m 27s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 0m 25s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 mvnsite 0m 31s trunk passed
+1 💚 javadoc 0m 31s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 0m 25s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 90m 54s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 24s the patch passed
+1 💚 compile 0m 18s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 0m 18s the patch passed
+1 💚 compile 0m 17s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 0m 17s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 20s the patch passed
+1 💚 javadoc 0m 18s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 0m 17s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 40m 9s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 23s hadoop-maven-plugins in the patch passed.
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
156m 12s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/5/artifact/out/Dockerfile
GITHUB PR #7125
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 42ab1ee3d6fd 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 87ef2d6
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/5/testReport/
Max. process+thread count 535 (vs. ulimit of 5500)
modules C: hadoop-maven-plugins U: hadoop-maven-plugins
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/5/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
I'm happy with this but think @slfan1989 should look at it too.

once merged we should leave it on trunk for a few weeks before backporting to see if there are any surprises

@slfan1989
Copy link
Contributor

+1 I'm happy with this but think @slfan1989 should look at it too.

once merged we should leave it on trunk for a few weeks before backporting to see if there are any surprises

LGTM +1.

@github-actions github-actions bot added the HDFS label Oct 31, 2024
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 49m 2s trunk passed
+1 💚 compile 0m 29s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 0m 25s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 mvnsite 0m 28s trunk passed
+1 💚 javadoc 0m 29s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 0m 35s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 93m 23s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 24s the patch passed
+1 💚 compile 0m 21s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 0m 21s the patch passed
+1 💚 compile 0m 17s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 0m 17s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 20s the patch passed
+1 💚 javadoc 0m 17s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 0m 16s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 40m 58s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 20s hadoop-maven-plugins in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
139m 1s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/7/artifact/out/Dockerfile
GITHUB PR #7125
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux c1a4b4eae0d4 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 03268a9
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/7/testReport/
Max. process+thread count 534 (vs. ulimit of 5500)
modules C: hadoop-maven-plugins U: hadoop-maven-plugins
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/7/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 18s Maven dependency ordering for branch
+1 💚 mvninstall 37m 9s trunk passed
+1 💚 compile 20m 38s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 18m 28s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 4m 56s trunk passed
+1 💚 mvnsite 2m 26s trunk passed
+1 💚 javadoc 2m 11s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 2m 33s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 4m 27s trunk passed
+1 💚 shadedclient 42m 35s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for patch
+1 💚 mvninstall 1m 37s the patch passed
+1 💚 compile 18m 54s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 18m 54s the patch passed
+1 💚 compile 17m 53s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 17m 53s the patch passed
-1 ❌ blanks 0m 0s /blanks-eol.txt The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️ checkstyle 4m 43s /results-checkstyle-root.txt root: The patch generated 1 new + 8 unchanged - 1 fixed = 9 total (was 9)
+1 💚 mvnsite 2m 18s the patch passed
+1 💚 javadoc 2m 6s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 2m 41s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 4m 55s the patch passed
+1 💚 shadedclient 42m 46s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 40s hadoop-maven-plugins in the patch passed.
+1 💚 unit 261m 55s hadoop-hdfs in the patch passed.
+1 💚 asflicense 1m 15s The patch does not generate ASF License warnings.
513m 48s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/6/artifact/out/Dockerfile
GITHUB PR #7125
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux 9137506639a1 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / b735451
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/6/testReport/
Max. process+thread count 3017 (vs. ulimit of 5500)
modules C: hadoop-maven-plugins hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7125/6/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989 slfan1989 merged commit df979e7 into apache:trunk Nov 4, 2024
1 of 3 checks passed
@slfan1989
Copy link
Contributor

@myandpr Thanks for the contribution! @steveloughran Thanks for the review!

slfan1989 pushed a commit that referenced this pull request Nov 8, 2024
…7125) (#7147) Contributed by Min Yan.

Signed-off-by: Shilun Fan <slfan1989@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants