-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAPREDUCE-7494. File stream leak when LineRecordReader is interrupted #7117
Merged
steveloughran
merged 2 commits into
apache:trunk
from
davintjong-db:davintjong-db/file-stream-leak
Oct 16, 2024
Merged
MAPREDUCE-7494. File stream leak when LineRecordReader is interrupted #7117
steveloughran
merged 2 commits into
apache:trunk
from
davintjong-db:davintjong-db/file-stream-leak
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 -1 overall
This message was automatically generated. |
steveloughran
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I couldn't see an easy way to write test for this, so ignoring that yetus complaint
steveloughran
changed the title
MAPREDUCE-7494. Fix file stream leak on interruption in LineRecordReader
MAPREDUCE-7494. File stream leak when LineRecordReader is interrupted
Oct 16, 2024
ok, merged to trunk. Can you push up a cherry to branch 3.4 for yetus to validate it, then I'll merge to there too |
davintjong-db
added a commit
to davintjong-db/hadoop
that referenced
this pull request
Oct 16, 2024
…apache#7117) Contributed by Davin Tjong
davintjong-db
added a commit
to davintjong-db/hadoop
that referenced
this pull request
Oct 17, 2024
…apache#7117) Contributed by Davin Tjong
davintjong-db
added a commit
to davintjong-db/hadoop
that referenced
this pull request
Oct 17, 2024
…apache#7117) Contributed by Davin Tjong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
In LineRecordReader, we may open a filestream:
However, we may be interrupted or otherwise throw an error before
in
is initialized, for example here:If this happens, the caller has no way to close this file stream causing it to leak.
How was this patch tested?
Existing tests.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?