-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17601. [ARR] RouterRpcServer supports asynchronous rpc. #7108
base: HDFS-17531
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
}); | ||
}); | ||
|
||
asyncCatch((AsyncCatchFunction<T, IOException>)(ret, ex) -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use CatchFunction.
throw ioe; | ||
} | ||
nss.removeIf(n -> n.getNameserviceId().equals(nsId)); | ||
invokeOnNs(method, clazz, io, nss); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hfutatzhanghb should use invokeOnNsAsync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.
Will add UTs these days. |
💔 -1 overall
This message was automatically generated. |
Hi @hfutatzhanghb And fix the blanks. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Description of PR
RouterRpcServer supports asynchronous RPC, the following methods need to be transformed to asynchronous versions: