Skip to content

HDFS-17381. Distcp of EC files should not be limited to DFS. #7083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

HDFS-17381. Distcp of EC files should not be limited to DFS. #7083

wants to merge 2 commits into from

Conversation

sadanand48
Copy link
Contributor

Description of PR

Backport of HDFS-17381 from trunk to branch-3.4

How was this patch tested?

Unit tests added

@sadanand48
HDFS-17381. Distcp of EC files should not be limited to DFS. (apache#…
71a3200 
…6551)

Contributed by Sadanand Shenoy

(cherry picked from commit 49a4958)
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 17m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.4 Compile Tests _
+0 🆗 mvndep 4m 19s Maven dependency ordering for branch
+1 💚 mvninstall 45m 28s branch-3.4 passed
+1 💚 compile 19m 31s branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 18m 7s branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 4m 53s branch-3.4 passed
+1 💚 mvnsite 3m 40s branch-3.4 passed
+1 💚 javadoc 2m 56s branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 2m 28s branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
-1 ❌ spotbugs 2m 52s /branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html hadoop-hdfs-project/hadoop-hdfs-client in branch-3.4 has 1 extant spotbugs warnings.
+1 💚 shadedclient 40m 37s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for patch
+1 💚 mvninstall 2m 9s the patch passed
+1 💚 compile 18m 45s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 18m 45s the patch passed
+1 💚 compile 17m 47s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 17m 47s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 4m 44s /results-checkstyle-root.txt root: The patch generated 5 new + 93 unchanged - 0 fixed = 98 total (was 93)
+1 💚 mvnsite 3m 33s the patch passed
+1 💚 javadoc 2m 52s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 2m 29s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 6m 58s the patch passed
+1 💚 shadedclient 39m 21s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 23s hadoop-common in the patch passed.
+1 💚 unit 2m 40s hadoop-hdfs-client in the patch passed.
+1 💚 unit 16m 21s hadoop-distcp in the patch passed.
+1 💚 asflicense 1m 2s The patch does not generate ASF License warnings.
310m 15s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7083/1/artifact/out/Dockerfile
GITHUB PR #7083
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux cc863140c0ef 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / 71a3200
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7083/1/testReport/
Max. process+thread count 1263 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-tools/hadoop-distcp U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7083/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 11m 47s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.4 Compile Tests _
+0 🆗 mvndep 4m 39s Maven dependency ordering for branch
+1 💚 mvninstall 41m 46s branch-3.4 passed
+1 💚 compile 17m 40s branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 16m 35s branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 4m 21s branch-3.4 passed
+1 💚 mvnsite 3m 43s branch-3.4 passed
+1 💚 javadoc 2m 57s branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 2m 31s branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
-1 ❌ spotbugs 2m 45s /branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html hadoop-hdfs-project/hadoop-hdfs-client in branch-3.4 has 1 extant spotbugs warnings.
+1 💚 shadedclient 34m 34s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for patch
+1 💚 mvninstall 2m 15s the patch passed
+1 💚 compile 16m 56s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 16m 56s the patch passed
+1 💚 compile 16m 28s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 16m 28s the patch passed
+1 💚 blanks 0m 1s The patch has no blanks issues.
-0 ⚠️ checkstyle 4m 23s /results-checkstyle-root.txt root: The patch generated 5 new + 97 unchanged - 0 fixed = 102 total (was 97)
+1 💚 mvnsite 3m 43s the patch passed
+1 💚 javadoc 2m 53s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 2m 37s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 2m 44s hadoop-common in the patch passed.
+1 💚 spotbugs 2m 56s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚 spotbugs 1m 14s hadoop-distcp in the patch passed.
+1 💚 shadedclient 34m 51s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 41s hadoop-common in the patch passed.
+1 💚 unit 2m 47s hadoop-hdfs-client in the patch passed.
+1 💚 unit 15m 22s hadoop-distcp in the patch passed.
+1 💚 asflicense 1m 5s The patch does not generate ASF License warnings.
282m 33s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7083/2/artifact/out/Dockerfile
GITHUB PR #7083
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 0d8f4f2b6331 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / b9ec09c
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7083/2/testReport/
Max. process+thread count 3152 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-tools/hadoop-distcp U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7083/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@sadanand48 sadanand48 force-pushed the HDFS-17381_branch_3.4 branch from b9ec09c to cdeb8df Compare October 1, 2024 14:12
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.4 Compile Tests _
+0 🆗 mvndep 4m 18s Maven dependency ordering for branch
+1 💚 mvninstall 46m 49s branch-3.4 passed
+1 💚 compile 19m 41s branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 17m 47s branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 4m 44s branch-3.4 passed
+1 💚 mvnsite 3m 44s branch-3.4 passed
+1 💚 javadoc 2m 54s branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 2m 25s branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
-1 ❌ spotbugs 2m 46s /branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html hadoop-hdfs-project/hadoop-hdfs-client in branch-3.4 has 1 extant spotbugs warnings.
+1 💚 shadedclient 39m 20s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for patch
+1 💚 mvninstall 2m 11s the patch passed
+1 💚 compile 18m 47s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 18m 47s the patch passed
+1 💚 compile 17m 57s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 17m 57s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 4m 52s /results-checkstyle-root.txt root: The patch generated 5 new + 98 unchanged - 0 fixed = 103 total (was 98)
+1 💚 mvnsite 3m 39s the patch passed
+1 💚 javadoc 2m 52s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 2m 32s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 2m 46s hadoop-common in the patch passed.
+1 💚 spotbugs 3m 5s hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚 spotbugs 1m 11s hadoop-distcp in the patch passed.
+1 💚 shadedclient 39m 29s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 24s hadoop-common in the patch passed.
+1 💚 unit 2m 41s hadoop-hdfs-client in the patch passed.
+1 💚 unit 16m 13s hadoop-distcp in the patch passed.
+1 💚 asflicense 1m 5s The patch does not generate ASF License warnings.
293m 27s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7083/3/artifact/out/Dockerfile
GITHUB PR #7083
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 1880521fbff2 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / cdeb8df
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7083/3/testReport/
Max. process+thread count 3137 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-tools/hadoop-distcp U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7083/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@sadanand48 sadanand48 mentioned this pull request Oct 2, 2024
Closed
@sadanand48
Copy link
Contributor Author

sadanand48 commented Oct 3, 2024 •
edited
Loading

@steveloughran could you please review and merge this backport?
Regarding "hadoop-hdfs-project/hadoop-hdfs-client in branch-3.4 has 1 extant spotbugs warnings." , I have cherry-picked the commit here itself to fix the spotbugs warning, although I think the check doesn't use code from PR which is why it fails. I tried creating separate PR to see if it made a difference but apparently not.

jojochuang
jojochuang approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. will merge later.

There are checkstyle warnings but I suppose they are carried over from the original commit, so I'm not going to change it and make future backports tricky.

Ideally we should have contract tests for the new FileSystem interface (like what we did in HADOOP-18671/ #5553

@sadanand48
Copy link
Contributor Author

There are checkstyle warnings but I suppose they are carried over from the original commit

Thanks @jojochuang , These are not from the original commit but due to HDFS-17461 missing on branch-3.4 . I have cherry-picked that change (not part of the original commit) in this same PR in this commit but somehow the CI still shows this warning.

@jojochuang
Copy link
Contributor

Pushed locally to github branch-3.4.
Thanks @sadanand48

@jojochuang jojochuang closed this Oct 4, 2024
@jojochuang
Copy link
Contributor

(I pushed locally to preserve commit history. otherwise I'd be forced to squash the two commits)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojochuang jojochuang jojochuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadanand48 @hadoop-yetus @jojochuang