-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19107. Drop support for HBase v1 timeline service & upgrade HBase v2 (#6629). #7017
HADOOP-19107. Drop support for HBase v1 timeline service & upgrade HBase v2 (#6629). #7017
Conversation
…). Contributed by Ayush Saxena Change-Id: I438d089be9d25cf48eea61c488467094f893c6a6
9e4cad0
to
42ba5d1
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
spotbugs unhappy
|
💔 -1 overall
This message was automatically generated. |
the PR has some changes from HADOOP-19019, maybe they came while trying to resolve conflicts, the build is failing for some strange reason
It is crying for HBase-1 POM: |
💔 -1 overall
This message was automatically generated. |
one of the test failures will be fixed by 1.3.0 third party
|
Hi @steveloughran I tried experimenting on this PR but for some strange reason it is picking up the hbase-server-1 module in the yetus and failing for that. some unrelated test failures here, So I/you can force push the changes from that PR here & then merge it via CLI, since there are two commits being backported & I think it should be safe to backport HADOOP-19019, it was causing conflicts with this one, so I included that as well. or figure out what is the diff b/w the two PR and push the delta here |
if you push up a backport PR into CDPD-64482 we can revisit this after. not targeting 3.4.1 there; it could be the last release with hbase 1 and java8... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no need to remove support for HBase v1 in Hadoop 3.4, which is a destructive change.
I shall make clear in the JIRA that this only for ATS...hbase itself should be happy. Though as usual, testing is always welcome. Is that OK? |
@zeekling is the change acceptable? Or is it that you consider a branch-3.4 backport the issue FWIW I'm thinking we may want to do a 3.5 release with compatibility issues in a few months, including:
|
I support this decision +1. I support the removal of HBase 1.x in the Hadoop 3.4 branch, as the official stable version of HBase no longer includes 1.x. We should move forward. If users need HBase 1.x, they can utilize previous branches (Hadoop 3.x) and make adaptations suitable for their internal production systems. https://downloads.apache.org/hbase/
|
While trying to backport https://issues.apache.org/jira/browse/HADOOP-15760, found that we depend on hadoop 2.8.5 for tests, thanks to hbase 1.7.1 dependency for timeline service, both of which bring in commons-collections:commons-collections:3.2.2 transitively. I am in support of this change, given hbase 1.x was EOL'ed long ago and having this in hadoop makes things a lot tricky to manage. |
OK, going ahead with this. We need it for ongoing work. |
Description of PR
HADOOP-19107 cherrypicked to branch 3.4, targeting 3.4.2 release
the main merge pain was in hadoop-yarn-project/pom.xml ; there's enough of what appears to be unrelated to say "someone who understands yarn modules needs to review this"
How was this patch tested?
it compiles
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?