HDFS-17596. [ARR] RouterStoragePolicy supports asynchronous rpc. #6988
+308
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeeProMise
reviewed
Aug 13, 2024
|
|
||
| import static org.apache.hadoop.hdfs.server.federation.router.async.AsyncUtil.asyncReturn; | ||
|
|
||
| public class AsyncRouterStoragePolicy extends RouterStoragePolicy { |
There was a problem hiding this comment.
@hfutatzhanghb Hi, thanks for your contribution. Should we change the name of this class to RouterAsyncStoragePolicy?
There was a problem hiding this comment.
@KeeProMise Sir, thanks for reviewing. OK, i will fix it and we keep the same style for other Class name.
Comment on lines
42
to
50
| public BlockStoragePolicy getStoragePolicy(String path) | ||
| throws IOException { | ||
| rpcServer.checkOperation(NameNode.OperationCategory.READ, true); | ||
|
|
||
| List<RemoteLocation> locations = | ||
| rpcServer.getLocationsForPath(path, false, false); | ||
| RemoteMethod method = new RemoteMethod("getStoragePolicy", | ||
| new Class<?>[] {String.class}, | ||
| new RemoteParam()); |
There was a problem hiding this comment.
This method does not seem to require asynchronous transformation, just use the parent class.
4 tasks
Hexiaoqiao
force-pushed
the
HDFS-17531
branch
from
4e0b405
to
a591902
Compare
|
Hi, @hfutatzhanghb HDFS-17545 has already been merged into HDFS-17531, please rebase your development branch using HDFS-17531. |
hfutatzhanghb
force-pushed
the
HDFS-17596
branch
from
8169421
to
2af8558
Compare
|
💔 -1 overall
This message was automatically generated. |
KeeProMise
reviewed
Oct 9, 2024
.../src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterAsyncStoragePolicy.java
Show resolved
Hide resolved
...-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
Outdated
Show resolved
Hide resolved
| // If no namespace is available, throw IOException. | ||
| IOException io = new IOException("No namespace available."); | ||
|
|
||
| asyncComplete(null); |
There was a problem hiding this comment.
Hi, @hfutatzhanghb IMO, asyncComplete(null) is not needed in this place.
| }); | ||
| }); | ||
|
|
||
| asyncCatch((AsyncCatchFunction<T, IOException>)(ret, ex) -> { |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
KeeProMise
reviewed
Oct 13, 2024
There was a problem hiding this comment.
Hi, @hfutatzhanghb I found that the reason why the UT failed was that RouterRpcServer used RouterRpcClient instead of RouterAsyncRpcClient when calling the invokeOnNsAsync and invokeAtAvailableNsAsync methods in the UT, resulting in null.
I gave a fix suggestion, maybe you have a better approach.
| // If default Ns is present return result from that namespace. | ||
| if (!nsId.isEmpty()) { | ||
| asyncTry(() -> { | ||
| rpcClient.invokeSingle(nsId, method, clazz); |
There was a problem hiding this comment.
Hi @hfutatzhanghb this can fix UT
getRPCClient().invokeSingle(nsId, method, clazz);| String nsId = fnInfo.getNameserviceId(); | ||
| LOG.debug("Invoking {} on namespace {}", method, nsId); | ||
| asyncTry(() -> { | ||
| rpcClient.invokeSingle(nsId, method, clazz); |
There was a problem hiding this comment.
Same as above.
getRPCClient().invokeSingle(nsId, method, clazz);There was a problem hiding this comment.
@KeeProMise Sir, Thanks for your reviewing and pointing out the problem, i will fix it soonly.
...-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
Outdated
Show resolved
Hide resolved
...-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
KeeProMise
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Hi @hfutatzhanghb LGTM! @Hexiaoqiao if you have time, please help to review the pr.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Hexiaoqiao
reviewed
Oct 15, 2024
| @@ -791,6 +800,36 @@ <T> T invokeAtAvailableNs(RemoteMethod method, Class<T> clazz) | |||
| return invokeOnNs(method, clazz, io, nss); | |||
| } | |||
|
|
|||
| <T> T invokeAtAvailableNsAsync(RemoteMethod method, Class<T> clazz) | |||
There was a problem hiding this comment.
How about to split this changes to separate PR which is common update and not relate with StoragePolicy only. Others look good to me. Thanks.
There was a problem hiding this comment.
@Hexiaoqiao @KeeProMise Agree with you, sir. This PR depends on #7108
, I have splited this chanages to PR #7108. PTAL. thanks a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
The main new addition is RouterAsyncStoragePolicy, which extends RouterStoragePolicy so that supports asynchronous rpc.