-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDFS-17594. [ARR] RouterCacheAdmin supports asynchronous rpc. #6986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
public long addCacheDirective( | ||
CacheDirectiveInfo path, EnumSet<CacheFlag> flags) throws IOException { | ||
invokeAddCacheDirective(path, flags); | ||
asyncApply((ApplyFunction<Map<RemoteLocation, Long>, Long>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Archie-wang Thanks for your contribution, you can remove the blank at the end of this line of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
🎊 +1 overall
This message was automatically generated. |
4e0b405
to
a591902
Compare
Hi, @Archie-wang HDFS-17545 has already been merged into HDFS-17531, please rebase your development branch using HDFS-17531. |
aeecad6
to
9d8f287
Compare
💔 -1 overall
This message was automatically generated. |
9d8f287
to
7c1ceda
Compare
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Archie-wang LGTM, @Hexiaoqiao if you have time, please take a look at the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1.
@Archie-wang Thanks for your contribution! @Hexiaoqiao Thanks for your review! |
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…. Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
Description of PR
https://issues.apache.org/jira/browse/HDFS-17594
How was this patch tested?
new UT
TestRouterAsyncCacheAdmin
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?