-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17337. RPC RESPONSE time seems not exactly accurate when using FSEditLogAsync. #6439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Hexiaoqiao @zhangshuyan0 @tomscut @slfan1989 Sir, could you please review this PR when you have free time? Thanks a lot ~ |
💔 -1 overall
This message was automatically generated. |
zhangshuyan0
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. LGTM.
tomscut
approved these changes
Jan 17, 2024
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
…SEditLogAsync. (apache#6439). Contributed by farmmamba. Reviewed-by: Tao Li <tomscut@apache.org> Signed-off-by: Shuyan Zhang <zhangshuyan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Refer to HDFS-17337.
Currently, FSEditLogAsync is enabled by default.
We have below codes in method Server$RpcCall#run:
It computes Timing.RESPONSE of a RpcCall using Time.monotonicNowNanos() - startNanos;
However, if we use async editlogging, we will not send response here but in FSEditLogAsync.RpcEdit#logSyncNotify.
This causes the Timing.RESPONSE of a RpcCall not be exactly accurate.
flame graph like below: