YARN-11433. Router's main() should support generic options. #6012

slfan1989 · 2023-08-31T16:08:58Z

Description of PR

JIRA: YARN-11433. Router's main() should support generic options.

How was this patch tested?

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

goiri · 2023-08-31T17:42:57Z

...src/main/java/org/apache/hadoop/yarn/server/globalpolicygenerator/GlobalPolicyGenerator.java

@@ -290,7 +291,9 @@ private String getHostName(Configuration config)

  public static void main(String[] argv) {
    try {
-      startGPG(argv, new YarnConfiguration());
+      YarnConfiguration conf = new YarnConfiguration();
+      new GenericOptionsParser(conf, argv);


I'm not familiar with this but this use looks not complete.
Most other places use the getRemainingArgs().

Thank you very much for helping review the code! When I first saw YARN-11433, my thoughts were aligned with yours, and I also had concerns about whether such an implementation was necessary.

I noticed YARN-3255, where RM, NM, JobHistoryServer, and WebAppProxyServer's main() should support generic options. Other components in YARN, such as RM, NM, and JobHistoryServer, have implemented similar logic. I believe Router and GPG should be able to implement this logic as well.

hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java

Lines 1051 to 1058 in b6d06c8

public static void main(String[] args) throws IOException {

Thread.setDefaultUncaughtExceptionHandler(new YarnUncaughtExceptionHandler());

StringUtils.startupShutdownMessage(NodeManager.class, args, LOG);

@SuppressWarnings("resource")

NodeManager nodeManager = new NodeManager();

Configuration conf = new YarnConfiguration();

new GenericOptionsParser(conf, args);

nodeManager.initAndStartNodeManager(conf, false);

hadoop-yetus · 2023-08-31T18:43:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 22s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 17s		Maven dependency ordering for branch
+1 💚	mvninstall	35m 22s		trunk passed
+1 💚	compile	2m 35s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	compile	2m 13s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	1m 23s		trunk passed
+1 💚	mvnsite	0m 59s		trunk passed
+1 💚	javadoc	1m 2s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 53s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 34s		trunk passed
+1 💚	shadedclient	36m 46s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 41s		the patch passed
+1 💚	compile	2m 26s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javac	2m 26s		the patch passed
+1 💚	compile	2m 11s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	2m 11s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 13s		the patch passed
+1 💚	mvnsite	0m 44s		the patch passed
+1 💚	javadoc	0m 42s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 40s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 39s		the patch passed
+1 💚	shadedclient	36m 56s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 28s		hadoop-yarn-server-router in the patch passed.
+1 💚	unit	0m 44s		hadoop-yarn-server-globalpolicygenerator in the patch passed.
+1 💚	asflicense	0m 36s		The patch does not generate ASF License warnings.
		152m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/1/artifact/out/Dockerfile
GITHUB PR	#6012
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 4add61f436e0 5.15.0-78-generic #85-Ubuntu SMP Fri Jul 7 15:25:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `bacb4df`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/1/testReport/
Max. process+thread count	585 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-09-05T12:11:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	13m 31s		Maven dependency ordering for branch
+1 💚	mvninstall	36m 21s		trunk passed
+1 💚	compile	2m 51s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	compile	2m 26s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	1m 32s		trunk passed
+1 💚	mvnsite	1m 7s		trunk passed
+1 💚	javadoc	1m 10s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 55s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 47s		trunk passed
+1 💚	shadedclient	39m 3s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 40s		the patch passed
+1 💚	compile	2m 25s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javac	2m 25s		the patch passed
+1 💚	compile	2m 12s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	2m 12s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 12s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 6 new + 3 unchanged - 0 fixed = 9 total (was 3)
+1 💚	mvnsite	0m 44s		the patch passed
+1 💚	javadoc	0m 42s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 38s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 38s		the patch passed
+1 💚	shadedclient	38m 5s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 28s		hadoop-yarn-server-router in the patch passed.
+1 💚	unit	0m 42s		hadoop-yarn-server-globalpolicygenerator in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		156m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/2/artifact/out/Dockerfile
GITHUB PR	#6012
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux ef78aa1426c2 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `79eef2e`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/2/testReport/
Max. process+thread count	542 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2023-09-05T14:50:55Z

@goiri Can you help review this PR again? Thank you very much! I read the code of RM carefully, and I found that in the main function of RM, there will be some other operations, such as -format-state-store, -remove-application-from-state-store. I think Router/GPG also needs similar functionality.

...src/main/java/org/apache/hadoop/yarn/server/globalpolicygenerator/GlobalPolicyGenerator.java

...ver/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/Router.java

hadoop-yetus · 2023-09-06T16:42:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	13m 53s		Maven dependency ordering for branch
+1 💚	mvninstall	35m 37s		trunk passed
+1 💚	compile	2m 33s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	compile	2m 16s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	1m 23s		trunk passed
+1 💚	mvnsite	0m 56s		trunk passed
+1 💚	javadoc	0m 57s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 49s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 31s		trunk passed
+1 💚	shadedclient	38m 3s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 39s		the patch passed
+1 💚	compile	2m 25s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javac	2m 25s		the patch passed
+1 💚	compile	2m 14s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	2m 14s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 12s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 3 new + 3 unchanged - 0 fixed = 6 total (was 3)
+1 💚	mvnsite	0m 43s		the patch passed
+1 💚	javadoc	0m 42s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 39s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 38s		the patch passed
+1 💚	shadedclient	38m 5s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 27s		hadoop-yarn-server-router in the patch passed.
+1 💚	unit	0m 42s		hadoop-yarn-server-globalpolicygenerator in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		154m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/3/artifact/out/Dockerfile
GITHUB PR	#6012
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux a2fd92660175 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `636c01d`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/3/testReport/
Max. process+thread count	630 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2023-09-08T13:49:06Z

@goiri Can you help review this PR again? Thank you very much!

hadoop-yetus · 2023-09-08T16:04:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 26s		Maven dependency ordering for branch
+1 💚	mvninstall	36m 12s		trunk passed
+1 💚	compile	2m 33s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	compile	2m 17s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	1m 23s		trunk passed
+1 💚	mvnsite	0m 56s		trunk passed
+1 💚	javadoc	0m 57s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 48s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 31s		trunk passed
+1 💚	shadedclient	37m 39s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	37m 58s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 39s		the patch passed
+1 💚	compile	2m 23s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javac	2m 23s		the patch passed
+1 💚	compile	2m 10s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	2m 10s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	1m 12s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 3 new + 3 unchanged - 0 fixed = 6 total (was 3)
+1 💚	mvnsite	0m 43s		the patch passed
+1 💚	javadoc	0m 42s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 40s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 39s		the patch passed
+1 💚	shadedclient	38m 12s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 27s		hadoop-yarn-server-router in the patch passed.
+1 💚	unit	0m 42s		hadoop-yarn-server-globalpolicygenerator in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		155m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/4/artifact/out/Dockerfile
GITHUB PR	#6012
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 22ebbfd10501 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `9c4e9ac`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/4/testReport/
Max. process+thread count	582 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-09-11T05:04:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 46s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 38s		Maven dependency ordering for branch
+1 💚	mvninstall	36m 36s		trunk passed
+1 💚	compile	2m 34s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	compile	2m 15s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	1m 21s		trunk passed
+1 💚	mvnsite	0m 56s		trunk passed
+1 💚	javadoc	0m 58s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 49s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 34s		trunk passed
+1 💚	shadedclient	37m 31s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	37m 50s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 39s		the patch passed
+1 💚	compile	2m 23s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javac	2m 23s		the patch passed
+1 💚	compile	2m 11s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	2m 11s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 15s		the patch passed
+1 💚	mvnsite	0m 43s		the patch passed
+1 💚	javadoc	0m 42s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 39s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 39s		the patch passed
+1 💚	shadedclient	37m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 26s		hadoop-yarn-server-router in the patch passed.
+1 💚	unit	0m 42s		hadoop-yarn-server-globalpolicygenerator in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		154m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/5/artifact/out/Dockerfile
GITHUB PR	#6012
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux fa2fd2e23757 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `0ea47b1`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/5/testReport/
Max. process+thread count	529 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6012/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2023-09-12T23:48:42Z

@goiri Thank you very much for your help in reviewing the code!

)

YARN-11433. Router's main() should support generic options.

bacb4df

github-actions bot added YARN trunk labels Aug 31, 2023

goiri reviewed Aug 31, 2023

View reviewed changes

YARN-11433. Router's main() should support generic options.

79eef2e

goiri reviewed Sep 6, 2023

View reviewed changes

...src/main/java/org/apache/hadoop/yarn/server/globalpolicygenerator/GlobalPolicyGenerator.java Show resolved Hide resolved

...ver/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/Router.java Show resolved Hide resolved

YARN-11433. Fix CheckStyle.

636c01d

Merge branch 'trunk' into YARN-11433-V2

9c4e9ac

YARN-11433. Fix CheckStyle.

0ea47b1

goiri approved these changes Sep 12, 2023

View reviewed changes

goiri merged commit 9c8cdbe into apache:trunk Sep 12, 2023
2 checks passed

slfan1989 added a commit to slfan1989/hadoop that referenced this pull request Sep 13, 2023

YARN-11433. Router's main() should support generic options. (apache#6012

da5e5e3

)

jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024

YARN-11433. Router's main() should support generic options. (apache#6012

4409861

)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-11433. Router's main() should support generic options. #6012

YARN-11433. Router's main() should support generic options. #6012

slfan1989 commented Aug 31, 2023

goiri Aug 31, 2023

slfan1989 Aug 31, 2023 •

edited

Loading

hadoop-yetus commented Aug 31, 2023

hadoop-yetus commented Sep 5, 2023

slfan1989 commented Sep 5, 2023

hadoop-yetus commented Sep 6, 2023

slfan1989 commented Sep 8, 2023

hadoop-yetus commented Sep 8, 2023

hadoop-yetus commented Sep 11, 2023

slfan1989 commented Sep 12, 2023

	public static void main(String[] args) throws IOException {
	Thread.setDefaultUncaughtExceptionHandler(new YarnUncaughtExceptionHandler());
	StringUtils.startupShutdownMessage(NodeManager.class, args, LOG);
	@SuppressWarnings("resource")
	NodeManager nodeManager = new NodeManager();
	Configuration conf = new YarnConfiguration();
	new GenericOptionsParser(conf, args);
	nodeManager.initAndStartNodeManager(conf, false);

YARN-11433. Router's main() should support generic options. #6012

YARN-11433. Router's main() should support generic options. #6012

Conversation

slfan1989 commented Aug 31, 2023

Description of PR

How was this patch tested?

For code changes:

goiri Aug 31, 2023

Choose a reason for hiding this comment

slfan1989 Aug 31, 2023 • edited Loading

Choose a reason for hiding this comment

hadoop-yetus commented Aug 31, 2023

hadoop-yetus commented Sep 5, 2023

slfan1989 commented Sep 5, 2023

hadoop-yetus commented Sep 6, 2023

slfan1989 commented Sep 8, 2023

hadoop-yetus commented Sep 8, 2023

hadoop-yetus commented Sep 11, 2023

slfan1989 commented Sep 12, 2023

slfan1989 Aug 31, 2023 •

edited

Loading