HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md #5846

haiyang1987 · 2023-07-15T13:25:46Z

Description of PR

https://issues.apache.org/jira/browse/HDFS-17088

Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md

the debug verifyEC add new params description, such as [-blockId <blk_Id>] [-skipFailureBlocks].
dfsrouteradmin added a new command about -addAll.

… HDFSCommands.md

hadoop-yetus · 2023-07-15T15:30:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	markdownlint	0m 0s		markdownlint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+1 💚	mvninstall	48m 24s		trunk passed
+1 💚	mvnsite	1m 28s		trunk passed
+1 💚	shadedclient	82m 55s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 15s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	1m 19s		the patch passed
+1 💚	shadedclient	33m 50s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 41s		The patch does not generate ASF License warnings.
		123m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5846/1/artifact/out/Dockerfile
GITHUB PR	#5846
Optional Tests	dupname asflicense mvnsite codespell detsecrets markdownlint
uname	Linux 261f80e3901e 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ee85c48`
Max. process+thread count	706 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5846/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2023-07-16T00:44:50Z

@haiyang1987 Thank you very much for your contribution! Whether the EC commands of HDFS are complete in the md document, can you help to check? If there is something missing, can we add it all in this pr. The main reason is to consider the convenience of other partners' backport code.

haiyang1987 · 2023-07-16T05:17:37Z

@haiyang1987 Thank you very much for your contribution! Whether the EC commands of HDFS are complete in the md document, can you help to check? If there is something missing, can we add it all in this pr. The main reason is to consider the convenience of other partners' backport code.

Hi @slfan1989 sir thanks help me review .

yeah, I will check whether the EC command of HDFS in the md document is complete.

haiyang1987 · 2023-07-17T12:00:27Z

Hi @slfan1989 Sir, update EC command of HDFS in the md document.
please help me review again when you have free time ? Thanks a lot~

hadoop-yetus · 2023-07-17T14:00:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	markdownlint	0m 0s		markdownlint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+1 💚	mvninstall	45m 9s		trunk passed
+1 💚	mvnsite	1m 26s		trunk passed
+1 💚	shadedclient	79m 30s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 14s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	1m 17s		the patch passed
+1 💚	shadedclient	34m 22s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 41s		The patch does not generate ASF License warnings.
		119m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5846/2/artifact/out/Dockerfile
GITHUB PR	#5846
Optional Tests	dupname asflicense mvnsite codespell detsecrets markdownlint
uname	Linux 958b3e296fd3 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `9e4274e`
Max. process+thread count	555 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5846/2/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2023-07-17T21:23:28Z

@haiyang1987 LGTM, let's look at other partners' suggestions, if there is no comment after 2 days, it will be merged to the trunk branch.

ayushtkn

dfsrouteradmin missed -dumpState as well, we should add that as well
https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAdminCLI.java#L876

haiyang1987 · 2023-07-18T09:18:46Z

dfsrouteradmin missed -dumpState as well, we should add that as well https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAdminCLI.java#L876

noted, i will update it later.

haiyang1987 · 2023-07-18T09:39:17Z

Update PR, add -dumpState.

@slfan1989 @goiri @ayushtkn sir please help me review this pr again when you have free time. Thanks a lot!!!

hadoop-yetus · 2023-07-18T11:37:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	markdownlint	0m 0s		markdownlint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+1 💚	mvninstall	48m 36s		trunk passed
+1 💚	mvnsite	1m 25s		trunk passed
+1 💚	shadedclient	83m 12s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 14s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	1m 18s		the patch passed
+1 💚	shadedclient	34m 17s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 41s		The patch does not generate ASF License warnings.
		123m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5846/3/artifact/out/Dockerfile
GITHUB PR	#5846
Optional Tests	dupname asflicense mvnsite codespell detsecrets markdownlint
uname	Linux bcb627dd8ee4 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7433ae6`
Max. process+thread count	555 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5846/3/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn

LGTM

slfan1989 · 2023-07-19T01:54:54Z

@haiyang1987 Thanks for your contribution! @ayushtkn @goiri @tomscut Thanks for the review!

haiyang1987 · 2023-07-21T13:21:23Z

Thanks @slfan1989 @ayushtkn @goiri @tomscut help me review and merge it.

… HDFSCommands.md (apache#5846)

HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in…

ee85c48

… HDFSCommands.md

slfan1989 approved these changes Jul 15, 2023

View reviewed changes

HDFS-17088. Modify patch based on comments

9e4274e

slfan1989 approved these changes Jul 17, 2023

View reviewed changes

goiri approved these changes Jul 17, 2023

View reviewed changes

ayushtkn reviewed Jul 18, 2023

View reviewed changes

HDFS-17088. Modify patch based on comments

7433ae6

tomscut approved these changes Jul 18, 2023

View reviewed changes

ayushtkn approved these changes Jul 18, 2023

View reviewed changes

slfan1989 merged commit 8df1616 into apache:trunk Jul 19, 2023
1 check passed

jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024

HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in…

cfe21d7

… HDFSCommands.md (apache#5846)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md #5846

HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md #5846

haiyang1987 commented Jul 15, 2023

hadoop-yetus commented Jul 15, 2023

slfan1989 commented Jul 16, 2023

haiyang1987 commented Jul 16, 2023

haiyang1987 commented Jul 17, 2023

hadoop-yetus commented Jul 17, 2023

slfan1989 commented Jul 17, 2023

ayushtkn left a comment

haiyang1987 commented Jul 18, 2023

haiyang1987 commented Jul 18, 2023

hadoop-yetus commented Jul 18, 2023

ayushtkn left a comment

slfan1989 commented Jul 19, 2023

haiyang1987 commented Jul 21, 2023

HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md #5846

HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md #5846

Conversation

haiyang1987 commented Jul 15, 2023

Description of PR

hadoop-yetus commented Jul 15, 2023

slfan1989 commented Jul 16, 2023

haiyang1987 commented Jul 16, 2023

haiyang1987 commented Jul 17, 2023

hadoop-yetus commented Jul 17, 2023

slfan1989 commented Jul 17, 2023

ayushtkn left a comment

Choose a reason for hiding this comment

haiyang1987 commented Jul 18, 2023

haiyang1987 commented Jul 18, 2023

hadoop-yetus commented Jul 18, 2023

ayushtkn left a comment

Choose a reason for hiding this comment

slfan1989 commented Jul 19, 2023

haiyang1987 commented Jul 21, 2023