-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11513: Applications submitted to ambiguous queue fail during recovery if "Specified" Placement Rule is used #5748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: Ic4e5efb7fab323768efe5626dc312d40b4a8a755
💔 -1 overall
This message was automatically generated. |
Thanks @susheel-gupta for the patch. I'm wondering: is there a way to unittest this issue? There are some recovery related tests, i.e in TestWorkPreservingRMRestart, where this might be reproducible. That way it's a bit easier to verify this change. |
Sure, I'll check TestWorkPreservingRMRestart testcases and try to add unit test for this fix. |
Change-Id: I3171a295aae81eae001661a4851ddf839a1db05a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @susheel-gupta for the update. It looks good to me except two minor comments.
...src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestWorkPreservingRMRestart.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestWorkPreservingRMRestart.java
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
Change-Id: I2d0cba550cea35a25dcfd65ed1090525cf539bd1
🎊 +1 overall
This message was automatically generated. |
Thanks @susheel-gupta, merged to trunk. |
Change-Id: Ic4e5efb7fab323768efe5626dc312d40b4a8a755
Description of PR
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?