-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDFS-16958. EC: Fix bug in processing EC excess redundancy. #5489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
@zhangshuyan0 Why did you close this PR? |
@tasanuma Thanks for your comment. I think I was wrong before. The chosen of |
@zhangshuyan0 Thanks for your explanation. So the current implementation is correct? |
@tasanuma Yes, current is correct. |
@zhangshuyan0 Thanks. I will close the jira. |
Description of PR
When processing excess redundancy, the number of internal blocks is computed by traversing
nonExcess
. This way is not accurate, becausenonExcess
excludes replicas in abnormal states, such as corrupt ones, or maintenance ones.numOfTarget
may be smaller than the actual value, which will result in inaccurate generatedexcessTypes
.