Skip to content

HADOOP-18655. Upgrade Kerby to 2.0.3 #5484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: branch-3.3
Choose a base branch
from

Conversation

rohit-kb
Copy link
Contributor

@rohit-kb rohit-kb commented Mar 16, 2023

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 6m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+0 🆗 mvndep 15m 43s Maven dependency ordering for branch
+1 💚 mvninstall 23m 56s branch-3.3 passed
+1 💚 compile 17m 45s branch-3.3 passed
+1 💚 mvnsite 25m 14s branch-3.3 passed
+1 💚 javadoc 7m 0s branch-3.3 passed
+1 💚 shadedclient 29m 28s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 49s Maven dependency ordering for patch
-1 ❌ mvninstall 21m 41s /patch-mvninstall-root.txt root in the patch failed.
+1 💚 compile 17m 23s the patch passed
+1 💚 javac 17m 23s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 20m 41s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 6m 45s the patch passed
+1 💚 shadedclient 30m 20s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 689m 54s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 33s The patch does not generate ASF License warnings.
904m 15s
Reason Tests
Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
hadoop.hdfs.server.mover.TestMover
hadoop.yarn.sls.appmaster.TestAMSimulator
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5484/1/artifact/out/Dockerfile
GITHUB PR #5484
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux 071a2de9f1d1 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / a3ce05a
Default Java Private Build-1.8.0_362-8u362-ga-0ubuntu1~18.04.1-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5484/1/testReport/
Max. process+thread count 3159 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5484/1/console
versions git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

not resolving without a solr update first. either we abandon this patch or whatever solr update went in is backported. That's more intimate with YARN and so they'll need to get involved for their opinions

[INFO] 
[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (depcheck) @ hadoop-yarn-applications-catalog-webapp ---
[WARNING] 
Dependency convergence error for org.apache.kerby:kerb-util:1.0.1 paths to dependency are:
+-org.apache.hadoop:hadoop-yarn-applications-catalog-webapp:3.3.9-SNAPSHOT
  +-org.apache.solr:solr-core:8.8.2
    +-org.apache.kerby:kerb-util:1.0.1
and
+-org.apache.hadoop:hadoop-yarn-applications-catalog-webapp:3.3.9-SNAPSHOT
  +-org.apache.solr:solr-test-framework:8.8.2
    +-org.apache.kerby:kerb-util:1.0.1
and
+-org.apache.hadoop:hadoop-yarn-applications-catalog-webapp:3.3.9-SNAPSHOT
  +-org.apache.hadoop:hadoop-auth:3.3.9-SNAPSHOT
    +-org.apache.kerby:kerb-simplekdc:2.0.3
      +-org.apache.kerby:kerb-client:2.0.3
        +-org.apache.kerby:kerb-util:2.0.3
and
+-org.apache.hadoop:hadoop-yarn-applications-catalog-webapp:3.3.9-SNAPSHOT
  +-org.apache.hadoop:hadoop-auth:3.3.9-SNAPSHOT
    +-org.apache.kerby:kerb-simplekdc:2.0.3
      +-org.apache.kerby:kerb-admin:2.0.3
        +-org.apache.kerby:kerb-util:2.0.3

[WARNING] 
Dependency convergence error for org.apache.kerby:kerby-pkix:1.0.1 paths to dependency are:
+-org.apache.hadoop:hadoop-yarn-applications-catalog-webapp:3.3.9-SNAPSHOT
  +-org.apache.solr:solr-core:8.8.2
    +-org.apache.kerby:kerby-pkix:1.0.1
and
+-org.apache.hadoop:hadoop-yarn-applications-catalog-webapp:3.3.9-SNAPSHOT
  +-org.apache.solr:solr-test-framework:8.8.2
    +-org.apache.kerby:kerby-pkix:1.0.1
and
+-org.apache.hadoop:hadoop-yarn-applications-catalog-webapp:3.3.9-SNAPSHOT
  +-org.apache.hadoop:hadoop-common:3.3.9-SNAPSHOT
    +-org.apache.kerby:kerb-core:2.0.3
      +-org.apache.kerby:kerby-pkix:2.0.3

[WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
Failed while enforcing releasability. See above detailed error message.
[INFO] 

@jojochuang
Copy link
Contributor

The solr version is the same in branch-3.3 and trunk. So we would need to do the same for trunk.

We could possible update Solr to 9.x. Looks like Solr 9 does not depend on Kerby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants