-
Notifications
You must be signed in to change notification settings - Fork 9.1k
[HADOOP-18660] Filesystem Spelling Mistake #5475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some 21 occurrences in the project, do you plan to volunteer fix in one go? Committing one-one occurrence might be too much.
Any IDE should get you sorted in just couple of minutes
Hi Ayushtkn, Will do, once i find a bit of time. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
b2a9038
to
af9c4f5
Compare
💔 -1 overall
This message was automatically generated. |
af9c4f5
to
b7a99e9
Compare
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase this and check if the checkstyle warnings are introduced by this change.
Avoid any unrelated change apart from fixing the typo. If you find some other issues as well, Feel free to create a new ticket and chase them under that
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/troubleshooting_s3a.md
Outdated
Show resolved
Hide resolved
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/troubleshooting_s3a.md
Outdated
Show resolved
Hide resolved
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/troubleshooting_s3a.md
Outdated
Show resolved
Hide resolved
This commit fixes the spelling mistake of Fileystem to Filesystem at various locations in the code base.
b7a99e9
to
1834791
Compare
I do not think the changes still work. since the complaint is from the integration tool that does not like that i changed the name of 2 java files. |
💔 -1 overall
This message was automatically generated. |
I didn't catch that, which integration tool? you have some internal integration tool? We are just changing the name of a test class. Ok, may be just leave that test class as is and do the fix in other places? |
Maybe not the correct wording from my side. to clarify. integration tool -> hadoop-yetus i did not want to call it tests but maybe i should have. especially in this case since it is a test file, and no code is pointing to these files. |
Can you pass me the link or atleast attach a screenshot where Yetus is complaining about the file name change? I am not able to follow that. The only complain I see is around checkstyle: |
Okay, maybe i was to quick again... But the latest run did not do it, and nothing really changed, so IDK. |
That error seems to say like you changed the class name but not the file name. Just fix the checkstyle warning and we should be good to go |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
Contributed by Sebastian Baunsgaard. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
ok, merged to branch-3.3 too. looks suspiciously like most of the errors are mine, which is less spelling than typo. never mind. At least the only classname errors in were in test code so no risk when moving |
Minor spelling mistake in errors returned from Filesystem.
Description of PR
minor change.
How was this patch tested?
it was not but the change is only touching the logging.
For code changes: