You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira: YARN-11449
Accessing "QueueNodeLabelsSettings#accessibleLabels" can cause NPE without ReadLock (writes to this variable is happening with write lock).
Since QueueNodeLabelsSettings.getAccessibleNodeLabels() can return null and If someone accesses QueueNodeLabelsSettings##accessibleLabels before assigning it from the parent can cause NPE.
The issue was found in 2.10
How was this patch tested?
Unit Tested
For code changes:
[✅] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?
slfan1989
changed the title
Fix for Intermittent NPE while getting node labels for queue
YARN-11449. Fix for Intermittent NPE while getting node labels for queue
Mar 9, 2023
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚
mvninstall
39m 30s
trunk passed
+1 💚
compile
1m 5s
trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚
compile
1m 0s
trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚
checkstyle
0m 51s
trunk passed
+1 💚
mvnsite
1m 4s
trunk passed
+1 💚
javadoc
0m 58s
trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚
javadoc
0m 45s
trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚
spotbugs
2m 10s
trunk passed
+1 💚
shadedclient
21m 30s
branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚
mvninstall
0m 53s
the patch passed
+1 💚
compile
0m 58s
the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚
javac
0m 58s
the patch passed
+1 💚
compile
0m 51s
the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚
javac
0m 51s
the patch passed
+1 💚
blanks
0m 0s
The patch has no blanks issues.
+1 💚
checkstyle
0m 39s
the patch passed
+1 💚
mvnsite
0m 53s
the patch passed
+1 💚
javadoc
0m 40s
the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚
javadoc
0m 37s
the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚
spotbugs
1m 56s
the patch passed
+1 💚
shadedclient
21m 8s
patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚
unit
102m 14s
hadoop-yarn-server-resourcemanager in the patch passed.
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Jira: YARN-11449
Accessing "QueueNodeLabelsSettings#accessibleLabels" can cause NPE without ReadLock (writes to this variable is happening with write lock).
Since QueueNodeLabelsSettings.getAccessibleNodeLabels() can return null and If someone accesses QueueNodeLabelsSettings##accessibleLabels before assigning it from the parent can cause NPE.
The issue was found in 2.10
How was this patch tested?
Unit Tested
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?