HADOOP-14630 Contract Tests to verify create, mkdirs and rename under a file is forbidden #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -524,9 +524,17 @@ Create a directory and all its parents | |||
| #### Preconditions | |||
|
|
|||
|
|
|||
| The path must either be a directory or not exist | |||
|
|
|||
| if exists(FS, p) and not isDir(FS, p) : | ||
| raise [ParentNotDirectoryException, FileAlreadyExistsException, IOException] | ||
|
|
||
| No ancestor may be a file | ||
|
|
||
| forall d = ancestors(FS, p) : |
| forall d = ancestors(FS, p) : | ||
| if exists(FS, d) and not isDir(FS, d) : | ||
| raise [ParentNotDirectoryException, FileAlreadyExistsException, IOException] | ||
|
|
| @@ -566,6 +574,12 @@ Writing to or overwriting a directory must fail. | |||
|
|
|||
| if isDir(FS, p) : raise {FileAlreadyExistsException, FileNotFoundException, IOException} | |||
|
|
|||
| No ancestor may be a file | |||
|
|
|||
| forall d = ancestors(FS, p) : | |||
| forall d = ancestors(FS, p) : | ||
| if exists(FS, d) and not isDir(FS, d) : | ||
| raise [ParentNotDirectoryException, FileAlreadyExistsException, IOException] | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
steveloughran
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
Whitespace is from an error file. I deny (direct) responsibility |
steveloughran
force-pushed
the
filesystem/HADOOP-14630-create-under-file
branch
from
10fd31d to
2615fb3
Compare
hadoop-yetus
reviewed
Mar 9, 2019
| @@ -524,9 +524,17 @@ Create a directory and all its parents | |||
| #### Preconditions | |||
|
|
|||
|
|
|||
| The path must either be a directory or not exist | |||
|
|
|||
hadoop-yetus
reviewed
Mar 9, 2019
| if exists(FS, p) and not isDir(FS, p) : | ||
| raise [ParentNotDirectoryException, FileAlreadyExistsException, IOException] | ||
|
|
||
| No ancestor may be a file | ||
|
|
||
| forall d = ancestors(FS, p) : |
hadoop-yetus
reviewed
Mar 9, 2019
| forall d = ancestors(FS, p) : | ||
| if exists(FS, d) and not isDir(FS, d) : | ||
| raise [ParentNotDirectoryException, FileAlreadyExistsException, IOException] | ||
|
|
hadoop-yetus
reviewed
Mar 9, 2019
| @@ -566,6 +574,12 @@ Writing to or overwriting a directory must fail. | |||
|
|
|||
| if isDir(FS, p) : raise {FileAlreadyExistsException, FileNotFoundException, IOException} | |||
|
|
|||
| No ancestor may be a file | |||
|
|
|||
| forall d = ancestors(FS, p) : | |||
hadoop-yetus
reviewed
Mar 9, 2019
| forall d = ancestors(FS, p) : | ||
| if exists(FS, d) and not isDir(FS, d) : | ||
| raise [ParentNotDirectoryException, FileAlreadyExistsException, IOException] | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
steveloughran
added
the
failed
| @@ -524,9 +524,17 @@ Create a directory and all its parents | |||
| #### Preconditions | |||
|
|
|||
|
|
|||
| The path must either be a directory or not exist | |||
|
|
|||
| if exists(FS, p) and not isDir(FS, p) : | ||
| raise [ParentNotDirectoryException, FileAlreadyExistsException, IOException] | ||
|
|
||
| No ancestor may be a file | ||
|
|
||
| forall d = ancestors(FS, p) : |
| forall d = ancestors(FS, p) : | ||
| if exists(FS, d) and not isDir(FS, d) : | ||
| raise [ParentNotDirectoryException, FileAlreadyExistsException, IOException] | ||
|
|
| @@ -566,6 +574,12 @@ Writing to or overwriting a directory must fail. | |||
|
|
|||
| if isDir(FS, p) : raise {FileAlreadyExistsException, FileNotFoundException, IOException} | |||
|
|
|||
| No ancestor may be a file | |||
|
|
|||
| forall d = ancestors(FS, p) : | |||
| forall d = ancestors(FS, p) : | ||
| if exists(FS, d) and not isDir(FS, d) : | ||
| raise [ParentNotDirectoryException, FileAlreadyExistsException, IOException] | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
… a file is forbidden
…nting createNonRecursive Change-Id: If826ad1d893c8c9733d6259cb5d7e4d986df49e4
…leSystemMetricsSystem; intermittent failure during testing Change-Id: I884de58f555908fbd867f82a078e04bf86849413
…ion if the direct parent is a file Change-Id: Id53f1245068a078d682c37391b618b9de64db52a
this has happened in 2 places now; I'm going to make it something which stores can declare they do Change-Id: I60aa2d68cd2f9f2e511972b6c799d10348d82578
…d a new switch to allow filesystems to delcare they permit this. S3A contact XML adds the flag; Swift does not -it does check, at a cost in performance. Change-Id: Ifd40c6a58f6ac8cc9eeb83168e0449de59313dfd tested: s3a, abfs, swift. my ADL login is no longer valid.
steveloughran
force-pushed
the
filesystem/HADOOP-14630-create-under-file
branch
from
2615fb3 to
fac64e5
Compare
|
|
||
| #### Preconditions | ||
|
|
||
|
|
||
| The path must either be a directory or not exist | ||
|
|
| if exists(FS, p) and not isDir(FS, p) : | ||
| raise [ParentNotDirectoryException, FileAlreadyExistsException, IOException] | ||
|
|
||
| No ancestor may be a file | ||
|
|
||
| forall d = ancestors(FS, p) : |
| @@ -577,14 +584,20 @@ Writing to or overwriting a directory must fail. | |||
|
|
|||
| if isDir(FS, p) : raise {FileAlreadyExistsException, FileNotFoundException, IOException} | |||
|
|
|||
| No ancestor may be a file | |||
|
|
|||
| forall d = ancestors(FS, p) : | |||
|
💔 -1 overall
This message was automatically generated. |
|
|
||
| #### Preconditions | ||
|
|
||
|
|
||
| The path must either be a directory or not exist | ||
|
|
| if exists(FS, p) and not isDir(FS, p) : | ||
| raise [ParentNotDirectoryException, FileAlreadyExistsException, IOException] | ||
|
|
||
| No ancestor may be a file | ||
|
|
||
| forall d = ancestors(FS, p) : |
| @@ -577,14 +584,20 @@ Writing to or overwriting a directory must fail. | |||
|
|
|||
| if isDir(FS, p) : raise {FileAlreadyExistsException, FileNotFoundException, IOException} | |||
|
|
|||
| No ancestor may be a file | |||
|
|
|||
| forall d = ancestors(FS, p) : | |||
|
💔 -1 overall
This message was automatically generated. |
hadoop-yetus
reviewed
Sep 3, 2019
|
|
||
| #### Preconditions | ||
|
|
||
|
|
||
| The path must either be a directory or not exist | ||
|
|
hadoop-yetus
reviewed
Sep 3, 2019
| if exists(FS, p) and not isDir(FS, p) : | ||
| raise [ParentNotDirectoryException, FileAlreadyExistsException, IOException] | ||
|
|
||
| No ancestor may be a file | ||
|
|
||
| forall d = ancestors(FS, p) : |
hadoop-yetus
reviewed
Sep 3, 2019
| @@ -577,14 +584,20 @@ Writing to or overwriting a directory must fail. | |||
|
|
|||
| if isDir(FS, p) : raise {FileAlreadyExistsException, FileNotFoundException, IOException} | |||
|
|
|||
| No ancestor may be a file | |||
|
|
|||
| forall d = ancestors(FS, p) : | |||
|
💔 -1 overall
This message was automatically generated. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…g partition while choosing. Author: Aditya Toomula <atoomula@linkedin.com> Reviewers: Jagadish<jagadish@apache.org> Closes apache#533 from atoomula/chooser
liuml07
approved these changes
Mar 7, 2020
| expectMkdirsUnderFileFails("mkdirs() file/dir", | ||
| grandparent, child); | ||
|
|
||
| try { |
There was a problem hiding this comment.
Do we need another mkdirs(child) test here? I thought it's already tested in above expectMkdirsUnderFileFails().
Is this for verbose logging output? I mean,
handleRelaxedException(action,
"ParentNotDirectoryException",
e);
v.s.
handleRelaxedException("creating a file under a subdirectory of a file ",
"FileAlreadyExistsException",
e);
There was a problem hiding this comment.
just being curious about deeper creation .. those object stores are so troublesome here
There was a problem hiding this comment.
Yes I think this test testMkdirUnderFileSubdir makes perfect sense. In this test, I was assuming the whole try-catch clause is having the same logic (except exception handling) as the call to expectMkdirsUnderFileFails() in LoC 376 in this method.
|
thx for the merge -no obvious issues with a backport |
|
merged; closing. Thanks for looking @ this |
liuml07
removed
the
failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HADOOP-14630. Contract Tests to verify create, mkdirs and rename under a file is forbidden