Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-1191. Replace Ozone Rest client with S3 client in smoketests and docs #529

Closed
wants to merge 1 commit into from

Conversation

elek
Copy link
Member

@elek elek commented Feb 28, 2019

As it's discussed in the the parent jira the rest support for Ozone Client protocol can be removed to use S3 Rest API instead of that.

Some of the unit tests are already disabled, so it seems to be better to remove it from the documentation (and from the smoketests).

See: https://issues.apache.org/jira/browse/HDDS-1191

@elek elek added the ozone label Feb 28, 2019
to using the REST protocol instead of RPC.
If no protocol is specified, the Ozone shell defaults to the native RPC
protocol.
1. Scheme - This should be `o3` which is the native RPC protocol to access

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:end of line

Ozone ships with its own client library that supports both RPC (Remote
Procedure Call) and REST (Representational State Transfer). This library is
the primary user interface to ozone.
Ozone ships with its own client library that supports RPC. For generic use cases the S3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:end of line

Procedure Call) and REST (Representational State Transfer). This library is
the primary user interface to ozone.
Ozone ships with its own client library that supports RPC. For generic use cases the S3
compatible REST interface also can be used instead of the Ozone client.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:end of line

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 36 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 58 Maven dependency ordering for branch
+1 mvninstall 1088 trunk passed
+1 compile 928 trunk passed
-1 mvnsite 113 dist in trunk failed.
+1 shadedclient 2921 branch has no errors when building and testing our client artifacts.
+1 javadoc 46 trunk passed
_ Patch Compile Tests _
0 mvndep 24 Maven dependency ordering for patch
-1 mvninstall 17 dist in the patch failed.
+1 compile 902 the patch passed
+1 javac 902 the patch passed
-1 mvnsite 28 dist in the patch failed.
-1 whitespace 0 The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 shadedclient 599 patch has no errors when building and testing our client artifacts.
+1 javadoc 43 the patch passed
_ Other Tests _
+1 unit 26 docs in the patch passed.
-1 unit 28 dist in the patch failed.
+1 asflicense 38 The patch does not generate ASF License warnings.
4924
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/artifact/out/Dockerfile
GITHUB PR #529
Optional Tests dupname asflicense mvnsite compile javac javadoc mvninstall unit shadedclient
uname Linux 07ed38007244 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 538bb48
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/artifact/out/branch-mvnsite-hadoop-ozone_dist.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/artifact/out/patch-mvnsite-hadoop-ozone_dist.txt
whitespace https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/artifact/out/whitespace-eol.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/artifact/out/patch-unit-hadoop-ozone_dist.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/testReport/
Max. process+thread count 411 (vs. ulimit of 5500)
modules C: hadoop-hdds/docs hadoop-ozone/dist U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@anuengineer
Copy link
Contributor

👍 I will commit this soon.

@elek elek closed this Mar 1, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Jira: SAMZA-1722: https://issues.apache.org/jira/browse/SAMZA-1722

Author: sanil15 <sanil.jain15@gmail.com>

Reviewers: Prateek Maheshwari <pmaheshwari@apache.org>

Closes apache#529 from Sanil15/SAMZA-1722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants