HDDS-623. On SCM UI, Node Manager info is empty #523

elek · 2019-02-27T14:35:08Z

Fields like below are empty

Node Manager: Minimum chill mode nodes
Node Manager: Out-of-node chill mode
Node Manager: Chill mode status
Node Manager: Manual chill mode

Please see attached screenshot !Screen Shot 2018-10-10 at 4.19.59 PM.png!

See: https://issues.apache.org/jira/browse/HDDS-623

hadoop-yetus · 2019-02-27T15:29:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	30	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1027	trunk passed
+1	compile	46	trunk passed
+1	mvnsite	34	trunk passed
+1	shadedclient	1769	branch has no errors when building and testing our client artifacts.
+1	javadoc	25	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	33	the patch passed
+1	compile	26	the patch passed
+1	javac	26	the patch passed
+1	mvnsite	28	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	746	patch has no errors when building and testing our client artifacts.
+1	javadoc	23	the patch passed
		_ Other Tests _
-1	unit	102	server-scm in the patch failed.
+1	asflicense	28	The patch does not generate ASF License warnings.
		2940

Reason	Tests
Failed junit tests	hadoop.hdds.scm.block.TestBlockManager

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-523/1/artifact/out/Dockerfile
GITHUB PR	#523
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient
uname	Linux 81a86b7df65c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `6c8c422`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-523/1/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-523/1/testReport/
Max. process+thread count	446 (vs. ulimit of 5500)
modules	C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-523/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

bharatviswa504 · 2019-02-28T21:42:10Z

+1 LGTM. (Not a frontend guy, but as this is not adding any code, so had taken a look at it)

But one more thing I have observed is
Block Manager: Open containers this is also broken, as currently in the code we have a TODO for this
in BlockManagerImpl.java

This also needs to be fixed.

 @Override
  public int getOpenContainersNo() {
    return 0;
    // TODO : FIX ME : The open container being a single number does not make
    // sense.
    // We have to get open containers by Replication Type and Replication
    // factor. Hence returning 0 for now.
    // containers.get(HddsProtos.LifeCycleState.OPEN).size();
  }

elek · 2019-03-01T16:35:33Z

Yup. Nice catch, thank you. I removed that line, too.

hadoop-yetus · 2019-03-01T17:14:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	36	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
-1	mvninstall	396	root in trunk failed.
-1	compile	22	server-scm in trunk failed.
+1	mvnsite	44	trunk passed
+1	shadedclient	1097	branch has no errors when building and testing our client artifacts.
+1	javadoc	23	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	32	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
+1	mvnsite	27	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	749	patch has no errors when building and testing our client artifacts.
+1	javadoc	18	the patch passed
		_ Other Tests _
+1	unit	152	server-scm in the patch passed.
+1	asflicense	27	The patch does not generate ASF License warnings.
		2306

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-523/2/artifact/out/Dockerfile
GITHUB PR	#523
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient
uname	Linux a7cf3f31e092 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / dcaca19
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-523/2/artifact/out/branch-mvninstall-root.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-523/2/artifact/out/branch-compile-hadoop-hdds_server-scm.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-523/2/testReport/
Max. process+thread count	576 (vs. ulimit of 5500)
modules	C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-523/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

bharatviswa504 · 2019-03-01T22:15:36Z

Sorry missed in my earlier review, we need to remove below code from scm.js

   var ctrl = this;
            $http.get("jmx?qry=Hadoop:service=BlockManager,name=*")
                .then(function (result) {
                    ctrl.blockmanagermetrics = result.data.beans[0];
                });
            $http.get("jmx?qry=Hadoop:service=SCMNodeManager,name=SCMNodeManagerInfo")
                .then(function (result) {
                    ctrl.nodemanagermetrics = result.data.beans[0];
                });

bharatviswa504

Need to update scm.js also to remove few parts of code.

elek · 2019-03-04T14:44:50Z

nodemanagermetrics is still required as it's used in the scm-overview.html (NodeCount)

blockmanagermetrics can be removed and I removed it in the last commit.

… Marton.

hadoop-yetus · 2019-03-04T16:26:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	25	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	964	trunk passed
+1	compile	44	trunk passed
+1	mvnsite	30	trunk passed
+1	shadedclient	750	branch has no errors when building and testing our client artifacts.
+1	javadoc	18	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	31	the patch passed
-1	jshint	65	The patch generated 293 new + 1954 unchanged - 1053 fixed = 2247 total (was 3007)
+1	compile	24	the patch passed
+1	javac	24	the patch passed
+1	mvnsite	25	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	733	patch has no errors when building and testing our client artifacts.
+1	javadoc	18	the patch passed
		_ Other Tests _
+1	unit	145	server-scm in the patch passed.
+1	asflicense	25	The patch does not generate ASF License warnings.
		2897

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-523/3/artifact/out/Dockerfile
GITHUB PR	#523
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient jshint
uname	Linux e8c4c580a94b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 15098df
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
jshint	https://builds.apache.org/job/hadoop-multibranch/job/PR-523/3/artifact/out/diff-patch-jshint.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-523/3/testReport/
Max. process+thread count	577 (vs. ulimit of 5500)
modules	C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-523/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

bharatviswa504 · 2019-03-04T16:53:14Z

yes, we still need nodemetrics.
+1 LGTM.

ajayydv · 2019-03-04T22:34:44Z

+1

* HDDS-623. On SCM UI, Node Manager info is empty. Contributed by Elek, Marton. (cherry picked from commit 90c37ac)

Test locally and works. Author: Yi Pan (Data Infrastructure) <yipan@yipan-mn1.linkedin.biz> Reviewers: Jagadish <jagadish@apache.org> Closes apache#523 from nickpan47/fix-unittest-deleted-messages

elek added the ozone label Feb 27, 2019

arp7 assigned bharatviswa504 Feb 28, 2019

bharatviswa504 self-requested a review February 28, 2019 21:42

bharatviswa504 assigned elek and unassigned bharatviswa504 Feb 28, 2019

bharatviswa504 reviewed Mar 1, 2019

View reviewed changes

elek added 3 commits March 4, 2019 15:45

HDDS-623. On SCM UI, Node Manager info is empty. Contributed by Elek,…

59f7789

… Marton.

remove open container numbers as they are not implemented

dfea413

remove blockmanagermetrics

0ce232b

elek force-pushed the HDDS-623 branch from 6c5af2c to 0ce232b Compare March 4, 2019 14:45

ajayydv merged commit 90c37ac into apache:trunk Mar 4, 2019

asfgit pushed a commit that referenced this pull request Mar 5, 2019

HDDS-623. On SCM UI, Node Manager info is empty (#523)

f4918ac

* HDDS-623. On SCM UI, Node Manager info is empty. Contributed by Elek, Marton. (cherry picked from commit 90c37ac)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDDS-623. On SCM UI, Node Manager info is empty #523

HDDS-623. On SCM UI, Node Manager info is empty #523

Uh oh!

elek commented Feb 27, 2019

Uh oh!

hadoop-yetus commented Feb 27, 2019

Uh oh!

bharatviswa504 commented Feb 28, 2019

Uh oh!

elek commented Mar 1, 2019

Uh oh!

hadoop-yetus commented Mar 1, 2019

Uh oh!

bharatviswa504 commented Mar 1, 2019

Uh oh!

bharatviswa504 left a comment

Uh oh!

elek commented Mar 4, 2019

Uh oh!

hadoop-yetus commented Mar 4, 2019

Uh oh!

bharatviswa504 commented Mar 4, 2019

Uh oh!

ajayydv commented Mar 4, 2019

Uh oh!

Uh oh!

HDDS-623. On SCM UI, Node Manager info is empty #523

HDDS-623. On SCM UI, Node Manager info is empty #523

Uh oh!

Conversation

elek commented Feb 27, 2019

Uh oh!

hadoop-yetus commented Feb 27, 2019

Uh oh!

bharatviswa504 commented Feb 28, 2019

Uh oh!

elek commented Mar 1, 2019

Uh oh!

hadoop-yetus commented Mar 1, 2019

Uh oh!

bharatviswa504 commented Mar 1, 2019

Uh oh!

bharatviswa504 left a comment

Choose a reason for hiding this comment

Uh oh!

elek commented Mar 4, 2019

Uh oh!

hadoop-yetus commented Mar 4, 2019

Uh oh!

bharatviswa504 commented Mar 4, 2019

Uh oh!

ajayydv commented Mar 4, 2019

Uh oh!

Uh oh!