-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11393. Fs2cs could be extended to set ULF to -1 upon conversion #5201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
Change-Id: Ia576cf1c71fee2b80725f2e60f91cd3174640653
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@susheel-gupta thanks for the patch! I've had one comment on it.
...hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSConfigToCSConfigConverter.java
Outdated
Show resolved
Hide resolved
...op/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigConverter.java
Outdated
Show resolved
Hide resolved
… disabled Change-Id: I99f62b9c4f40027689f2953bb4be946e23261ae5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @susheel-gupta for the update. I had two comments.
...hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSConfigToCSConfigConverter.java
Outdated
Show resolved
Hide resolved
...op/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigConverter.java
Outdated
Show resolved
Hide resolved
💔 -1 overall
This message was automatically generated. |
Change-Id: Ife4762de43fd21924d2b481502580e74a8242d83
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @susheel-gupta for the update! I've requested 2 small changes, with those implemented the patch should be ok :)
...hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSConfigToCSConfigConverter.java
Outdated
Show resolved
Hide resolved
...org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSQueueConverter.java
Outdated
Show resolved
Hide resolved
💔 -1 overall
This message was automatically generated. |
Change-Id: I79bdb749c2ce2db1b37cdc4813f6b8527d057fb0
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @susheel-gupta, the latest patch LGTM. Merged to trunk.
Description of PR
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?