Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-1120. Add a config to disable checksum verification during read … #513

Merged
merged 2 commits into from
Feb 24, 2019
Merged

HDDS-1120. Add a config to disable checksum verification during read … #513

merged 2 commits into from
Feb 24, 2019

Conversation

bharatviswa504
Copy link
Contributor

…even though checksum data is present in the persisted data.

@bharatviswa504 bharatviswa504 self-assigned this Feb 21, 2019
@apache-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 29 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
0 mvndep 164 Maven dependency ordering for branch
+1 mvninstall 1085 trunk passed
+1 compile 1046 trunk passed
+1 checkstyle 192 trunk passed
-1 mvnsite 32 client in trunk failed.
-1 mvnsite 26 client in trunk failed.
-1 mvnsite 27 integration-test in trunk failed.
-1 mvnsite 22 objectstore-service in trunk failed.
-1 mvnsite 22 ozone-manager in trunk failed.
-1 shadedclient 1092 branch has errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
-1 findbugs 22 client in trunk failed.
-1 findbugs 20 client in trunk failed.
-1 findbugs 23 objectstore-service in trunk failed.
-1 findbugs 26 ozone-manager in trunk failed.
-1 javadoc 31 client in trunk failed.
-1 javadoc 19 client in trunk failed.
-1 javadoc 21 integration-test in trunk failed.
-1 javadoc 25 objectstore-service in trunk failed.
-1 javadoc 22 ozone-manager in trunk failed.
_ Patch Compile Tests _
0 mvndep 23 Maven dependency ordering for patch
-1 mvninstall 9 client in the patch failed.
-1 mvninstall 13 client in the patch failed.
-1 mvninstall 11 integration-test in the patch failed.
-1 mvninstall 11 objectstore-service in the patch failed.
-1 mvninstall 11 ozone-manager in the patch failed.
+1 compile 896 the patch passed
+1 javac 896 the patch passed
+1 checkstyle 186 the patch passed
-1 mvnsite 30 client in the patch failed.
-1 mvnsite 34 client in the patch failed.
-1 mvnsite 29 integration-test in the patch failed.
-1 mvnsite 28 objectstore-service in the patch failed.
-1 mvnsite 28 ozone-manager in the patch failed.
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 639 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
-1 findbugs 25 client in the patch failed.
-1 findbugs 20 client in the patch failed.
-1 findbugs 26 objectstore-service in the patch failed.
-1 findbugs 22 ozone-manager in the patch failed.
-1 javadoc 24 client in the patch failed.
-1 javadoc 28 client in the patch failed.
-1 javadoc 19 integration-test in the patch failed.
-1 javadoc 20 objectstore-service in the patch failed.
-1 javadoc 21 ozone-manager in the patch failed.
_ Other Tests _
-1 unit 18 client in the patch failed.
-1 unit 72 common in the patch failed.
-1 unit 26 client in the patch failed.
-1 unit 26 integration-test in the patch failed.
-1 unit 26 objectstore-service in the patch failed.
-1 unit 27 ozone-manager in the patch failed.
+1 asflicense 49 The patch does not generate ASF License warnings.
6636
Reason Tests
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/Dockerfile
GITHUB PR #513
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux b57bbaf70983 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / b17a260
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-mvnsite-hadoop-hdds_client.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-mvnsite-hadoop-ozone_client.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-mvnsite-hadoop-ozone_objectstore-service.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugs v3.1.0-RC1
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-findbugs-hadoop-hdds_client.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-findbugs-hadoop-ozone_client.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-findbugs-hadoop-ozone_objectstore-service.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-javadoc-hadoop-hdds_client.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-javadoc-hadoop-ozone_client.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-javadoc-hadoop-ozone_integration-test.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-javadoc-hadoop-ozone_objectstore-service.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-javadoc-hadoop-ozone_ozone-manager.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvninstall-hadoop-hdds_client.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvninstall-hadoop-ozone_client.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvninstall-hadoop-ozone_objectstore-service.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvninstall-hadoop-ozone_ozone-manager.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvnsite-hadoop-hdds_client.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvnsite-hadoop-ozone_client.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvnsite-hadoop-ozone_integration-test.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvnsite-hadoop-ozone_objectstore-service.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-findbugs-hadoop-hdds_client.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-findbugs-hadoop-ozone_client.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-findbugs-hadoop-ozone_objectstore-service.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-findbugs-hadoop-ozone_ozone-manager.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-javadoc-hadoop-hdds_client.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-javadoc-hadoop-ozone_client.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-javadoc-hadoop-ozone_integration-test.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-javadoc-hadoop-ozone_objectstore-service.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-javadoc-hadoop-ozone_ozone-manager.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-unit-hadoop-hdds_client.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-unit-hadoop-hdds_common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-unit-hadoop-ozone_client.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-unit-hadoop-ozone_objectstore-service.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/testReport/
Max. process+thread count 444 (vs. ulimit of 5500)
modules C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/client hadoop-ozone/integration-test hadoop-ozone/objectstore-service hadoop-ozone/ozone-manager U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@apache-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 23 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
0 mvndep 23 Maven dependency ordering for branch
+1 mvninstall 1004 trunk passed
+1 compile 933 trunk passed
+1 checkstyle 190 trunk passed
-1 mvnsite 39 client in trunk failed.
-1 mvnsite 25 client in trunk failed.
-1 mvnsite 25 integration-test in trunk failed.
-1 mvnsite 21 objectstore-service in trunk failed.
-1 mvnsite 18 ozone-manager in trunk failed.
+1 shadedclient 1040 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
-1 findbugs 20 client in trunk failed.
-1 findbugs 20 client in trunk failed.
-1 findbugs 17 objectstore-service in trunk failed.
-1 findbugs 16 ozone-manager in trunk failed.
-1 javadoc 19 client in trunk failed.
-1 javadoc 21 client in trunk failed.
-1 javadoc 22 integration-test in trunk failed.
-1 javadoc 18 objectstore-service in trunk failed.
-1 javadoc 20 ozone-manager in trunk failed.
_ Patch Compile Tests _
0 mvndep 23 Maven dependency ordering for patch
-1 mvninstall 9 client in the patch failed.
-1 mvninstall 10 client in the patch failed.
-1 mvninstall 10 integration-test in the patch failed.
-1 mvninstall 10 objectstore-service in the patch failed.
-1 mvninstall 11 ozone-manager in the patch failed.
+1 compile 908 the patch passed
+1 javac 908 the patch passed
+1 checkstyle 185 the patch passed
-1 mvnsite 27 client in the patch failed.
-1 mvnsite 28 client in the patch failed.
-1 mvnsite 27 integration-test in the patch failed.
-1 mvnsite 27 objectstore-service in the patch failed.
-1 mvnsite 27 ozone-manager in the patch failed.
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 670 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
-1 findbugs 27 client in the patch failed.
-1 findbugs 29 client in the patch failed.
-1 findbugs 27 objectstore-service in the patch failed.
-1 findbugs 28 ozone-manager in the patch failed.
-1 javadoc 28 client in the patch failed.
-1 javadoc 28 client in the patch failed.
-1 javadoc 27 integration-test in the patch failed.
-1 javadoc 29 objectstore-service in the patch failed.
-1 javadoc 27 ozone-manager in the patch failed.
_ Other Tests _
-1 unit 28 client in the patch failed.
-1 unit 86 common in the patch failed.
-1 unit 27 client in the patch failed.
-1 unit 27 integration-test in the patch failed.
-1 unit 28 objectstore-service in the patch failed.
-1 unit 28 ozone-manager in the patch failed.
+1 asflicense 47 The patch does not generate ASF License warnings.
6289
Reason Tests
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/Dockerfile
GITHUB PR #513
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux e71be91c9703 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / ed13cf8
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-mvnsite-hadoop-hdds_client.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-mvnsite-hadoop-ozone_client.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-mvnsite-hadoop-ozone_objectstore-service.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugs v3.1.0-RC1
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-findbugs-hadoop-hdds_client.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-findbugs-hadoop-ozone_client.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-findbugs-hadoop-ozone_objectstore-service.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-javadoc-hadoop-hdds_client.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-javadoc-hadoop-ozone_client.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-javadoc-hadoop-ozone_integration-test.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-javadoc-hadoop-ozone_objectstore-service.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-javadoc-hadoop-ozone_ozone-manager.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvninstall-hadoop-hdds_client.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvninstall-hadoop-ozone_client.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvninstall-hadoop-ozone_objectstore-service.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvninstall-hadoop-ozone_ozone-manager.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvnsite-hadoop-hdds_client.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvnsite-hadoop-ozone_client.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvnsite-hadoop-ozone_integration-test.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvnsite-hadoop-ozone_objectstore-service.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-findbugs-hadoop-hdds_client.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-findbugs-hadoop-ozone_client.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-findbugs-hadoop-ozone_objectstore-service.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-findbugs-hadoop-ozone_ozone-manager.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-javadoc-hadoop-hdds_client.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-javadoc-hadoop-ozone_client.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-javadoc-hadoop-ozone_integration-test.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-javadoc-hadoop-ozone_objectstore-service.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-javadoc-hadoop-ozone_ozone-manager.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-unit-hadoop-hdds_client.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-unit-hadoop-hdds_common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-unit-hadoop-ozone_client.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-unit-hadoop-ozone_objectstore-service.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/testReport/
Max. process+thread count 411 (vs. ulimit of 5500)
modules C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/client hadoop-ozone/integration-test hadoop-ozone/objectstore-service hadoop-ozone/ozone-manager U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504 bharatviswa504 merged commit 106bdc6 into apache:trunk Feb 24, 2019
@bharatviswa504 bharatviswa504 deleted the HDDS-1120 branch February 24, 2019 05:38
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@prateekm @xinyuiscool
Fixed test failure for TestRocksDbKeyValueStoreJava#testIterate
345f9f2 
RocksDB Snapshots and any iterators obtained from them need to be closed before the store is closed.

Otherwise the process aborts with the following message (at least on OSX):
`Assertion failed: (is_last_reference), function ~ColumnFamilyData, file db/column_family.cc, line 457.`

Author: Prateek Maheshwari <pmaheshw@linkedin.com>

Reviewers: Jagadish V <vjagadish1989@gmail.com>

Closes apache#513 from prateekm/rocksdb-test-fi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bharatviswa504 bharatviswa504

Labels
ozone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bharatviswa504 @apache-yetus