Skip to content

HDDS-1158. TestOzoneManagerHA.testTwoOMNodesDown is failing with ratis error. #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2019
Merged

HDDS-1158. TestOzoneManagerHA.testTwoOMNodesDown is failing with ratis error. #512

merged 1 commit into from
Feb 23, 2019

Conversation

hanishakoneru
Copy link
Contributor

Fixes failing test TestOzoneManagerHA#testTwoOMNodesDown()

@apache-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 25 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1193 trunk passed
-1 compile 34 integration-test in trunk failed.
-0 checkstyle 10 The patch fails to run checkstyle in integration-test
-1 mvnsite 12 integration-test in trunk failed.
+1 shadedclient 628 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 0 trunk passed
-1 javadoc 13 integration-test in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 9 integration-test in the patch failed.
-1 compile 9 integration-test in the patch failed.
-1 javac 9 integration-test in the patch failed.
-0 checkstyle 7 The patch fails to run checkstyle in integration-test
-1 mvnsite 9 integration-test in the patch failed.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 697 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 0 the patch passed
-1 javadoc 14 integration-test in the patch failed.
_ Other Tests _
-1 unit 12 integration-test in the patch failed.
+1 asflicense 25 The patch does not generate ASF License warnings.
2786
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/Dockerfile
GITHUB PR #512
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a13b17ebb2b0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / b17a260
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/branch-compile-hadoop-ozone_integration-test.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out//testptch/patchprocess/maven-branch-checkstyle-hadoop-ozone_integration-test.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/branch-javadoc-hadoop-ozone_integration-test.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/patch-compile-hadoop-ozone_integration-test.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/patch-compile-hadoop-ozone_integration-test.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out//testptch/patchprocess/maven-patch-checkstyle-hadoop-ozone_integration-test.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/patch-mvnsite-hadoop-ozone_integration-test.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/patch-javadoc-hadoop-ozone_integration-test.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/testReport/
Max. process+thread count 446 (vs. ulimit of 5500)
modules C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504
Copy link
Contributor

I am +1 with the change.
Will commit it shortly.

@bharatviswa504 bharatviswa504 merged commit d0e21ac into apache:trunk Feb 23, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@cameronlee314 @xinyuiscool
SAMZA-1709: Use lazy creation for SystemAdmins in ApplicationRunners
7fc39e5 
An instance of SystemAdmins is created when instantiating any AbstractApplicationRunner, but the SystemAdmins is only actually needed for some of the methods for some of the runners. For example, LocalApplicationRunner.kill does not need SystemAdmins, and LocalContainerRunner does not need SystemAdmins for anything.
Doing lazy instantiation allows us to more easily manage the SystemAdmins lifecycle, since it removes the need to add lifecycle hooks for the ApplicationRunner.
This also fixes the lifecycle management for SystemAdmins in ApplicationRunners.

Author: Cameron Lee <calee@linkedin.com>

Reviewers: Xinyu Liu <xinyu@apache.org>

Closes apache#512 from cameronlee314/runnner_system_admins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatviswa504 bharatviswa504 bharatviswa504 left review comments

Assignees
No one assigned
Labels
ozone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanishakoneru @apache-yetus @bharatviswa504