[HDFS-14295] Add CachedThreadPool for DataNode Transfers #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

belugabehr wants to merge 1 commit into apache:trunk from belugabehr:HDFS-14295

Contributor

belugabehr commented Feb 18, 2019

No description provided.

belugabehr force-pushed the HDFS-14295 branch from 4e62323 to cfcc16e Compare

February 26, 2019 19:46

hadoop-yetus commented Feb 26, 2019

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	24	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1099	trunk passed
+1	compile	61	trunk passed
+1	checkstyle	54	trunk passed
+1	mvnsite	66	trunk passed
+1	shadedclient	804	branch has no errors when building and testing our client artifacts.
+1	findbugs	126	trunk passed
+1	javadoc	49	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	59	the patch passed
+1	compile	57	the patch passed
+1	javac	57	the patch passed
+1	checkstyle	53	the patch passed
+1	mvnsite	64	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	775	patch has no errors when building and testing our client artifacts.
+1	findbugs	134	the patch passed
+1	javadoc	47	the patch passed
		_ Other Tests _
-1	unit	5191	hadoop-hdfs in the patch failed.
+1	asflicense	36	The patch does not generate ASF License warnings.
		8746

Reason	Tests
Failed junit tests	hadoop.hdfs.web.TestWebHdfsTimeouts
	hadoop.hdfs.TestFileCreation
	hadoop.hdfs.qjournal.server.TestJournalNodeSync
	hadoop.hdfs.server.balancer.TestBalancer
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-497/1/artifact/out/Dockerfile
GITHUB PR	#497
JIRA Issue	HDFS-14295
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ca58174fc52b 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `a106d2d`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-497/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-497/1/testReport/
Max. process+thread count	3154 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-497/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


          [HDFS-14295] Add CachedThreadPool for DataNode Transfers

0fae2a8

belugabehr force-pushed the HDFS-14295 branch from cfcc16e to 0fae2a8 Compare

March 12, 2019 14:51

hadoop-yetus commented Jul 19, 2019

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	12	#497 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#497
JIRA Issue	HDFS-14295
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-497/3/console
versions	git=2.7.4
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus commented Jul 26, 2019

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	13	#497 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#497
JIRA Issue	HDFS-14295
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-497/4/console
versions	git=2.7.4
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus commented Aug 2, 2019

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	9	#497 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#497
JIRA Issue	HDFS-14295
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-497/5/console
versions	git=2.17.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus commented Aug 8, 2019

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	9	#497 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#497
JIRA Issue	HDFS-14295
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-497/6/console
versions	git=2.17.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Contributor

jojochuang commented Aug 8, 2019

Already commited via the patch attached to the jira. Close this one.

jojochuang closed this

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request


          SAMZA-1243: Fix flaky tests in TestLocalStoreMonitor

906aa6b

Having attempted to reproduce this issue without success, careful analysis of the code indicates the underlying issue is most likely incomplete cleanup of file system directories after test execution possibly due to incomplete or manual test runs. To address this issue, this fix generates a different local store directory for every test to isolate file system side-effects across different tests and test runs.

Author: Ahmed Abdul Hamid <ahabdulh@ahabdulh-ld1.linkedin.biz>

Reviewers: Shanthoosh Venkataraman <svenkata@linkedin.com>

Closes apache#497 from ahmedahamid/dev/fix-1243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet