-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-14244. Refactor the libhdfspp cmake build files. #485
base: trunk
Are you sure you want to change the base?
Conversation
9af5057
to
e469ea1
Compare
set(_home "$ENV{${_home_name}}") | ||
elseif (DEFINED ${_home_name}) | ||
set(_home ${${_home_name}}) | ||
endif () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
include_directories(SYSTEM | ||
${ASIO_INCLUDE_DIR} | ||
${RAPIDXML_INCLUDE_DIR} | ||
${OPENSSL_INCLUDE_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(_home "$ENV{${_home_name}}") | ||
elseif (DEFINED ${_home_name}) | ||
set(_home ${${_home_name}}) | ||
endif () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
include_directories(SYSTEM | ||
${ASIO_INCLUDE_DIR} | ||
${RAPIDXML_INCLUDE_DIR} | ||
${OPENSSL_INCLUDE_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(_home "$ENV{${_home_name}}") | ||
elseif (DEFINED ${_home_name}) | ||
set(_home ${${_home_name}}) | ||
endif () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(_home "$ENV{${_home_name}}") | ||
elseif (DEFINED ${_home_name}) | ||
set(_home ${${_home_name}}) | ||
endif () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
include_directories(SYSTEM | ||
${ASIO_INCLUDE_DIR} | ||
${RAPIDXML_INCLUDE_DIR} | ||
${OPENSSL_INCLUDE_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(_home "$ENV{${_home_name}}") | ||
elseif (DEFINED ${_home_name}) | ||
set(_home ${${_home_name}}) | ||
endif () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
include_directories(SYSTEM | ||
${ASIO_INCLUDE_DIR} | ||
${RAPIDXML_INCLUDE_DIR} | ||
${OPENSSL_INCLUDE_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(_home "$ENV{${_home_name}}") | ||
elseif (DEFINED ${_home_name}) | ||
set(_home ${${_home_name}}) | ||
endif () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
include_directories(SYSTEM | ||
${ASIO_INCLUDE_DIR} | ||
${RAPIDXML_INCLUDE_DIR} | ||
${OPENSSL_INCLUDE_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(_home "$ENV{${_home_name}}") | ||
elseif (DEFINED ${_home_name}) | ||
set(_home ${${_home_name}}) | ||
endif () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
include_directories(SYSTEM | ||
${ASIO_INCLUDE_DIR} | ||
${RAPIDXML_INCLUDE_DIR} | ||
${OPENSSL_INCLUDE_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(_home "$ENV{${_home_name}}") | ||
elseif (DEFINED ${_home_name}) | ||
set(_home ${${_home_name}}) | ||
endif () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
include_directories(SYSTEM | ||
${ASIO_INCLUDE_DIR} | ||
${RAPIDXML_INCLUDE_DIR} | ||
${OPENSSL_INCLUDE_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(_home "$ENV{${_home_name}}") | ||
elseif (DEFINED ${_home_name}) | ||
set(_home ${${_home_name}}) | ||
endif () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
include_directories(SYSTEM | ||
${ASIO_INCLUDE_DIR} | ||
${RAPIDXML_INCLUDE_DIR} | ||
${OPENSSL_INCLUDE_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
💔 -1 overall
This message was automatically generated. |
…h of the header files from common to include so that the examples didn't need to use files that we aren't installing.
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
- Fix flaky test, `TestProcessJob` `testProcessJobKillShouldWork`, which was failing intermittently due to a race condition. In particular, the thread running the test could assert `jobModelManager.stopped` before another thread, enclosed within `ProcessJob.submit`, could actually invoke `jobModelManager.stop`. + Refactor `ProcessJob` to improve its overall robustness + Handle corner cases, e.g. + Fail gracefully if starting process within `ProcessJob.submit` throws + Ignore attempts to kill a job before it is submitted + Ensure job status is always set appropriately + Remove unnecessary stdout/stderr piping code + Employ `wait`/`notify` instead of `Thread.sleep` + Eliminate all artificial wait method invocations intended to influence inter-thread execution order in unit tests + Add more unit tests Author: Ahmed Abdul Hamid <ahabdulh@ahabdulh-ld1.linkedin.biz> Reviewers: Boris S<sborya@apache.org>, Shanthoosh V<svenkata@linkedin.com> Closes apache#485 from ahmedahamid/master
Refactoring the hdfs++ build scripts.
In particular:
These will remove about 150kloc from Hadoop.