HDFS-14244. Refactor the libhdfspp cmake build files. #485
+1,633
−145,352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omalley
force-pushed
the
hdfs-14244
branch
3 times, most recently
from
9af5057
to
e469ea1
Compare
| set(_home "$ENV{${_home_name}}") | ||
| elseif (DEFINED ${_home_name}) | ||
| set(_home ${${_home_name}}) | ||
| endif () |
| set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
| set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
| set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
|
| include_directories(SYSTEM | ||
| ${ASIO_INCLUDE_DIR} | ||
| ${RAPIDXML_INCLUDE_DIR} | ||
| ${OPENSSL_INCLUDE_DIR} |
| set(_home "$ENV{${_home_name}}") | ||
| elseif (DEFINED ${_home_name}) | ||
| set(_home ${${_home_name}}) | ||
| endif () |
| set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
| set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
| set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
|
| include_directories(SYSTEM | ||
| ${ASIO_INCLUDE_DIR} | ||
| ${RAPIDXML_INCLUDE_DIR} | ||
| ${OPENSSL_INCLUDE_DIR} |
| set(_home "$ENV{${_home_name}}") | ||
| elseif (DEFINED ${_home_name}) | ||
| set(_home ${${_home_name}}) | ||
| endif () |
| set(_home "$ENV{${_home_name}}") | ||
| elseif (DEFINED ${_home_name}) | ||
| set(_home ${${_home_name}}) | ||
| endif () |
| set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
| set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
| set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
|
| include_directories(SYSTEM | ||
| ${ASIO_INCLUDE_DIR} | ||
| ${RAPIDXML_INCLUDE_DIR} | ||
| ${OPENSSL_INCLUDE_DIR} |
| set(_home "$ENV{${_home_name}}") | ||
| elseif (DEFINED ${_home_name}) | ||
| set(_home ${${_home_name}}) | ||
| endif () |
| set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
| set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
| set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
|
| include_directories(SYSTEM | ||
| ${ASIO_INCLUDE_DIR} | ||
| ${RAPIDXML_INCLUDE_DIR} | ||
| ${OPENSSL_INCLUDE_DIR} |
| set(_home "$ENV{${_home_name}}") | ||
| elseif (DEFINED ${_home_name}) | ||
| set(_home ${${_home_name}}) | ||
| endif () |
| set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
| set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
| set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
|
| include_directories(SYSTEM | ||
| ${ASIO_INCLUDE_DIR} | ||
| ${RAPIDXML_INCLUDE_DIR} | ||
| ${OPENSSL_INCLUDE_DIR} |
| set(_home "$ENV{${_home_name}}") | ||
| elseif (DEFINED ${_home_name}) | ||
| set(_home ${${_home_name}}) | ||
| endif () |
| set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
| set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
| set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
|
| include_directories(SYSTEM | ||
| ${ASIO_INCLUDE_DIR} | ||
| ${RAPIDXML_INCLUDE_DIR} | ||
| ${OPENSSL_INCLUDE_DIR} |
| set(_home "$ENV{${_home_name}}") | ||
| elseif (DEFINED ${_home_name}) | ||
| set(_home ${${_home_name}}) | ||
| endif () |
| set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
| set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
| set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
|
| include_directories(SYSTEM | ||
| ${ASIO_INCLUDE_DIR} | ||
| ${RAPIDXML_INCLUDE_DIR} | ||
| ${OPENSSL_INCLUDE_DIR} |
| set(_home "$ENV{${_home_name}}") | ||
| elseif (DEFINED ${_home_name}) | ||
| set(_home ${${_home_name}}) | ||
| endif () |
| set(${_upper_name}_FOUND TRUE PARENT_SCOPE) | ||
| set(${_upper_name}_INCLUDE_DIR ${_include_dir} PARENT_SCOPE) | ||
| set(${_upper_name}_LIBRARIES "${_libraries}" PARENT_SCOPE) | ||
|
|
| include_directories(SYSTEM | ||
| ${ASIO_INCLUDE_DIR} | ||
| ${RAPIDXML_INCLUDE_DIR} | ||
| ${OPENSSL_INCLUDE_DIR} |
|
💔 -1 overall
This message was automatically generated. |
…h of the header files from common to include so that the examples didn't need to use files that we aren't installing.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
- Fix flaky test, `TestProcessJob` `testProcessJobKillShouldWork`, which was failing intermittently due to a race condition. In particular, the thread running the test could assert `jobModelManager.stopped` before another thread, enclosed within `ProcessJob.submit`, could actually invoke `jobModelManager.stop`.
+ Refactor `ProcessJob` to improve its overall robustness
+ Handle corner cases, e.g.
+ Fail gracefully if starting process within `ProcessJob.submit` throws
+ Ignore attempts to kill a job before it is submitted
+ Ensure job status is always set appropriately
+ Remove unnecessary stdout/stderr piping code
+ Employ `wait`/`notify` instead of `Thread.sleep`
+ Eliminate all artificial wait method invocations intended to influence inter-thread execution order in unit tests
+ Add more unit tests
Author: Ahmed Abdul Hamid <ahabdulh@ahabdulh-ld1.linkedin.biz>
Reviewers: Boris S<sborya@apache.org>, Shanthoosh V<svenkata@linkedin.com>
Closes apache#485 from ahmedahamid/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the hdfs++ build scripts.
In particular:
These will remove about 150kloc from Hadoop.