HADOOP-18406: Adds alignment context to call path for creating RPC proxy with multiple connections per user. #4748

simbadzina · 2022-08-16T18:57:21Z

Description of PR

HDFS-13274 (RBF: Extend RouterRpcClient to use multiple sockets) gets the RPC proxy using methods which do not allow using an alignment context. These methods were added in HADOOP-13144 (Enhancing IPC client throughput via multiple connections per user).

This change adds an alignment context as an argument for methods in the call path for creating the proxy.

How was this patch tested?

Ran tests in TestConnectionManager and TestRPC.

For code changes:

[ x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

hadoop-yetus · 2022-08-17T10:15:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 0s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 59s		trunk passed
+1 💚	compile	23m 45s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	21m 43s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 49s		trunk passed
+1 💚	mvnsite	2m 16s		trunk passed
+1 💚	javadoc	1m 39s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 18s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 5s		trunk passed
+1 💚	shadedclient	23m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 7s		the patch passed
+1 💚	compile	22m 23s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	22m 23s		the patch passed
+1 💚	compile	20m 44s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 44s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 41s	/results-checkstyle-hadoop-common-project_hadoop-common.txt	hadoop-common-project/hadoop-common: The patch generated 2 new + 222 unchanged - 0 fixed = 224 total (was 222)
+1 💚	mvnsite	2m 8s		the patch passed
-1 ❌	javadoc	1m 36s	/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
+1 💚	javadoc	1m 20s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 7s		the patch passed
+1 💚	shadedclient	23m 38s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 48s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 33s		The patch does not generate ASF License warnings.
		219m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4748/1/artifact/out/Dockerfile
GITHUB PR	#4748
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 1d6b64b17e74 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 35d82a4634c5f50620532a23705112a0ade5d7cb
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4748/1/testReport/
Max. process+thread count	2564 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4748/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-08-17T17:13:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 29s		trunk passed
+1 💚	compile	23m 6s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 39s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 47s		trunk passed
+1 💚	mvnsite	2m 10s		trunk passed
+1 💚	javadoc	1m 46s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 21s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 11s		trunk passed
+1 💚	shadedclient	23m 30s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 5s		the patch passed
+1 💚	compile	22m 26s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	22m 26s		the patch passed
+1 💚	compile	20m 40s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 40s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 40s		the patch passed
+1 💚	mvnsite	2m 8s		the patch passed
+1 💚	javadoc	1m 35s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 22s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 8s		the patch passed
+1 💚	shadedclient	23m 47s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 39s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 34s		The patch does not generate ASF License warnings.
		216m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4748/2/artifact/out/Dockerfile
GITHUB PR	#4748
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux a4991abd45ba 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 552669da76dfa9a059adb98a9cde92b425926b92
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4748/2/testReport/
Max. process+thread count	2220 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4748/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

…oxy with multiple connections per user.

omalley · 2022-08-24T00:01:59Z

+1 LGTM.

hadoop-yetus · 2022-08-24T01:09:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 24s		trunk passed
+1 💚	compile	23m 10s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 44s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 46s		trunk passed
+1 💚	mvnsite	2m 9s		trunk passed
+1 💚	javadoc	1m 46s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 21s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 13s		trunk passed
+1 💚	shadedclient	23m 45s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 6s		the patch passed
+1 💚	compile	22m 25s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	22m 25s		the patch passed
+1 💚	compile	20m 39s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 39s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 43s		the patch passed
+1 💚	mvnsite	2m 8s		the patch passed
+1 💚	javadoc	1m 37s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 24s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 8s		the patch passed
+1 💚	shadedclient	23m 31s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 52s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 33s		The patch does not generate ASF License warnings.
		216m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4748/3/artifact/out/Dockerfile
GITHUB PR	#4748
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 224c91da7a97 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `330df2d`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4748/3/testReport/
Max. process+thread count	3149 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4748/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

…oxy with multiple connections per user. Fixes #4748 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>

…oxy with multiple connections per user. Fixes apache#4748 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>

…oxy with multiple connections per user. Fixes apache#4748 Signed-off-by: Owen O'Malley <oomalley@linkedin.com> RB=3584387 ACLOVERRIDE

…oxy with multiple connections per user. Fixes apache#4748 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>

simbadzina force-pushed the sdzinama-multisocket-alignment branch from c16e4b1 to 35d82a4 Compare August 16, 2022 19:01

simbadzina force-pushed the sdzinama-multisocket-alignment branch from 35d82a4 to 552669d Compare August 17, 2022 13:36

HADOOP-18406: Adds alignment context to call path for creating RPC pr…

330df2d

…oxy with multiple connections per user.

simbadzina force-pushed the sdzinama-multisocket-alignment branch from 552669d to 330df2d Compare August 23, 2022 21:31

omalley closed this in 4890ba5 Aug 24, 2022

omalley pushed a commit that referenced this pull request Aug 24, 2022

HADOOP-18406: Adds alignment context to call path for creating RPC pr…

0326b7e

…oxy with multiple connections per user. Fixes #4748 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>

LiuGuH pushed a commit to LiuGuH/hadoop that referenced this pull request Mar 29, 2024

HADOOP-18406: Adds alignment context to call path for creating RPC pr…

b233b7d

…oxy with multiple connections per user. Fixes apache#4748 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>

simbadzina deleted the sdzinama-multisocket-alignment branch June 28, 2024 20:22

LiuGuH pushed a commit to LiuGuH/hadoop that referenced this pull request Jul 4, 2024

HADOOP-18406: Adds alignment context to call path for creating RPC pr…

3a1f8c0

…oxy with multiple connections per user. Fixes apache#4748 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-18406: Adds alignment context to call path for creating RPC proxy with multiple connections per user. #4748

HADOOP-18406: Adds alignment context to call path for creating RPC proxy with multiple connections per user. #4748

Uh oh!

simbadzina commented Aug 16, 2022

Uh oh!

hadoop-yetus commented Aug 17, 2022

Uh oh!

hadoop-yetus commented Aug 17, 2022

Uh oh!

omalley commented Aug 24, 2022

Uh oh!

hadoop-yetus commented Aug 24, 2022

Uh oh!

Uh oh!

HADOOP-18406: Adds alignment context to call path for creating RPC proxy with multiple connections per user. #4748

HADOOP-18406: Adds alignment context to call path for creating RPC proxy with multiple connections per user. #4748

Uh oh!

Conversation

simbadzina commented Aug 16, 2022

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Aug 17, 2022

Uh oh!

hadoop-yetus commented Aug 17, 2022

Uh oh!

omalley commented Aug 24, 2022

Uh oh!

hadoop-yetus commented Aug 24, 2022

Uh oh!

Uh oh!