YARN-11240. Fix incorrect placeholder in yarn-module. #4678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@ayushtkn Can you help review this pr? Thank you very much! |
ayushtkn
reviewed
Aug 21, 2022
| @@ -1139,7 +1139,7 @@ public void syncSysFs(Service yarnApp) { | |||
| LOG.info("YARN sysfs synchronized."); | |||
| } | |||
| } catch (IOException | URISyntaxException | InterruptedException e) { | |||
| LOG.error("Fail to sync service spec: {}", e); | |||
| LOG.error("Fail to sync service spec: {}", e.getMessage(), e); | |||
There was a problem hiding this comment.
No need to keep the message, just e is enough
There was a problem hiding this comment.
Thank you very much for helping to review the code!
There is a problem with the use of placeholders in this part of the code.
When an exception occurs, the placeholder is not replaced, We can view the following logs.
2022-08-22 09:59:13,755 ERROR [Listener at 0.0.0.0/51213] service.TestServiceAM (TestServiceAM.java:testSyncSysFS(556)) -
Fail to sync sysfs: {}
java.lang.RuntimeException: tensorflow syncSysFs Error
at org.apache.hadoop.yarn.service.ServiceScheduler.syncSysFs(ServiceScheduler.java:1137)
at org.apache.hadoop.yarn.service.TestServiceAM.testSyncSysFS(TestServiceAM.java:551)
...
Because the log uses the void error(String var1, Throwable var2); method, it cannot be replaced.
So I added e.getMessage() to make the placeholder take effect and the log format would be better.
2022-08-22 10:03:55,450 ERROR [Listener at 0.0.0.0/51354] service.TestServiceAM (TestServiceAM.java:testSyncSysFS(556)) -
Fail to sync sysfs: tensorflow syncSysFs Error
java.lang.RuntimeException: tensorflow syncSysFs Error
at org.apache.hadoop.yarn.service.ServiceScheduler.syncSysFs(ServiceScheduler.java:1137)
at org.apache.hadoop.yarn.service.TestServiceAM.testSyncSysFS(TestServiceAM.java:551)
...
There was a problem hiding this comment.
Can I remove the placeholder?
There was a problem hiding this comment.
Yes, tensorflow syncSysFs Error is getting printed twice, we don’t need that
There was a problem hiding this comment.
Thanks for your suggestion, I will fix it.
| @@ -553,7 +553,7 @@ public void testSyncSysFS() { | |||
| am.stop(); | |||
| am.close(); | |||
| } catch (Exception e) { | |||
| LOG.error("Fail to sync sysfs: {}", e); | |||
| LOG.error("Fail to sync sysfs: {}", e.getMessage(), e); | |||
There was a problem hiding this comment.
Keep only e, message will come as part of that
|
🎊 +1 overall
This message was automatically generated. |
|
@ayushtkn Can you help review the code again? Thank you very much! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…Contributed by fanshilun Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: YARN-11240. Fix incorrect placeholder in yarn-module.