-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDFS-16709. Remove redundant cast in FSEditLogOp.class #4667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can the unchecked flag be removed?
|
💔 -1 overall
This message was automatically generated. |
Thanks @slfan1989 for your review.
I think we need it. Because after removing it, the IDEA warns Unchecked cast: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the explanation, I have understood your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1.
@Hexiaoqiao @ayushtkn @goiri Master, can help me merge this PR into trunk? Thanks |
@slfan1989 @Hexiaoqiao @goiri @ayushtkn Master, thank you very much for helping me review this patch. |
… Contributed by ZanderXu. Reviewed-by: Inigo Goiri <inigoiri@apache.org> Reviewed-by: He Xiaoqiao <hexiaoqiao@apache.org> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
Description of PR
When I read some class about Edits of NameNode, I found that there are much redundant cast in FSEditLogOp.class, I feel that we should remove them.
Such as:
Because cache.get() have cast the response to T, so we can remove the redundant cast.