Skip to content

HADOOP-18074 - Partial/Incomplete groups list can be returned in LDAP… #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 14, 2022

Conversation

lmccay
Copy link
Contributor

@lmccay lmccay commented Jul 11, 2022

…… (#4503)

Description of PR

Description of PR
LdapGroupsMapping could return a partial list of group names due to encountering a NamingException while acquiring
the RDN for a DN. This was due to not clearing the partially built list which results in the secondary query not being
attempted. This PR clears the partially built list and forces the secondary query to be called.

How was this patch tested?
Existing unit tests were run and a new unit test added to insure that the secondary query is indeed being called.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@lmccay
Copy link
Contributor Author

lmccay commented Jul 11, 2022

+1 provided by @steveloughran via #4503 - waiting on yetus greenlight here...

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 10m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 35m 55s branch-3.3 passed
+1 💚 compile 18m 9s branch-3.3 passed
+1 💚 checkstyle 1m 20s branch-3.3 passed
+1 💚 mvnsite 2m 3s branch-3.3 passed
+1 💚 javadoc 1m 29s branch-3.3 passed
+1 💚 spotbugs 3m 10s branch-3.3 passed
+1 💚 shadedclient 27m 39s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
-1 ❌ mvninstall 0m 41s /patch-mvninstall-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ compile 1m 4s /patch-compile-root.txt root in the patch failed.
-1 ❌ javac 1m 4s /patch-compile-root.txt root in the patch failed.
+1 💚 blanks 0m 1s The patch has no blanks issues.
+1 💚 checkstyle 0m 40s the patch passed
-1 ❌ mvnsite 0m 46s /patch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
+1 💚 javadoc 0m 33s the patch passed
-1 ❌ spotbugs 0m 41s /patch-spotbugs-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ shadedclient 6m 41s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 0m 43s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
+1 💚 asflicense 0m 40s The patch does not generate ASF License warnings.
108m 46s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/1/artifact/out/Dockerfile
GITHUB PR #4550
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 5371fdc3066d 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 5b62ea4
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/1/testReport/
Max. process+thread count 723 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

doesn't build; list/set mismatch, interesting.

@lmccay
Copy link
Contributor Author

lmccay commented Jul 12, 2022

@steveloughran - I did notice that change and didn't think it was from me. It must have been changed prior to my patch on trunk and applied here via the diff. I'll fix it. Thanks.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 58s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 35m 41s branch-3.3 passed
+1 💚 compile 18m 11s branch-3.3 passed
+1 💚 checkstyle 1m 32s branch-3.3 passed
+1 💚 mvnsite 2m 5s branch-3.3 passed
+1 💚 javadoc 1m 28s branch-3.3 passed
+1 💚 spotbugs 3m 5s branch-3.3 passed
+1 💚 shadedclient 27m 27s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
-1 ❌ mvninstall 0m 57s /patch-mvninstall-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ compile 1m 27s /patch-compile-root.txt root in the patch failed.
-1 ❌ javac 1m 27s /patch-compile-root.txt root in the patch failed.
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 40s the patch passed
-1 ❌ mvnsite 1m 2s /patch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
+1 💚 javadoc 0m 34s the patch passed
-1 ❌ spotbugs 0m 58s /patch-spotbugs-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ shadedclient 7m 46s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 1m 3s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
100m 16s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/2/artifact/out/Dockerfile
GITHUB PR #4550
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 80dc67418dce 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / e84edd9
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/2/testReport/
Max. process+thread count 548 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/2/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 35m 33s branch-3.3 passed
+1 💚 compile 17m 59s branch-3.3 passed
+1 💚 checkstyle 1m 31s branch-3.3 passed
+1 💚 mvnsite 2m 8s branch-3.3 passed
+1 💚 javadoc 1m 25s branch-3.3 passed
+1 💚 spotbugs 3m 6s branch-3.3 passed
+1 💚 shadedclient 27m 38s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 2s the patch passed
+1 💚 compile 17m 18s the patch passed
+1 💚 javac 17m 18s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 26s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
+1 💚 mvnsite 2m 3s the patch passed
+1 💚 javadoc 1m 18s the patch passed
-1 ❌ spotbugs 3m 7s /new-spotbugs-hadoop-common-project_hadoop-common.html hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 shadedclient 27m 22s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 9s hadoop-common in the patch passed.
+1 💚 asflicense 1m 31s The patch does not generate ASF License warnings.
162m 53s
Reason Tests
SpotBugs module:hadoop-common-project/hadoop-common
Possible null pointer dereference of groups in org.apache.hadoop.security.LdapGroupsMapping.doGetGroups(String, int) Dereferenced at LdapGroupsMapping.java:groups in org.apache.hadoop.security.LdapGroupsMapping.doGetGroups(String, int) Dereferenced at LdapGroupsMapping.java:[line 550]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/3/artifact/out/Dockerfile
GITHUB PR #4550
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 0c9f6fc86db3 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 25abfac
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/3/testReport/
Max. process+thread count 1268 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/3/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 8m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 36m 30s branch-3.3 passed
+1 💚 compile 18m 36s branch-3.3 passed
+1 💚 checkstyle 1m 0s branch-3.3 passed
+1 💚 mvnsite 1m 51s branch-3.3 passed
+1 💚 javadoc 0m 51s branch-3.3 passed
+1 💚 spotbugs 2m 41s branch-3.3 passed
+1 💚 shadedclient 25m 57s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 59s the patch passed
+1 💚 compile 18m 23s the patch passed
+1 💚 javac 18m 23s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 50s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
+1 💚 mvnsite 1m 32s the patch passed
+1 💚 javadoc 0m 42s the patch passed
+1 💚 spotbugs 2m 39s the patch passed
+1 💚 shadedclient 25m 20s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 52s hadoop-common in the patch passed.
+1 💚 asflicense 0m 54s The patch does not generate ASF License warnings.
164m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/4/artifact/out/Dockerfile
GITHUB PR #4550
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 52dc230bed16 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 92bfea8
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/4/testReport/
Max. process+thread count 3153 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/4/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 66m 28s branch-3.3 passed
+1 💚 compile 19m 37s branch-3.3 passed
+1 💚 checkstyle 0m 57s branch-3.3 passed
+1 💚 mvnsite 1m 33s branch-3.3 passed
+1 💚 javadoc 0m 54s branch-3.3 passed
+1 💚 spotbugs 2m 43s branch-3.3 passed
+1 💚 shadedclient 26m 10s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 57s the patch passed
+1 💚 compile 18m 39s the patch passed
+1 💚 javac 18m 39s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 52s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
+1 💚 mvnsite 1m 38s the patch passed
+1 💚 javadoc 0m 42s the patch passed
+1 💚 spotbugs 2m 35s the patch passed
+1 💚 shadedclient 24m 57s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 50s hadoop-common in the patch passed.
+1 💚 asflicense 0m 58s The patch does not generate ASF License warnings.
186m 59s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/5/artifact/out/Dockerfile
GITHUB PR #4550
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 763b9aa8338a 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 22ebd4e
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/5/testReport/
Max. process+thread count 1549 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/5/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 10m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 40m 35s branch-3.3 passed
+1 💚 compile 18m 46s branch-3.3 passed
+1 💚 checkstyle 1m 15s branch-3.3 passed
+1 💚 mvnsite 1m 52s branch-3.3 passed
+1 💚 javadoc 1m 10s branch-3.3 passed
+1 💚 spotbugs 2m 58s branch-3.3 passed
+1 💚 shadedclient 28m 41s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 2s the patch passed
+1 💚 compile 17m 52s the patch passed
+1 💚 javac 17m 51s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 8s the patch passed
+1 💚 mvnsite 1m 50s the patch passed
+1 💚 javadoc 1m 0s the patch passed
+1 💚 spotbugs 2m 55s the patch passed
+1 💚 shadedclient 28m 15s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 3s hadoop-common in the patch passed.
+1 💚 asflicense 1m 13s The patch does not generate ASF License warnings.
178m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/6/artifact/out/Dockerfile
GITHUB PR #4550
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux be4b3310f536 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / e03105b
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/6/testReport/
Max. process+thread count 2364 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4550/6/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

+1

@steveloughran steveloughran merged commit f015c7f into apache:branch-3.3 Jul 14, 2022
steveloughran pushed a commit to steveloughran/hadoop that referenced this pull request Jul 16, 2022
apache#4503)

Partial/Incomplete groups list can be returned in LDAP groups lookup.

Backported in apache#4550; minor tuning of parameters needed.

Contributed by larry mccay

Change-Id: I9a9571239ac533680a08de650f84e431e9022c79
steveloughran added a commit that referenced this pull request Jul 17, 2022
#4503)


Partial/Incomplete groups list can be returned in LDAP groups lookup.

Backported in #4550; minor tuning of parameters needed.

Contributed by larry mccay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants