You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description of PR
LdapGroupsMapping could return a partial list of group names due to encountering a NamingException while acquiring
the RDN for a DN. This was due to not clearing the partially built list which results in the secondary query not being
attempted. This PR clears the partially built list and forces the secondary query to be called.
How was this patch tested?
Existing unit tests were run and a new unit test added to insure that the secondary query is indeed being called.
For code changes:
Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?
@steveloughran - I did notice that change and didn't think it was from me. It must have been changed prior to my patch on trunk and applied here via the diff. I'll fix it. Thanks.
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚
shadedclient
27m 22s
patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚
unit
18m 9s
hadoop-common in the patch passed.
+1 💚
asflicense
1m 31s
The patch does not generate ASF License warnings.
162m 53s
Reason
Tests
SpotBugs
module:hadoop-common-project/hadoop-common
Possible null pointer dereference of groups in org.apache.hadoop.security.LdapGroupsMapping.doGetGroups(String, int) Dereferenced at LdapGroupsMapping.java:groups in org.apache.hadoop.security.LdapGroupsMapping.doGetGroups(String, int) Dereferenced at LdapGroupsMapping.java:[line 550]
apache#4503)
Partial/Incomplete groups list can be returned in LDAP groups lookup.
Backported in apache#4550; minor tuning of parameters needed.
Contributed by larry mccay
Change-Id: I9a9571239ac533680a08de650f84e431e9022c79
#4503)
Partial/Incomplete groups list can be returned in LDAP groups lookup.
Backported in #4550; minor tuning of parameters needed.
Contributed by larry mccay
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…… (#4503)
Description of PR
Description of PR
LdapGroupsMapping could return a partial list of group names due to encountering a NamingException while acquiring
the RDN for a DN. This was due to not clearing the partially built list which results in the secondary query not being
attempted. This PR clears the partially built list and forces the secondary query to be called.
How was this patch tested?
Existing unit tests were run and a new unit test added to insure that the secondary query is indeed being called.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?