HADOOP-18074 - Partial/Incomplete groups list can be returned in LDAP… #4503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
production code looks good, commented on the tests with my main concern being "mockito test maintenance is painful, so we should help whoever has to do it as much as we can" +1 pending those changes for merging into trunk/branch-3.3, to see if any surprises happen this week. i will merge it in to the 3.3.4 release next week |
steveloughran
requested changes
Jun 27, 2022
| groupsMapping.setConf(conf); | ||
| // Username is arbitrary, since the spy is mocked to respond the same, | ||
| // regardless of input | ||
| List<String> groups = groupsMapping.getGroups("some_user"); | ||
|
|
||
| Assert.assertEquals(expectedGroups, groups); | ||
| Assert.assertFalse(groupsMapping.isSecondaryQueryCalled()); |
There was a problem hiding this comment.
add an error message for the assertion failure
|
|
||
| // expect secondary query to be called: getGroups() | ||
| Assert.assertTrue(groupsMapping.isSecondaryQueryCalled()); |
There was a problem hiding this comment.
add an error message
...common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
Show resolved
Hide resolved
...adoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMappingWithOneQuery.java
Show resolved
Hide resolved
| } | ||
|
|
||
| class TestLdapGroupsMapping extends LdapGroupsMapping { |
There was a problem hiding this comment.
nit private final. probably static too, right
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
lmccay
added a commit
to lmccay/hadoop
that referenced
this pull request
Jul 11, 2022
4 tasks
steveloughran
pushed a commit
to steveloughran/hadoop
that referenced
this pull request
Jul 16, 2022
apache#4503) Partial/Incomplete groups list can be returned in LDAP groups lookup. Backported in apache#4550; minor tuning of parameters needed. Contributed by larry mccay Change-Id: I9a9571239ac533680a08de650f84e431e9022c79
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
apache#4503) * HADOOP-18074 - Partial/Incomplete groups list can be returned in LDAP groups lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… groups lookup
Description of PR
LdapGroupsMapping could return a partial list of group names due to encountering a NamingException while acquiring
the RDN for a DN. This was due to not clearing the partially built list which results in the secondary query not being
attempted. This PR clears the partially built list and forces the secondary query to be called.
How was this patch tested?
Existing unit tests were run and a new unit test added to insure that the secondary query is indeed being called.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?