HDFS-16473. Make HDFS stat tool cross platform #4145

GauthamBanasandra · 2022-04-07T04:40:44Z

Description of PR

The source files for hdfs_stat uses getopt for parsing the command line arguments. getopt is available only on Linux and thus, isn't cross platform. We need to replace getopt with boost::program_options to make this tool cross platform.

How was this patch tested?

hdfs_stat

This tool was testing locally with the Hadoop cluster setup in pseudo-distributed mode.
I ran the tool by providing the path to a file as the argument.

$ ./hdfs_stat ~/some-dir/some-data.txt

I verified the output against the information displayed in the UI.

I then ran the tool by providing the path to a directory as the argument.

$ ./hdfs_stat ~/some-dir

I verified the output against the information displayed in the UI.

I then ran the tool by providing a non-existent path as the argument.

$ ./hdfs_stat ~/some-non-existent-path

We note that an appropriate error message is reported in the above output.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2022-04-07T07:25:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	38m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 39s		trunk passed
+1 💚	compile	3m 50s		trunk passed
+1 💚	mvnsite	0m 25s		trunk passed
+1 💚	shadedclient	65m 50s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 14s		the patch passed
+1 💚	compile	3m 42s		the patch passed
+1 💚	cc	3m 42s		the patch passed
+1 💚	golang	3m 42s		the patch passed
+1 💚	javac	3m 42s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 17s		the patch passed
+1 💚	shadedclient	19m 18s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	32m 46s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		163m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4145/1/artifact/out/Dockerfile
GITHUB PR	#4145
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell golang
uname	Linux d1c9363bf8ba 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `af84879`
Default Java	Red Hat, Inc.-1.8.0_322-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4145/1/testReport/
Max. process+thread count	682 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4145/1/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-04-07T09:53:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	23m 55s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	27m 43s		trunk passed
+1 💚	compile	4m 1s		trunk passed
+1 💚	mvnsite	0m 42s		trunk passed
+1 💚	shadedclient	54m 57s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 22s		the patch passed
+1 💚	compile	3m 46s		the patch passed
+1 💚	cc	3m 46s		the patch passed
+1 💚	golang	3m 46s		the patch passed
+1 💚	javac	3m 46s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 24s		the patch passed
+1 💚	shadedclient	22m 48s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	37m 36s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 47s		The patch does not generate ASF License warnings.
		147m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4145/1/artifact/out/Dockerfile
GITHUB PR	#4145
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell golang
uname	Linux 415ac826771a 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `af84879`
Default Java	Red Hat, Inc.-1.8.0_312-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4145/1/testReport/
Max. process+thread count	691 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4145/1/console
versions	git=2.27.0 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-04-07T12:25:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	12m 16s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	30m 21s		trunk passed
+1 💚	compile	3m 40s		trunk passed
+1 💚	mvnsite	0m 35s		trunk passed
+1 💚	shadedclient	64m 41s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 16s		the patch passed
+1 💚	compile	3m 37s		the patch passed
+1 💚	cc	3m 37s		the patch passed
+1 💚	golang	3m 37s		the patch passed
+1 💚	javac	3m 37s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 18s		the patch passed
+1 💚	shadedclient	28m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	39m 26s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		152m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4145/1/artifact/out/Dockerfile
GITHUB PR	#4145
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell golang
uname	Linux 2f698c13849e 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `af84879`
Default Java	Debian-11.0.14+9-post-Debian-1deb10u1
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4145/1/testReport/
Max. process+thread count	740 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4145/1/console
versions	git=2.20.1 maven=3.6.0
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-04-07T14:22:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	22m 54s		trunk passed
+1 💚	compile	3m 45s		trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	3m 47s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	mvnsite	0m 23s		trunk passed
+1 💚	shadedclient	50m 59s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 15s		the patch passed
+1 💚	compile	3m 43s		the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	cc	3m 43s		the patch passed
+1 💚	golang	3m 43s		the patch passed
+1 💚	javac	3m 43s		the patch passed
+1 💚	compile	3m 45s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	cc	3m 45s		the patch passed
+1 💚	golang	3m 45s		the patch passed
+1 💚	javac	3m 45s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 17s		the patch passed
+1 💚	shadedclient	20m 45s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	32m 59s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		116m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4145/1/artifact/out/Dockerfile
GITHUB PR	#4145
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell golang
uname	Linux 1d529aefa8dd 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `af84879`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4145/1/testReport/
Max. process+thread count	699 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4145/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

* The source files for hdfs_stat uses getopt for parsing the command line arguments. * getopt is available only on Linux and thus, isn't cross platform. * We need to replace getopt with boost::program_options to make this tool cross platform.

GauthamBanasandra added 5 commits April 6, 2022 23:23

Make HDFS stat cross platform

3371d8a

Add HDFS stat mock

3b62a90

Add unit tests

05c4ca6

Add documentation

cc45528

Remove redundant file

af84879

GauthamBanasandra self-assigned this Apr 7, 2022

GauthamBanasandra added the HDFS label Apr 7, 2022

GauthamBanasandra marked this pull request as ready for review April 7, 2022 15:40

GauthamBanasandra requested a review from goiri April 7, 2022 15:40

goiri approved these changes Apr 8, 2022

View reviewed changes

GauthamBanasandra merged commit d5e97fe into apache:trunk Apr 8, 2022

GauthamBanasandra deleted the stat-x-platform branch April 8, 2022 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-16473. Make HDFS stat tool cross platform #4145

HDFS-16473. Make HDFS stat tool cross platform #4145

Uh oh!

GauthamBanasandra commented Apr 7, 2022

Uh oh!

hadoop-yetus commented Apr 7, 2022

Uh oh!

hadoop-yetus commented Apr 7, 2022

Uh oh!

hadoop-yetus commented Apr 7, 2022

Uh oh!

hadoop-yetus commented Apr 7, 2022

Uh oh!

Uh oh!

HDFS-16473. Make HDFS stat tool cross platform #4145

HDFS-16473. Make HDFS stat tool cross platform #4145

Uh oh!

Conversation

GauthamBanasandra commented Apr 7, 2022

Description of PR

How was this patch tested?

hdfs_stat

For code changes:

Uh oh!

hadoop-yetus commented Apr 7, 2022

Uh oh!

hadoop-yetus commented Apr 7, 2022

Uh oh!

hadoop-yetus commented Apr 7, 2022

Uh oh!

hadoop-yetus commented Apr 7, 2022

Uh oh!

Uh oh!