-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-18191. Log retry count while handling exceptions in RetryInvocationHandler #4133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
@tasanuma @Hexiaoqiao Could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me, please include in branch-3 too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.
Merged. Thanks for your contribution, @virajjasani. Thanks for your review, @steveloughran. |
There are some conflicts when I cherry-pick it into lower branches. |
Description of PR
As part of failure handling in RetryInvocationHandler, we log details of the Exception details with which API was invoked, failover attempts, delay.
For the purpose of better debugging as well as fine-tuning of retry params, it would be good to also log retry count that we already maintain in the Counter object.