Skip to content

HADOOP-18172: Changed scope for isRootInternalDir/getRootFallbackLink for InodeTree #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2022
Merged

HADOOP-18172: Changed scope for isRootInternalDir/getRootFallbackLink for InodeTree #4106

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff3a7c1
HADOOP-18172: Change scope of getRootFallbackLink for InodeTree
Mar 31, 2022
90f3e5a
Change back InterfaceAudience to Private
Mar 31, 2022
11706d2
Made resolve() and getHomeDirPrefixValue() also public
Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@

@InterfaceAudience.Private
@InterfaceStability.Unstable
abstract class InodeTree<T> {
public abstract class InodeTree<T> {
private static final Logger LOGGER =
LoggerFactory.getLogger(InodeTree.class.getName());

Expand Down Expand Up @@ -458,11 +458,11 @@ private boolean hasFallbackLink() {
* there will be root to root mapping. So, root does not represent as
* internalDir.
*/
protected boolean isRootInternalDir() {
public boolean isRootInternalDir() {
return root.isInternalDir();
}

protected INodeLink<T> getRootFallbackLink() {
public INodeLink<T> getRootFallbackLink() {
Preconditions.checkState(root.isInternalDir());
return rootFallbackLink;
}
Expand Down Expand Up @@ -742,7 +742,7 @@ private LinkEntry buildLinkRegexEntry(
* If the input pathname leads to an internal mount-table entry then
* the target file system is one that represents the internal inode.
*/
static class ResolveResult<T> {
public static class ResolveResult<T> {
final ResultKind kind;
final T targetFileSystem;
final String resolvedPath;
Expand Down Expand Up @@ -777,7 +777,7 @@ boolean isLastInternalDirLink() {
* @return ResolveResult which allows further resolution of the remaining path
* @throws IOException
*/
ResolveResult<T> resolve(final String p, final boolean resolveLastComponent)
public ResolveResult<T> resolve(final String p, final boolean resolveLastComponent)
throws IOException {
ResolveResult<T> resolveResult = null;
String[] path = breakIntoPathComponents(p);
Expand Down Expand Up @@ -957,7 +957,7 @@ public List<MountPoint<T>> getMountPoints() {
* @return home dir value from mount table; null if no config value
* was found.
*/
String getHomeDirPrefixValue() {
public String getHomeDirPrefixValue() {
return homedirPrefix;
}
}