-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16500. Make asynchronous blocks deletion lock and unlock durtion threshold configurable. #4061
Conversation
… threshold configurable.
💔 -1 overall
This message was automatically generated. |
@Hexiaoqiao could you please take a look? |
@smarthanwang Thanks for your work , new parameters need to be added to hdfs-default.xml. |
@zhuxiangyi good suggestion, I would fix it. |
Thanks @smarthanwang involve me here. It almost look good to me. Just one nit, it seems changes default value here, any consideration? Just suggest keep it if no any concerns. Thanks again. |
💔 -1 overall
This message was automatically generated. |
@Hexiaoqiao thanks for comment. |
Hi @Hexiaoqiao, do you have any suggestion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late response. LGTM. +1 from my side.
Will commit if no other more comments.
@Hexiaoqiao thanks for reviews. |
Committed to trunk. Thanks @smarthanwang for your contributions. |
@Hexiaoqiao thanks you. I would fix the checkstyle later |
@Hexiaoqiao I have filed issue https://issues.apache.org/jira/browse/HDFS-16553 to fix the checkstyle, please take a look. |
… threshold configurable. (apache#4061). Contributed by Chengwei Wang.
https://issues.apache.org/jira/browse/HDFS-16500
I have backport the nice feature HDFS-16043 to our internal branch, it works well in our testing cluster.
I think it's better to make the fields deleteBlockLockTimeMs and deleteBlockUnlockIntervalTimeMs configurable, so that we can control the lock and unlock duration.
And we should set the default value smaller to avoid blocking other requests long time when deleting some large directories.