You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source files for hdfs_get uses getopt for parsing the command line arguments. getopt is available only on Linux and thus, isn't cross platform. We need to replace getopt with boost::program_options to make these tools cross platform.
hdfs_get has the same functionality as hdfs_copyToLocal. Thus, we're reusing the same to implement hdfs_get.
How was this patch tested?
Given that hdfs_get has the same functionality as hdfs_copyToLocal, we've implemented hdfs::tools::Get by deriving from hdfs::tools::CopyToLocal. Since we've already tested hdfs::tools::CopyToLocal for functional correctness, we don't need to do any additional testing to validate the same for hdfs::tools::Get.
However, we do ensure that the correct tool name shows up for hdfs_copyToLocal and hdfs_get.
hdfs_copyToLocal
$ ./hdfs_copyToLocal -h
hdfs_get
$ ./hdfs_get -h
For code changes:
Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
The source files for
hdfs_get
usesgetopt
for parsing the command line arguments. getopt is available only on Linux and thus, isn't cross platform. We need to replace getopt withboost::program_options
to make these tools cross platform.hdfs_get
has the same functionality ashdfs_copyToLocal
. Thus, we're reusing the same to implementhdfs_get
.How was this patch tested?
Given that
hdfs_get
has the same functionality ashdfs_copyToLocal
, we've implementedhdfs::tools::Get
by deriving fromhdfs::tools::CopyToLocal
. Since we've already testedhdfs::tools::CopyToLocal
for functional correctness, we don't need to do any additional testing to validate the same forhdfs::tools::Get
.However, we do ensure that the correct tool name shows up for
hdfs_copyToLocal
andhdfs_get
.hdfs_copyToLocal
hdfs_get
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?